I would like to reindent circulation/returns.tt: Remove tabs, correct indentation, add some comments to clarify the structure.
Created attachment 91877 [details] [review] Bug 23399: Reindent returns.tt This patch reindents circulation/returns.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but each must take their own journey. Test the checkin process to confirm that everything still works correctly.
Created attachment 91878 [details] [review] Bug 23399: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality.
Created attachment 91910 [details] [review] Bug 23399: Reindent returns.tt This patch reindents circulation/returns.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but each must take their own journey. Test the checkin process to confirm that everything still works correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 91911 [details] [review] Bug 23399: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 92070 [details] [review] Bug 23399: Reindent returns.tt This patch reindents circulation/returns.tt to use four spaces, following coding guidelines. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but each must take their own journey. Test the checkin process to confirm that everything still works correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 92071 [details] [review] Bug 23399: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Always good to make the indenting a bit more sane.. thanks Owen! Passing QA
Nice work! Pushed to master for 19.11.00
Enhancement not pushed to 19.05.x