Many libraries now also sell a small number of goods as part of their offering, therefore the library system needs to double as a simple POS (Point Of Sale) system. This proposed feature will add a 'Pay' screen to the UI allowing for anonymous payments to be made against goods.
Created attachment 92066 [details] [review] Bug 23354: Initial work on payment screen
This is now ready for testing.. I'd love some feedback on the UX and things before adding the necessary tests and things to get it through QA.
(In reply to Martin Renvoize from comment #2) > This is now ready for testing.. I'd love some feedback on the UX and things > before adding the necessary tests and things to get it through QA. Hi Martin, Could you expand on the test plan a bit? Just want to make sure I don't miss anything :)
Created attachment 92431 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff
Created attachment 92432 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 92433 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff
(In reply to Hayley Mapley from comment #3) > (In reply to Martin Renvoize from comment #2) > > This is now ready for testing.. I'd love some feedback on the UX and things > > before adding the necessary tests and things to get it through QA. > > Hi Martin, > > Could you expand on the test plan a bit? Just want to make sure I don't miss > anything :) Hi Hayley, Thanks for showing interesting in this. I think the included test plans in the patches should now go some way towards a decent test plan for this, but do feel free to ask questions. Any feedback would be greatly appreciated.
Created attachment 92502 [details] Console errors
Hi Martin, Thanks for the test plans! I get up to 7) on the first patch, and when I click the Add button it doesn't add the item to the This sale box. No plack-errors, but the console had some output which I've attached in the screenshot I attached.
Created attachment 92830 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff
Created attachment 92831 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 92832 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff
Created attachment 92833 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page
Created attachment 92834 [details] [review] Bug 23354: Add permissions
Sorry Hayley, it just needed a re-base after the new datatables update recently pushed.. I've also added a followup bug that handles a few points brought up by the sponsors of the feature.
Created attachment 92873 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff
Created attachment 92874 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff
Created attachment 92875 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff
Created attachment 92876 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page
Created attachment 92877 [details] [review] Bug 23354: Add permissions
Created attachment 92878 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 92890 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe
Created attachment 92891 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe
Created attachment 92892 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe
Created attachment 92893 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe
Created attachment 92894 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe
Created attachment 92895 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe
The feature works, and the code is pretty clean. I have a few remarks to be considered: - We should really have a separate table and stop using MANUAL_INV. It feels really dirty to have a note field contain a decimal value to be used as a number. To start with. I think we agree on this, and there's even work from Josef that would do it. - Things look misaligned to me (hidpi laptop). - 'Collected from patron' should reuse some patron searching things already exist in the codebase. Thinking of the dialog to pick a guarantor. - Currency symbol is the pound one, no matter what the system is configured to use. - 'Click on the item cost' maybe instead of 'Click on the item'. - Are you planning on having an inventory of things to sell? I think the use of authorised values is very limited, besides my criticism. I expect librarians wanting to just scan the barcode and get the price on the screen.
(In reply to Tomás Cohen Arazi from comment #28) > The feature works, and the code is pretty clean. I have a few remarks to be > considered: > > - We should really have a separate table and stop using MANUAL_INV. It feels > really dirty to have a note field contain a decimal value to be used as a > number. To start with. I think we agree on this, and there's even work from > Josef that would do it. Totally agree here.. I was taking the pragmatic approach of not letting that work hold this up as we already have the MANUAL_INV code in place.. I intend to switch to our own table as a further bug down the line as we have more sponsorship in the pipeline for adding features which would require that distinction. > - Things look misaligned to me (hidpi laptop). Did you run the yarn build? I've tried to fix alignment once already, but perhaps there are some bits still needing a little work. > - 'Collected from patron' should reuse some patron searching things already > exist in the codebase. Thinking of the dialog to pick a guarantor. Not sure what you mean here? The 'Collected from patron' input is meant to be a monetary value. (Though I do also like the idea of enhancing the screen to allow a patron to be optionally linked to the transaction) > - Currency symbol is the pound one, no matter what the system is configured > to use. Oops.. I'll post a followup for that now. > - 'Click on the item cost' maybe instead of 'Click on the item'. Good catch. > - Are you planning on having an inventory of things to sell? I think the use > of authorised values is very limited, besides my criticism. I expect > librarians wanting to just scan the barcode and get the price on the screen. I very much do want to add such functionality, including things like barcodes, tax rates etc.. but I see that as part of a bigger piece to migrate MANUAL_INC outside of authorized values.
(In reply to Martin Renvoize from comment #29) > (In reply to Tomás Cohen Arazi from comment #28) > > The feature works, and the code is pretty clean. I have a few remarks to be > > considered: > > > > - We should really have a separate table and stop using MANUAL_INV. It feels > > really dirty to have a note field contain a decimal value to be used as a > > number. To start with. I think we agree on this, and there's even work from > > Josef that would do it. > > Totally agree here.. I was taking the pragmatic approach of not letting that > work hold this up as we already have the MANUAL_INV code in place.. I intend > to switch to our own table as a further bug down the line as we have more > sponsorship in the pipeline for adding features which would require that > distinction. Ok. > > - Things look misaligned to me (hidpi laptop). > > Did you run the yarn build? I've tried to fix alignment once already, but > perhaps there are some bits still needing a little work. That must be it. Re-testing today. > > - 'Collected from patron' should reuse some patron searching things already > > exist in the codebase. Thinking of the dialog to pick a guarantor. > > Not sure what you mean here? The 'Collected from patron' input is meant to > be a monetary value. (Though I do also like the idea of enhancing the screen > to allow a patron to be optionally linked to the transaction) I got it wrong! Ok! > > - Currency symbol is the pound one, no matter what the system is configured > > to use. > > Oops.. I'll post a followup for that now. > > > - 'Click on the item cost' maybe instead of 'Click on the item'. > > Good catch. > > > - Are you planning on having an inventory of things to sell? I think the use > > of authorised values is very limited, besides my criticism. I expect > > librarians wanting to just scan the barcode and get the price on the screen. > > I very much do want to add such functionality, including things like > barcodes, tax rates etc.. but I see that as part of a bigger piece to > migrate MANUAL_INC outside of authorized values. I mentioned it only just in case we could spot something on the code preventing such enhancement being a smooth addition.
Created attachment 93116 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93117 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93118 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93119 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93120 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93121 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93122 [details] [review] Bug 23354: (follow-up) Add till icon
Created attachment 93123 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93124 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93465 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93466 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93467 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93468 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93469 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93470 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93471 [details] [review] Bug 23354: (follow-up) Add till icon
Created attachment 93472 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93473 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93604 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93605 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93606 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93607 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93608 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93609 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93610 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93611 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 93612 [details] [review] Bug 23354: Add Icon for POS system
(In reply to Tomás Cohen Arazi from comment #28) > - We should really have a separate table and stop using MANUAL_INV. It feels > really dirty to have a note field contain a decimal value to be used as a > number. To start with. I think we agree on this, and there's even work from > Josef that would do it. Done, I've rebased all this work on top of bug 23049 and bug 23805 (which are now pushed) :) > - Are you planning on having an inventory of things to sell? I think the use > of authorised values is very limited, besides my criticism. I expect > librarians wanting to just scan the barcode and get the price on the screen. This is my intention still, but at a later stage.
Created attachment 94689 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94690 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94691 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94692 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94693 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94694 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94695 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94696 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 94697 [details] [review] Bug 23354: Add Icon for POS system
Created attachment 94698 [details] [review] Bug 23354: Update to account for bug 23049
Created attachment 94699 [details] [review] Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use.
Created attachment 95678 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95679 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95680 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95681 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95682 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95683 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95684 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95685 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services
Created attachment 95686 [details] [review] Bug 23354: Add Icon for POS system
Created attachment 95687 [details] [review] Bug 23354: Update to account for bug 23049
Created attachment 95688 [details] [review] Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use.
Created attachment 95689 [details] [review] Bug 23354: (follow-up) Ensure 'CASH' payment type is present
Created attachment 95690 [details] [review] Bug 23354: (follow-up) Update for bugs 23049 and 23805 Remove all mentions of accounttype and replace with debit_type_code and credit_type_code as appropriate.
Created attachment 95691 [details] [review] Bug 23354: (follow-up) Fix for sending code instead of description
Created attachment 95692 [details] [review] Bug 23354: Format price on item add
Created attachment 95693 [details] [review] Bug 23354: Prevent negatives from being entered
Created attachment 97013 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97014 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97015 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97016 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97017 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97018 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97019 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97020 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97021 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97022 [details] [review] Bug 23354: Add Icon for POS system Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97023 [details] [review] Bug 23354: Update to account for bug 23049 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97024 [details] [review] Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97025 [details] [review] Bug 23354: (follow-up) Ensure 'CASH' payment type is present Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97026 [details] [review] Bug 23354: (follow-up) Update for bugs 23049 and 23805 Remove all mentions of accounttype and replace with debit_type_code and credit_type_code as appropriate. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97027 [details] [review] Bug 23354: (follow-up) Fix for sending code instead of description Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97028 [details] [review] Bug 23354: Format price on item add Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97029 [details] [review] Bug 23354: Prevent negatives from being entered Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97169 [details] [review] Bug 23354: (QA follow-up) Mark boolean columns in schema
Created attachment 97170 [details] [review] Bug 23354: (QA follow-up) Add missing filters, remove tab chars
Comment on attachment 97019 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Review of attachment 97019 [details] [review]: ----------------------------------------------------------------- The file t/db_dependent/Koha/Charges/Sales.pm should be renamed to *.t ::: t/db_dependent/Koha/Charges/Sales.pm @@ +139,5 @@ > + > + my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); > + my $av = Koha::AuthorisedValue->new( > + { > + category => 'MANUAL_INV', Should be credit type object, not manual inv auth value
Hi Martin, looks good, I added to little follow-ups and spotted the problem in test (see my previous comment) I have only one concern about printing receipt: I would like to see ability to print receipt manually (maybe using modal which is implemented to confirm change return). With current patches it is possible to print receipt only if automatic printing is enabled. But it also enables automatic printing in patrons accounting. I do think that there should be possibility to print receipt from POS manually too.
Created attachment 97171 [details] POS Also I can see some visual glitches on POS page, see attachment
Thanks for taking a look and the followups Josef :) Annoyed at myself for missing the filters.. this patchset was initially created long enough ago that they were not required... I aught to have updated it though by now :( As for the display issues, did you run the yarn build step? (I may have forgotten to include it in the test plan :( ). Finally, the reciept printing.. I'm not sure I can print it from the change modal (that doesn't always display depending on whether you actually need to receive change or not and also the transaction hasn't yet taken place at that point so we don't have any data to refer to. I'll try to come up with an alternative though, as I agree it's not great having it only tied to the preference as it stands (You do however get the ability to print receipts in the next patch in the series which adds a 'cashup' page of historical transactions). Followups incoming as I fix the receipting UX.
Created attachment 97188 [details] [review] Bug 23354: (QA follow-up) Allow manual receipt printing This patch adds an alert message that allows receipt printing for transactions when FinePaymentAutoPopup is not enabled.
Created attachment 97189 [details] [review] Bug 23354: (QA follow-up) Rename test file Note to RM: Squash on push
Created attachment 97200 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97201 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97202 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97203 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97204 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97205 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97206 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97207 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97208 [details] [review] Bug 23354: Add Icon for POS system Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97209 [details] [review] Bug 23354: Update to account for bug 23049 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97210 [details] [review] Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97211 [details] [review] Bug 23354: (follow-up) Ensure 'CASH' payment type is present Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97212 [details] [review] Bug 23354: (follow-up) Update for bugs 23049 and 23805 Remove all mentions of accounttype and replace with debit_type_code and credit_type_code as appropriate. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97213 [details] [review] Bug 23354: (follow-up) Fix for sending code instead of description Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97214 [details] [review] Bug 23354: Format price on item add Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97215 [details] [review] Bug 23354: Prevent negatives from being entered Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 97216 [details] [review] Bug 23354: (QA follow-up) Mark boolean columns in schema
Created attachment 97217 [details] [review] Bug 23354: (QA follow-up) Add missing filters, remove tab chars
Created attachment 97218 [details] [review] Bug 23354: (QA follow-up) Allow manual receipt printing This patch adds an alert message that allows receipt printing for transactions when FinePaymentAutoPopup is not enabled.
Created attachment 97219 [details] [review] Bug 23354: (QA follow-up) Rename test file Note to RM: Squash on push
Ready for a second QA round now, hopefully, that's everything fixed. :) Remember to `yarn build` to get the display issues corrected. Thanks Josef :)
Created attachment 97271 [details] [review] Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97272 [details] [review] Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97273 [details] [review] Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97274 [details] [review] Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97275 [details] [review] Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97276 [details] [review] Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97277 [details] [review] Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97278 [details] [review] Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97279 [details] [review] Bug 23354: Add Icon for POS system Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97280 [details] [review] Bug 23354: Update to account for bug 23049 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97281 [details] [review] Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97282 [details] [review] Bug 23354: (follow-up) Ensure 'CASH' payment type is present Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97283 [details] [review] Bug 23354: (follow-up) Update for bugs 23049 and 23805 Remove all mentions of accounttype and replace with debit_type_code and credit_type_code as appropriate. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97284 [details] [review] Bug 23354: (follow-up) Fix for sending code instead of description Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97285 [details] [review] Bug 23354: Format price on item add Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97286 [details] [review] Bug 23354: Prevent negatives from being entered Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97287 [details] [review] Bug 23354: (QA follow-up) Mark boolean columns in schema Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97288 [details] [review] Bug 23354: (QA follow-up) Add missing filters, remove tab chars Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97289 [details] [review] Bug 23354: (QA follow-up) Allow manual receipt printing This patch adds an alert message that allows receipt printing for transactions when FinePaymentAutoPopup is not enabled. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97290 [details] [review] Bug 23354: (QA follow-up) Rename test file Note to RM: Squash on push Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97291 [details] [review] Bug 23354: (QA follow-up) Make db update idempotent Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 97292 [details] [review] Bug 23354: (QA follow-up) Fix spelling in templates Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
(In reply to Martin Renvoize from comment #131) > Ready for a second QA round now, hopefully, that's everything fixed. :) > > Remember to `yarn build` to get the display issues corrected. > > Thanks Josef :) I thought I did run 'yarn build', but maybe not... Anyway I just added two more small follow-ups and passed QA, great job!
Nice work everyone! Pushed to master for 20.05
Notice templates are missing in .sql files xt/sample_notices.t .. 1/? # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in fr-FR/1-Obligatoire/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in fr-CA/obligatoire/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in de-DE/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in es-ES/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in it-IT/necessari/notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in nb-NO/1-Obligatorisk/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in pl-PL/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in ru-RU/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in uk-UA/mandatory/sample_notices.sql: RECEIPT # Looks like you failed 9 tests of 38.
account_debit_types.can_be_added_manually - `can_be_added_manually` tinyint(4) NOT NULL DEFAULT 1, Is that expected? Test is failing because of that: t/db_dependent/Koha/Account/DebitType.t .. DBIx::Class::Row::store_column(): No such column 'can_be_added_manually' on Koha::Schema::Result::AccountDebitType at /kohadevbox/koha/Koha/Object.pm line 77
The column account_debit_types.can_be_added_manually has been removed: - `can_be_added_manually` tinyint(4) NOT NULL DEFAULT 1, Is that expected? Test is failing because of that: t/db_dependent/Koha/Account/DebitType.t .. DBIx::Class::Row::store_column(): No such column 'can_be_added_manually' on Koha::Schema::Result::AccountDebitType at /kohadevbox/koha/Koha/Object.pm line 77
Two followups pushed
Not backported to 19.11.x
my $q = CGI->new(); We already have $input and $cgi :)
(In reply to Jonathan Druart from comment #161) > my $q = CGI->new(); > > We already have $input and $cgi :) Fixed in RM followup.
Created attachment 97725 [details] [review] Bug 23354: (QA follow-up) Add takepayment permission for new installs
Created attachment 97726 [details] [review] Bug 23354: (RM follow-up) Change $q to $input for consistency As pointed out by Jonathan, this script introduced a third form for the CGI variable. This patch updates the script to use the more common $input variable name. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 100167 [details] [review] Bug 23354: (RM follow-up) Correction for cash register selection The form element for selectin cash register override at point of sale was misnamed and as such one could not actually override the cash register. This patch corrects the form element name and updates the logic very slighlty to ensure we still fall back to the defualt no the subsequent page load. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>