To test: - enable cash registers and point of sale - create a purchase item with a cost of $1000 - go to Point of Sale and attempt to sell one of your item - Note that Koha inserts a comma into the price and breaks its own math in calculating the amount due
Nice catch, I never tested with such a large figure I must admit. I'll start digging into it asap. Thanks for testing this feature so thoroughly Andrew, it's great to be catching these things before live release.
Created attachment 97983 [details] [review] Bug 24482: Fix for formatted price issue with value over 1000
Test plan, see first comment of bug. ;)
Created attachment 98058 [details] [review] Bug 24482: Fix for formatted price issue with value over 1000 This patch for the point of sale feature fixes an issue where items for purchase with a value of $1,000 or more break the payment calculations. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Create a purchase item with a cost of $1000 (Home > Point of sale > Purchase items > New debit type) 4) Go to to the point of sale page and attempt to sell one of your items (Home > Point of sale > click 'Add' next to the item to purchase) 5) Note that Koha inserts a comma into the price in the list of items for purchase 6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which affects the other calculations 7) Apply the patch 8) Repeat step 4 9) Amount being paid and other calculations should now be correct 10) Enter an amount for 'Collected from patron' and click 'Confirm' - check that the change calculation is correct 11) Sign-off the patch! Signed-off-by: David Nind <david@davidnind.com>
I identified two other possible issues testing this bug: 1. If you press enter in the 'Collected from patron' field it adds the first item listed under the 'Items for purchase' section to 'This sale'. 2. If the amount you enter in 'Collected from patron' is less than the total amount owed and you press confirm it is accepted. For a cash payment maybe there should be a warning or error, or not let the transaction be accepted or completed.
Created attachment 98107 [details] [review] Bug 24482: Fix for formatted price issue with value over 1000 This patch for the point of sale feature fixes an issue where items for purchase with a value of $1,000 or more break the payment calculations. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Create a purchase item with a cost of $1000 (Home > Point of sale > Purchase items > New debit type) 4) Go to to the point of sale page and attempt to sell one of your items (Home > Point of sale > click 'Add' next to the item to purchase) 5) Note that Koha inserts a comma into the price in the list of items for purchase 6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which affects the other calculations 7) Apply the patch 8) Repeat step 4 9) Amount being paid and other calculations should now be correct 10) Enter an amount for 'Collected from patron' and click 'Confirm' check that the change calculation is correct. 11) Sign-off the patch! Signed-off-by: David Nind <david@davidnind.com>
Thanks for testing, and that's a wonderfully detailed test plan, thankyou!
(In reply to David Nind from comment #5) > I identified two other possible issues testing this bug: > > 1. If you press enter in the 'Collected from patron' field it adds the first > item listed under the 'Items for purchase' section to 'This sale'. Oh, weird.. I'll open a new bug for that. > > 2. If the amount you enter in 'Collected from patron' is less than the total > amount owed and you press confirm it is accepted. For a cash payment maybe > there should be a warning or error, or not let the transaction be accepted > or completed. I'll be submitting a fix for this one in bug 24519 ;)
Bug 24540 opened for the weird enter behaviour.
Created attachment 98582 [details] [review] Bug 24482: Fix for formatted price issue with value over 1000 This patch for the point of sale feature fixes an issue where items for purchase with a value of $1,000 or more break the payment calculations. Test plan: 1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters system preferences) 2) Add a cash register for a library (Home > Point of sale > Cash registers > New cash register) 3) Create a purchase item with a cost of $1000 (Home > Point of sale > Purchase items > New debit type) 4) Go to to the point of sale page and attempt to sell one of your items (Home > Point of sale > click 'Add' next to the item to purchase) 5) Note that Koha inserts a comma into the price in the list of items for purchase 6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which affects the other calculations 7) Apply the patch 8) Repeat step 4 9) Amount being paid and other calculations should now be correct 10) Enter an amount for 'Collected from patron' and click 'Confirm' check that the change calculation is correct. 11) Sign-off the patch! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to master for 20.05
not pushed to 19.11.x due to dependencies