Bug 16232 add a "duplicate" backend without label. This make the backend appears as undefined in save backend list. Also, with bug 18823 applied, this undefined backend prevent editor to be loaded.
Created attachment 92038 [details] [review] Bug 23436: add a label for duplicate backend Reproduce issue: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor - Click on the down arrow in "Save to catalog" menu - You should see an undefined named save backend Test patch: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor to save preference to the cookie - Click on the down arrow in "Save to catalog" menu - You should see a "Duplicate" named backend Test Bug 16232 for no regression: - Search for a biblio in catalog - Click in "Edit record" - Advanced editor should appear. SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" - Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" More test: - Search for a biblio in catalog - Click on "Edit record" - Advanced editor should appear - Click on the down arrow in "Save to catalog" menu and click on Duplicate, - Record should be saved as a new one (same behavior)
Created attachment 92046 [details] [review] Bug 23436: add a label for duplicate backend Reproduce issue: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor - Click on the down arrow in "Save to catalog" menu - You should see an undefined named save backend Test patch: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor to save preference to the cookie - Click on the down arrow in "Save to catalog" menu - You should see a "Duplicate" named backend Test Bug 16232 for no regression: - Search for a biblio in catalog - Click on edit => Edit as new (duplicate) - Advanced editor should appear. SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" - Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" More test: - Search for a biblio in catalog - Click on "Edit record" - Advanced editor should appear - Click on the down arrow in "Save to catalog" menu and click on Duplicate, - Record should be saved as a new one (same behavior)
Created attachment 92047 [details] [review] Bug 23436: add a label for duplicate backend Reproduce issue: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor - Click on the down arrow in "Save to catalog" menu - You should see an undefined named save backend Test patch: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor to save preference to the cookie - Click on the down arrow in "Save to catalog" menu - You should see a "Duplicate" named backend Test Bug 16232 for no regression: - Search for a biblio in catalog - Click in "Edit record" - Advanced editor should appear. SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" - Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" More test: - Search for a biblio in catalog - Click on "Edit record" - Advanced editor should appear - Click on the down arrow in "Save to catalog" menu and click on Duplicate, - Record should be saved as a new one (same behavior) Signed-off-by: cori <corilynn.arnold@gmail.com>
works great!
Created attachment 92106 [details] [review] Bug 23436: add a label for duplicate backend Reproduce issue: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor - Click on the down arrow in "Save to catalog" menu - You should see an undefined named save backend Test patch: - Enable "EnableAdvancedCatalogingEditor" preference - Go to cataloguing and click on advanced editor to save preference to the cookie - Click on the down arrow in "Save to catalog" menu - You should see a "Duplicate" named backend Test Bug 16232 for no regression: - Search for a biblio in catalog - Click in "Edit record" - Advanced editor should appear. SUCCESS => browser url ends with #duplicate/{original biblionumber} => Title above toolbar is "Editing duplicate record of #{original biblionumber}" - Save SUCCESS => browser url ends with #catalog/{new biblionumber} => Title above toolbar is "Editing catalog record #{new biblionumber}" More test: - Search for a biblio in catalog - Click on "Edit record" - Advanced editor should appear - Click on the down arrow in "Save to catalog" menu and click on Duplicate, - Record should be saved as a new one (same behavior) Signed-off-by: cori <corilynn.arnold@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I've filed a new bug for not showing the "Duplicate" option when working on a new record: bug 23440
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.04
backported to 18.11.x for 18.11.10