Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change.
Created attachment 92477 [details] [review] Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment
Created attachment 92483 [details] [review] Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com>
Created attachment 92484 [details] [review] Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org>
Created attachment 92673 [details] [review] Bug 23507: Add ability to show change given on auto-popup fee reciept from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org>
Created attachment 93830 [details] [review] Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup Some libraries would like to show the amount of change given on print reciepts triggered by FinePaymentAutoPopup so the patron can verify he or she has recieved the correct amount of change. 1) Apply this patch 2) Edit ACCOUNT_CREDIT slip and add "[% IF change_given %]<h1>CHANGE: [% change_given %]</h1>[% END %]" at the top 3) Enable FinePaymentAutoPopup 4) Make a payment 5) Note the change given is shown on the popup receipt 6) Note the change given is *not* shown on subsequent prints of the same receipt using the "print" button for the payment Signed-off-by: Kyle Hall <kyle@bywatersolutions.com> Signed-off-by: Hasina Akhte <hasinaa@pascolibraries.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I am wondering if we should not always print the change given on the receipt instead of just the first time. Having it added to the template and only printing sometimes could turn out confusing (or be the next bug report :) )
(In reply to Katrin Fischer from comment #6) > I am wondering if we should not always print the change given on the receipt > instead of just the first time. Having it added to the template and only > printing sometimes could turn out confusing (or be the next bug report :) ) We don't store that information Katrin, so we can't print it after the initial transaction at the moment.
Nice work! Pushed to master for 19.11.00
(In reply to Martin Renvoize from comment #7) > (In reply to Katrin Fischer from comment #6) > > I am wondering if we should not always print the change given on the receipt > > instead of just the first time. Having it added to the template and only > > printing sometimes could turn out confusing (or be the next bug report :) ) > > We don't store that information Katrin, so we can't print it after the > initial transaction at the moment. Can't argue that point!
$redirect .= '&remote_user='; + $redirect .= "change_given=$change_given"; Looks like there is a "&" missing before change_given.