- To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) - Experience error on saving the writeoff http://localhost:8081/cgi-bin/koha/members/printfeercpt.pl?action=print&accountlines_id=HASH(0x558152468290)&borrowernumber=51 Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 This problem was first found in 20.05.03 so affects stable releases as well!
Caused by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test Which modified the return value of Koha::Account->pay
Created attachment 112974 [details] [review] Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed
Created attachment 112978 [details] [review] Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind <david@davidnind.com>
Created attachment 113095 [details] [review] Bug 26915: Fix FinePaymentAutoPopup behaviour The behaviour of the syspref FinePaymentAutoPopup is broken, the popup explodes with Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 It has been broken by commit a2449a81be55aa5b3710ca2c6df7884513f89540 Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test which modified the return value of Koha::Account->pay (from $payment_id to a hashref) Test plan: - To test activate FinePaymentAutoPopup - Create a manual fee - Write it off using the write off button on the account line (not below table) => Without the patch you get the error => With the patch applied the popup is correctly displayed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
You beat me to this one Jonathan, thanks! :). I've grepped around to see if there are any other cases and can't spot any. Fix works as expected, no regressions. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.06
missing dependencies, not backported to 19.11.x