The jQuery plugin we use for setting cookies is obsolete: https://github.com/carhartl/jquery-cookie -- "No longer maintained, superseded by JS Cookie: https://github.com/js-cookie/js-cookie"
Created attachment 94951 [details] [review] Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page.
Created attachment 94953 [details] [review] Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically.
Created attachment 96826 [details] [review] Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page.
Created attachment 96827 [details] [review] Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically.
Created attachment 97937 [details] [review] Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 97938 [details] [review] Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. Signed-off-by: David Nind <david@davidnind.com>
I had to delete my old issues-table-load-immediately-circulation cookies first to get this to work, but now it does :)
Created attachment 98050 [details] [review] Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 98051 [details] [review] Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for <patron>" and "Forget <patron>" options. Test that these work correctly. - In the table of search results each title should include a "Place hold for <patron>" link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x branch for 19.11.03
choosing to backport this enhancement into 19.05.x for 19.05.08
Enhancement will not be backported to 18.11.x.