In acquisitions, the receipt summary page uses cookies to remember the settings in the sidebar filter. This process should use the newer cookie library, js-cookie.
Although the plugin is included in the template (acquit/parcel.tt) it isn't used.
Created attachment 117011 [details] [review] Bug 24624: Remove unused jquery.cookie.js plugin This patch removes inclusion of the jquery.cookie.js plugin from the "Receive orders" page in Acquisitions. It is unused. To test apply the patch and follow the process for receiving an order in Acquisitions: - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment - The table of pending orders should display correctly, and there should be no JavaScript errors in the browser console.
Created attachment 117105 [details] [review] Bug 24624: Remove unused jquery.cookie.js plugin This patch removes inclusion of the jquery.cookie.js plugin from the "Receive orders" page in Acquisitions. It is unused. To test apply the patch and follow the process for receiving an order in Acquisitions: - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment - The table of pending orders should display correctly, and there should be no JavaScript errors in the browser console. Signed-off-by: David Nind <david@davidnind.com>
Testing notes: - Everything continues to work and display as expected. - lib/jquery/plugins/jquery.cookie.min.js is no longer in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt - No JavaScript errors in the console. - lib/jquery/plugins/jquery.cookie.min.js still appears in the page source, assume that is because it appears in other source files: git grep lib/jquery/plugins/jquery.cookie.min.js koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
Created attachment 117421 [details] [review] Bug 24624: Remove unused jquery.cookie.js plugin This patch removes inclusion of the jquery.cookie.js plugin from the "Receive orders" page in Acquisitions. It is unused. To test apply the patch and follow the process for receiving an order in Acquisitions: - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment - The table of pending orders should display correctly, and there should be no JavaScript errors in the browser console. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x