The printing is broken on opac-results.pl page to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287
Created attachment 100716 [details] pic2
Created attachment 100717 [details] pic1
Created attachment 100718 [details] [review] The printing is broken on opac-results.pl page to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287
Created attachment 100719 [details] [review] Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287
Mason, I cannot clean apply this to the 19.11.x branch: .git/rebase-apply/patch:32: trailing whitespace. @page { margin: 1cm } warning: 1 line adds whitespace errors.
(In reply to Lucas Gass from comment #5) > Mason, > > I cannot clean apply this to the 19.11.x branch: > > .git/rebase-apply/patch:32: trailing whitespace. > @page { margin: 1cm } > warning: 1 line adds whitespace errors. aah, good catch Lucas, i'll correct the patch :)
Created attachment 100836 [details] [review] Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287
Created attachment 100838 [details] [review] Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/print.css You should not modify print.css but css/src/print.scss instead.
(In reply to Jonathan Druart from comment #9) > CONFLICT (content): Merge conflict in > koha-tmpl/opac-tmpl/bootstrap/css/print.css > > You should not modify print.css but css/src/print.scss instead. ah yes.. ill fix that
Created attachment 100995 [details] [review] Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287
Created attachment 101063 [details] [review] Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
I signed off and this looks good but it should be noted that testers must run: yarn build --view opac to regenerate the CSS
Upon further looking, it appears that this problem is in master too, not just 19.11.x
I tested with Firefox in Ubuntu and can't replicate the issue. What I see is good alignment of the text on the left without the patch and a bit too much whitespace with the patch. I think we might want to investigate more to nail down when the problem appears and maybe browser differences? Sending back to sign off for additional testing.
Created attachment 101395 [details] ubuntu 19.10
Created attachment 101396 [details] ubuntu 19.10 (2)
(In reply to Katrin Fischer from comment #15) > I tested with Firefox in Ubuntu and can't replicate the issue. What I see is > good alignment of the text on the left without the patch and a bit too much > whitespace with the patch. > I think we might want to investigate more to nail down when the problem > appears and maybe browser differences? > Sending back to sign off for additional testing. hi Cait heres an pic of the problem on ubuntu 19.10, with firefox 69.0.3
Could the custom CSS be interfering?
Created attachment 101470 [details] Before (master)
Created attachment 101471 [details] After (master)
Without patch: If I set IDreamBooksReadometer, IDreamBooksResults, IDreamBooksReviews to ADD: all looks well. If I set them to DON'T ADD: My printed results look bad.
Created attachment 101477 [details] [review] Bug 24874: Printing is broken on opac-results.pl page (19.11.x) to test in 19.11.x... - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I'm adding my signoff because I can reproduce the problem in both 19.11.x and master in both Firefox and Chrome (OSX), and the patch fixes it.
Created attachment 101496 [details] [review] Bug 24874: Printing is broken on opac-results.pl page to test: - search for something in opac - print page using file -> print - observe printing is broken (pic1) - apply patch - search for something in opac - print page using file -> print - observe printing is fixed (pic2) it seems this issue was introduced by bug 5287 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.05
backported to 19.05.x for 19.05.10
(In reply to Lucas Gass from comment #28) > backported to 19.05.x for 19.05.10 this has been resolved now