When printing the details.tt page on the staff client there is a large amount of white space on the left side. Looking at print.css, we hide #menu but it (or something else) still looks to be taking up space on the left. TO RECREATE: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left
Created attachment 103037 [details] [review] Bug 25072: Fix details.tt print CSS TO TEST: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -Apply patch -Reload detaials page and attempt to print again. -No whitespace on left side
Hi Lucas (In reply to Lucas Gass from comment #0) > -Notice the large amount of whitespace on the left Can't reproduce, could you add a screenshot of what you see?
Bernardo, Here is what I am talking about: https://snipboard.io/7OWAej.jpg
(In reply to Lucas Gass from comment #3) > Here is what I am talking about: > > https://snipboard.io/7OWAej.jpg Lucas, I see, but this is what I see https://snipboard.io/Jca7w1.jpg (Opera, current master, Print option from details page) No space on the left for me.
Seems to be a Firefox problem, or at least I can see your problem using Firefox
Created attachment 103896 [details] [review] Bug 25072: Fix details.tt print CSS TO TEST: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -Apply patch -Reload detaials page and attempt to print again. -No whitespace on left side Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improves output using Firefox browser, no errors
Created attachment 103905 [details] [review] Bug 25072: Fix details.tt print CSS TO TEST: -Search for something in the catalog and go to the details page. -Try to print either for the Print button in Koha or File->Print... -Notice the large amount of whitespace on the left -Apply patch -Reload detaials page and attempt to print again. -No whitespace on left side Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Improves output using Firefox browser, no errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11