Bug 13937 introduced new log4perl.conf changes, but missed to tweak the packages' log4perl.conf.in template.
Created attachment 101017 [details] [review] Bug 24905: Add missing entry in log4perl-site.conf.in Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 101018 [details] [review] Bug 24905: Make installer update log4perl.conf for instances This patch makes koha-common.postinst check if the log4perl.conf files on the instances need tweaking. If they do, it appends the relevant configuration text. To test: 1. Install Koha 19.11 or earlier using the packages 2. Create an instance: $ koha-create --create-db test1 $ koha-create --create-db test2 => FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for z39.50 3. Apply this patch and run: $ docker run \ --volume=/path/to/your/clone:/koha \ --volume=/dest/path/for/debs:/debs \ --privileged --env VERSION=19.12.00.047 \ koha/koha-dpkg:master Note: Paths need to be adjusted 4. Grab the .deb files and put them on the machine you're testing this 5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text at the bottom: log4perl.logger.z3950 6. Install the debs: $ sudo dpkg -i koha-perldeps koha-deps koha-common => SUCCESS: Install process doesn't explode due to the addition => SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for log4perl.logger.z3950 => SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for log4perl.logger.z3950 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 101020 [details] [review] Bug 24905: Make installer update log4perl.conf for instances This patch makes koha-common.postinst check if the log4perl.conf files on the instances need tweaking. If they do, it appends the relevant configuration text. To test: 1. Install Koha 19.11 or earlier using the packages 2. Create an instance: $ koha-create --create-db test1 $ koha-create --create-db test2 => FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for z39.50 3. Apply this patch and run: $ docker run \ --volume=/path/to/your/clone:/koha \ --volume=/dest/path/for/debs:/debs \ --privileged --env VERSION=19.12.00.047 \ koha/koha-dpkg:master Note: Paths need to be adjusted 4. Grab the .deb files and put them on the machine you're testing this 5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text at the bottom: log4perl.logger.z3950 6. Install the debs: $ sudo dpkg -i koha-perldeps koha-deps koha-common => SUCCESS: Install process doesn't explode due to the addition => SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for log4perl.logger.z3950 => SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for log4perl.logger.z3950 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 101893 [details] [review] Bug 24905: Add missing entry in log4perl-site.conf.in Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 101894 [details] [review] Bug 24905: Make installer update log4perl.conf for instances This patch makes koha-common.postinst check if the log4perl.conf files on the instances need tweaking. If they do, it appends the relevant configuration text. To test: 1. Install Koha 19.11 or earlier using the packages 2. Create an instance: $ koha-create --create-db test1 $ koha-create --create-db test2 => FAIL: /etc/koha/sites/test1/log4perl.conf doesn't include an entry for z39.50 3. Apply this patch and run: $ docker run \ --volume=/path/to/your/clone:/koha \ --volume=/dest/path/for/debs:/debs \ --privileged --env VERSION=19.12.00.047 \ koha/koha-dpkg:master Note: Paths need to be adjusted 4. Grab the .deb files and put them on the machine you're testing this 5. Edit /etc/koha/sites/test2/log4perl.conf and add the following text at the bottom: log4perl.logger.z3950 6. Install the debs: $ sudo dpkg -i koha-perldeps koha-deps koha-common => SUCCESS: Install process doesn't explode due to the addition => SUCCESS: /etc/koha/sites/test1/log4perl.conf has a new entry for log4perl.logger.z3950 => SUCCESS: /etc/koha/sites/test2/log4perl.conf doesn't have a new entry for log4perl.logger.z3950 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works well in testing.. clear code.. going for a straight QA on this one.
Nice work everyone! Pushed to master for 20.05
Joy, if you would pick this one for 19.11.x, please wait until bug 24905 can be pushed along with this one. Together, not separate :-D
Joy, if you would pick this one for 19.11.x, please wait until bug 18227 can be pushed along with this one. Together, not separate :-D
backported to 19.11.x for 19.11.05
missing dependencies for 19.05.x, no backport
I think that there's actually a typo in this that is causing minor errors. Going to investigate more fully...
(In reply to Martin Renvoize from comment #6) > Works well in testing.. clear code.. going for a straight QA on this one. I'm so intrigued by this because I don't see how that code in debian/koha-common.postinst could have ever worked correctly :S.