Bug 24905 created a way to automatically append config to /etc/koha/sites/$site/log4perl.conf However, the "grep" isn't correct, so the config gets appended whether or not the logger already exists in the log4perl.conf file.
Created attachment 105006 [details] [review] Bug 25524: Remove --line-regexp option in log4perl_component() The current grep expression uses -x|--line-regexp, but that causes the regexp to fail to match since we're not specifying a regexp that can match a whole line. We can either provide a better regexp, or remove that --line-regexp option. This patch removes the --line-regexp (ie -x) option from the grep in log4perl_component, so that it detects logger components correctly. To Test: 0) Apply patch 1) Build Koha package 2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing Koha instance (e.g. on koha-testing-docker), and note it has components for z3950, api, and sip 3) Install package 4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before 5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from /etc/koha/sites/kohadev/log4perl.conf 6) Reinstall package 7) Note that the missing lines have been appended to the file at /etc/koha/sites/kohadev/log4perl.conf
Actually, this might only be an issue, if/when Bug 25510 is fixed.
Good catch! 19.11 mantainer: this should be pushed at the same time we push 25510.
Created attachment 105123 [details] [review] Bug 25524: Remove --line-regexp option in log4perl_component() The current grep expression uses -x|--line-regexp, but that causes the regexp to fail to match since we're not specifying a regexp that can match a whole line. We can either provide a better regexp, or remove that --line-regexp option. This patch removes the --line-regexp (ie -x) option from the grep in log4perl_component, so that it detects logger components correctly. To Test: 0) Apply patch 1) Build Koha package 2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing Koha instance (e.g. on koha-testing-docker), and note it has components for z3950, api, and sip 3) Install package 4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before 5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from /etc/koha/sites/kohadev/log4perl.conf 6) Reinstall package 7) Note that the missing lines have been appended to the file at /etc/koha/sites/kohadev/log4perl.conf Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 105125 [details] [review] Bug 25524: Remove --line-regexp option in log4perl_component() The current grep expression uses -x|--line-regexp, but that causes the regexp to fail to match since we're not specifying a regexp that can match a whole line. We can either provide a better regexp, or remove that --line-regexp option. This patch removes the --line-regexp (ie -x) option from the grep in log4perl_component, so that it detects logger components correctly. To Test: 0) Apply patch 1) Build Koha package 2) Look at /etc/koha/sites/kohadev/log4perl.conf in an existing Koha instance (e.g. on koha-testing-docker), and note it has components for z3950, api, and sip 3) Install package 4) Note that /etc/koha/sites/kohadev/log4perl.conf is the same as before 5) Remove the "log4perl.logger.sip and log4perl.appender.SIP lines from /etc/koha/sites/kohadev/log4perl.conf 6) Reinstall package 7) Note that the missing lines have been appended to the file at /etc/koha/sites/kohadev/log4perl.conf Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.06
(In reply to Joy Nelson from comment #7) > backported to 19.11.x for 19.11.06 \o/
Missing dependencies for 19.05.x, can't backport.