When paying a single fine, the description and account type are not displaying correctly on paycollect.tt in all cases. In my case it didn't work for RENT_RENEW with a description including the title of the the record. While it displays nicely in the list of charges, when paying it individually using the pay button in the line, the account type displays the code instead of the description and the description remains empty.
Ok, correction: It's not the whole description missing, it's the title part shown in () in the other table.
Created attachment 102790 [details] [review] Bug 25119: Fix account type and description for individual writeoffs/payments When paying or writing off a single line from the list of pending charges, the account type displayed the code instead of the description. And when bug 23483 fixed the display of the description, 2 variables where missed. This change is only visible when looking at the page source: <input type="hidden" name="description" id="description" value="" /> With the patch applied, the value will be filled with the description. To test: - Create one or more manual invoices of different types - Try to pay/write off using the buttons within the table - Verify the account type shows as code, not description - Apply patch - Repeat - Bonus points: Check the source code for the hidden input with description.
Created attachment 102933 [details] [review] Bug 25119: Fix account type and description for individual writeoffs/payments When paying or writing off a single line from the list of pending charges, the account type displayed the code instead of the description. And when bug 23483 fixed the display of the description, 2 variables where missed. This change is only visible when looking at the page source: <input type="hidden" name="description" id="description" value="" /> With the patch applied, the value will be filled with the description. To test: - Create one or more manual invoices of different types - Try to pay/write off using the buttons within the table - Verify the account type shows as code, not description - Apply patch - Repeat - Bonus points: Check the source code for the hidden input with description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Well spotted, thanks for the fix Katrin.. works as expected.. Signing off
Thx Martin! I am puzzled by the 'title' variable in this bit of code still - couldn't get that to work (display like on the summary, behind the description in () ). But that's for another day (and bug).
Created attachment 104075 [details] [review] Bug 25119: Fix account type and description for individual writeoffs/payments When paying or writing off a single line from the list of pending charges, the account type displayed the code instead of the description. And when bug 23483 fixed the display of the description, 2 variables where missed. This change is only visible when looking at the page source: <input type="hidden" name="description" id="description" value="" /> With the patch applied, the value will be filled with the description. To test: - Create one or more manual invoices of different types - Try to pay/write off using the buttons within the table - Verify the account type shows as code, not description - Apply patch - Repeat - Bonus points: Check the source code for the hidden input with description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Nice work everyone! Pushed to master for 20.05
does not apply cleanly to 19.11.x branch. please rebase if needed in 19.11