The authority version of bug 25231 From the details page for an authority record, we just have a menuitem that says "Replace record via Z39.50/SRU" without any followup modal alert, but if you edit the authority (which you do, of course, because the details page choice doesn't fill in a search term like the edit page does) then clicking the button brings up a modal alert to tell you what you already knew you were doing. Just changing the button label from "search" to "replace" depending on whether you are creating a new record or editing an existing one will be smoother.
Created attachment 103439 [details] [review] Bug 25235: Rename the button instead of alerting when replacing an existing record Test plan: Pre-patch 1 - Go to the main Authorities page, search for any authority, click the Actions menubutton and choose Edit 2 - Note the button saying Z39.50 search 3 - Note the modal alert forcing you to click it 4 - Cancel and cancel again, and in the New authority menubutton choose Default 5 - Click the button saying Z39.50 search again, note that it warns you about replacing your totally blank record Apply this patch 6 - Edit an existing authority, note the button says "Replace record via Z39.50/SRU search" 2 - Click the button, verify it still opens the search window with the main entry of the record filled in without an alert 3 - Create a new authority, note the button says "Z39.50/SRU search" 4 - Click the button, verify it still opens the search window but without an alert
Created attachment 103472 [details] [review] Bug 25235: Rename the button instead of alerting when replacing an existing record Test plan: Pre-patch 1 - Go to the main Authorities page, search for any authority, click the Actions menubutton and choose Edit 2 - Note the button saying Z39.50 search 3 - Note the modal alert forcing you to click it 4 - Cancel and cancel again, and in the New authority menubutton choose Default 5 - Click the button saying Z39.50 search again, note that it warns you about replacing your totally blank record Apply this patch 6 - Edit an existing authority, note the button says "Replace record via Z39.50/SRU search" 2 - Click the button, verify it still opens the search window with the main entry of the record filled in without an alert 3 - Create a new authority, note the button says "Z39.50/SRU search" 4 - Click the button, verify it still opens the search window but without an alert Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 103473 [details] [review] Bug 25235: (follow-up) Shorten label and apply to addbiblio too This follow-up changes the new label from "Replace record via Z39.50/SRU search" to the more button-friendly "Replace via Z39.50/SRU" This patch also applies the same change to the basic MARC editor interface. To test, apply the patch and follow the previous test plan to confirm the change on the authorities page. Go to Cataloging and edit an existing record in the basic MARC editor. You should see the "Replace via Z39.50/SRU" button, and clicking it should trigger the Z39.50 search window without asking for confirmation. Create a new record in the basic MARC editor. The button should be labeled "Z39.50/SRU" search, and it should trigger the popup window without asking for confirmation.
Created attachment 103476 [details] [review] Bug 25235: Rename the button instead of alerting when replacing an existing record Test plan: Pre-patch 1 - Go to the main Authorities page, search for any authority, click the Actions menubutton and choose Edit 2 - Note the button saying Z39.50 search 3 - Note the modal alert forcing you to click it 4 - Cancel and cancel again, and in the New authority menubutton choose Default 5 - Click the button saying Z39.50 search again, note that it warns you about replacing your totally blank record Apply this patch 6 - Edit an existing authority, note the button says "Replace record via Z39.50/SRU search" 2 - Click the button, verify it still opens the search window with the main entry of the record filled in without an alert 3 - Create a new authority, note the button says "Z39.50/SRU search" 4 - Click the button, verify it still opens the search window but without an alert Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.06
enhancement will not be backported to 19.05.x