In MARC21slim2OPACResults.xsl we set the 'Format' or physical description by a combination of the 007 first position and 007 second position. In most cases this displays some text (example: chip cartridge or magneto-optical disc) But some set an png icon instead of any text. Like: <img src="/opac-tmpl/lib/famfamfam/world.png" alt="earth moon globe" class="format"/> These will not display at all that is because of this: <xsl:if test="string-length(normalize-space($physicalDescription))"> <span class="results_format"> <span class="label">; Format: </span><xsl:copy-of select="$physicalDescription"></xsl:copy-of> </span> </xsl:if> Without any text the string length is 0 and nothing at all displays. We need to add text along with each png icon.
To Recreate: 1. Edit a record to have the first and second postions in the 008 = 'cb'. 2. Load the OPAC results page and this record should display: Format: chip cartridge 3. Now try first and second positions in the 008 = 'co' 4. This should an optical disc png (/opac-tmpl/lib/famfamfam/cd.png) but nothing displays because the string length is 0.
Created attachment 103607 [details] [review] Bug 25269: Add text along with icons for physical descriptions 1. Edit a record to have the first and second postions in the 008 = 'cb'. 2. Load the OPAC results page and this record should display: Format: chip cartridge 3. Now try first and second positions in the 008 = 'co' 4. This should an optical disc png (/opac-tmpl/lib/famfamfam/cd.png) but nothing displays because the string length is 0. 5. Apply patch 6. Record with first and second positions in the 008 = 'co' should now should text and icon. 7. Look at patch and make sure other changed parts also work.
There are some inconsistencies between the OPAC and staff XSLT in this area. I have opened bug 25270.
The material type "Music" has a number of different formats. When a search for a certain item returns results for different formats for the same item (e.g., Gershwin recording of "Swanee") the list could contain a sound disc, roll, and a cassette. It is helpful to be able to tell right away from the results list which formats are available.
> 1. Edit a record to have the first and second postions in the 008 = 'cb'. You mean 007 right?
Created attachment 105092 [details] screenshot showing the optical disc when it shouldn't happen on step 4 of test plan No issues until this step: > 4. This should an optical disc png (/opac-tmpl/lib/famfamfam/cd.png) but nothing displays because the string length is 0. As the attached screenshot shows, the optical disc image is already there!
Hi Victor, looking at the patch, I think this is about displaying the description text, not about the icons. I am setting to to FQA as I think we should fix the commit message.
007 vs. 008
I think this can be marked as invalid.