Bug 6427 - Rewrite of the accounts system
Summary: Rewrite of the accounts system
Status: RESOLVED DUPLICATE of bug 14825
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Kyle M Hall (khall)
QA Contact: Bugs List
URL:
Keywords:
: 10057 (view as bug list)
Depends on: 13790 14027
Blocks: 11887 10021
  Show dependency treegraph
 
Reported: 2011-05-30 04:52 UTC by Robin Sheat
Modified: 2019-02-14 13:20 UTC (History)
25 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Large patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 6427 - Rewrite of the accounts system - WIP (28.46 KB, patch)
2013-10-09 14:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Update Schema Files (329.04 KB, patch)
2013-11-04 13:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (119.10 KB, patch)
2013-11-04 13:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (125.99 KB, patch)
2013-11-04 14:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Update Schema Files (329.04 KB, patch)
2013-11-04 14:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (125.99 KB, patch)
2013-11-04 14:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (167.83 KB, patch)
2013-11-05 20:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Update Schema Files (329.04 KB, patch)
2013-11-12 13:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (167.92 KB, patch)
2013-11-12 13:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (167.64 KB, patch)
2013-11-12 13:21 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (173.55 KB, patch)
2013-11-12 13:29 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (173.66 KB, patch)
2013-11-12 13:37 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (174.31 KB, patch)
2013-11-12 13:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (174.31 KB, patch)
2013-11-12 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (177.86 KB, patch)
2013-11-12 14:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (181.62 KB, patch)
2013-11-12 20:50 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (191.17 KB, patch)
2013-11-14 16:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (199.41 KB, patch)
2013-11-14 20:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (199.37 KB, patch)
2013-11-14 20:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (240.78 KB, patch)
2013-11-18 14:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (241.05 KB, patch)
2013-11-18 15:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (336.65 KB, patch)
2013-11-25 14:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (338.32 KB, patch)
2013-11-26 13:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (345.75 KB, patch)
2013-11-26 16:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (364.44 KB, patch)
2013-11-26 17:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system - WIP (370.53 KB, patch)
2013-11-27 14:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system (372.77 KB, patch)
2013-12-03 15:06 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system (375.11 KB, patch)
2013-12-03 17:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system (375.16 KB, patch)
2013-12-03 17:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system (376.23 KB, patch)
2013-12-11 14:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Rewrite of the accounts system (376.23 KB, patch)
2013-12-11 14:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (22.64 KB, patch)
2013-12-11 16:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.14 KB, patch)
2013-12-11 16:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2013-12-11 16:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.07 KB, patch)
2013-12-11 16:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2013-12-11 16:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.81 KB, patch)
2013-12-11 16:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2013-12-11 16:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.04 KB, patch)
2013-12-11 16:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.12 KB, patch)
2013-12-11 16:20 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2013-12-11 16:20 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.60 KB, patch)
2013-12-11 16:20 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2013-12-11 16:20 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (16.85 KB, patch)
2013-12-11 16:21 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2013-12-11 16:22 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (22.64 KB, patch)
2013-12-11 16:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.14 KB, patch)
2013-12-11 16:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2013-12-11 16:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.07 KB, patch)
2013-12-11 16:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2013-12-11 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.81 KB, patch)
2013-12-11 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2013-12-11 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.04 KB, patch)
2013-12-11 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (44.43 KB, patch)
2013-12-11 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2013-12-11 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.60 KB, patch)
2013-12-11 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2013-12-11 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (16.85 KB, patch)
2013-12-11 16:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2013-12-11 16:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (22.64 KB, patch)
2013-12-11 18:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (22.64 KB, patch)
2013-12-11 18:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.14 KB, patch)
2013-12-11 18:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2013-12-11 18:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (73.67 KB, patch)
2013-12-11 18:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2013-12-11 18:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.81 KB, patch)
2013-12-11 18:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2013-12-11 18:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.04 KB, patch)
2013-12-11 18:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (44.43 KB, patch)
2013-12-11 18:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2013-12-11 18:18 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.60 KB, patch)
2013-12-11 18:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2013-12-11 18:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (16.85 KB, patch)
2013-12-11 18:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2013-12-11 18:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (26.03 KB, patch)
2013-12-11 19:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.19 KB, patch)
2013-12-11 19:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2013-12-11 19:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (73.67 KB, patch)
2013-12-11 19:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2013-12-11 19:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.81 KB, patch)
2013-12-11 19:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2013-12-11 19:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.04 KB, patch)
2013-12-11 19:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (44.43 KB, patch)
2013-12-11 19:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2013-12-11 19:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.60 KB, patch)
2013-12-11 19:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2013-12-11 19:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.86 KB, patch)
2013-12-11 19:36 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2013-12-11 19:36 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.04 KB, patch)
2013-12-17 13:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (26.03 KB, patch)
2013-12-18 18:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.19 KB, patch)
2013-12-18 18:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2013-12-18 18:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.02 KB, patch)
2013-12-18 18:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2013-12-18 18:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.80 KB, patch)
2013-12-18 18:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2013-12-18 18:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.04 KB, patch)
2013-12-18 18:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (44.43 KB, patch)
2013-12-18 18:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2013-12-18 18:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.60 KB, patch)
2013-12-18 18:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2013-12-18 18:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2013-12-18 18:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2013-12-18 18:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2013-12-18 18:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (26.03 KB, patch)
2014-01-06 13:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.02 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.80 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.82 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-01-06 13:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-01-06 13:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2014-01-06 13:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2014-01-06 13:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-01-06 13:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (26.03 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.02 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.80 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.82 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-01-22 16:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-01-22 16:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-01-22 16:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.86 KB, patch)
2014-01-22 16:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2014-01-22 16:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-01-22 16:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.46 KB, patch)
2014-01-22 16:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-01-22 17:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.64 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.23 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.80 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.88 KB, patch)
2014-01-27 17:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-01-27 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-01-27 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-01-27 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2014-01-27 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2014-01-27 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-01-27 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-01-27 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-01-27 18:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.64 KB, patch)
2014-01-28 12:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-01-28 12:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2014-01-28 12:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.23 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.80 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.88 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-01-28 12:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-01-28 12:02 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.64 KB, patch)
2014-01-28 12:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.35 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.17 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.80 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.88 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-01-28 12:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-01-28 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-01-28 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2014-01-28 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2014-01-28 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-01-28 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-01-28 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-01-28 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.64 KB, patch)
2014-01-28 14:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-01-28 14:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.35 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.38 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.80 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.88 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.03 KB, patch)
2014-01-28 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-01-28 14:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-01-28 14:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-01-28 14:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (859.12 KB, patch)
2014-01-28 14:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (7.23 KB, patch)
2014-01-28 14:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.64 KB, patch)
2014-03-04 14:24 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.06 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (75.08 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.38 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.79 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.88 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-03-04 14:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.93 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.10 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (1013.93 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (7.14 KB, patch)
2014-03-04 14:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.64 KB, patch)
2014-03-04 14:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-03-04 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.64 KB, patch)
2014-03-04 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-03-04 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.17 KB, patch)
2014-03-04 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.99 KB, patch)
2014-03-04 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.38 KB, patch)
2014-03-04 14:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.79 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.88 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.93 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.10 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-03-04 14:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-03-04 14:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-03-04 14:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (1013.93 KB, patch)
2014-03-04 14:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (7.14 KB, patch)
2014-03-04 14:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded (1.67 KB, patch)
2014-03-07 12:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines (31.65 KB, patch)
2014-03-07 13:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 21] - Fix ILSDI::Services (1.33 KB, patch)
2014-03-07 13:29 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines (31.65 KB, patch)
2014-03-07 13:30 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
opac screen (36.32 KB, image/png)
2014-03-10 17:05 UTC, Rafal Kopaczka
Details
Pay Fines (37.16 KB, text/plain)
2014-03-10 17:08 UTC, Rafal Kopaczka
Details
Currencies (2.24 KB, image/png)
2014-03-10 17:11 UTC, Rafal Kopaczka
Details
Pay Fines (37.16 KB, image/png)
2014-03-10 17:14 UTC, Rafal Kopaczka
Details
typo in fines header (106.06 KB, image/png)
2014-03-11 12:59 UTC, Nicole C. Engard
Details
Bug 6427 [Part 1] - Update schema files (29.41 KB, patch)
2014-04-16 12:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.17 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.99 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.38 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.81 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (2.99 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (45.89 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-04-16 12:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.49 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (115.12 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.96 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (1014.22 KB, patch)
2014-04-16 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (6.83 KB, patch)
2014-04-16 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded (1.67 KB, patch)
2014-04-16 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 21] - Fix ILSDI::Services (1.33 KB, patch)
2014-04-16 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines (31.65 KB, patch)
2014-04-16 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance (3.55 KB, patch)
2014-04-16 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items (1.80 KB, patch)
2014-04-16 13:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.41 KB, patch)
2014-05-08 12:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.17 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.99 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (47.61 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.82 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.01 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (46.62 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.42 KB, patch)
2014-05-08 12:15 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.89 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (116.31 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.86 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (1014.22 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (6.83 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded (1.67 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 21] - Fix ILSDI::Services (1.33 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines (31.65 KB, patch)
2014-05-08 12:16 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance (3.55 KB, patch)
2014-05-08 12:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items (1.80 KB, patch)
2014-05-08 12:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance (1.64 KB, patch)
2014-05-08 12:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.41 KB, patch)
2014-05-29 13:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-05-29 13:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.17 KB, patch)
2014-05-29 13:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.99 KB, patch)
2014-05-29 13:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (48.66 KB, patch)
2014-05-29 13:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.82 KB, patch)
2014-05-29 13:41 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.01 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (46.62 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.42 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.79 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (116.31 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.86 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-05-29 13:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (1014.22 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (6.83 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded (1.67 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 21] - Fix ILSDI::Services (1.33 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines (31.65 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance (3.55 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items (1.80 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance (1.64 KB, patch)
2014-05-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 26] - Simplify and improve account normalization and balancing (3.12 KB, patch)
2014-05-29 14:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 26] - Simplify and improve account normalization and balancing (3.48 KB, patch)
2014-05-29 14:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages (7.30 KB, patch)
2014-05-29 15:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages (6.76 KB, patch)
2014-05-29 15:21 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 28] - Add ability to void payments (14.52 KB, patch)
2014-05-29 18:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 28] - Add ability to void payments (15.15 KB, patch)
2014-05-29 20:36 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 28] - Add ability to void payments (18.75 KB, patch)
2014-05-29 20:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.41 KB, patch)
2014-06-12 11:25 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-06-12 11:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.17 KB, patch)
2014-06-12 11:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.99 KB, patch)
2014-06-12 11:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (48.66 KB, patch)
2014-06-12 11:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.82 KB, patch)
2014-06-12 11:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-06-12 11:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.01 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (46.62 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.42 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.79 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (116.17 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.86 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-06-12 11:27 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (1014.22 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (6.83 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded (1.67 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 21] - Fix ILSDI::Services (1.33 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines (31.65 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance (3.55 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items (1.80 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance (1.64 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 26] - Simplify and improve account normalization and balancing (3.48 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages (6.78 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 28] - Add ability to void payments (18.83 KB, patch)
2014-06-12 11:28 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 29] - Force the amount to pay to display as a two decimal float (1.00 KB, patch)
2014-06-17 13:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 30] - Do not auto-print reciepts for manual invoices (840 bytes, patch)
2014-06-17 13:06 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 31] - Restore the lost item fee description (882 bytes, patch)
2014-06-17 13:06 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 32] - Fix koha-qa.pl issues (5.43 KB, patch)
2014-06-17 13:26 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 33] - Remove unescaped key value pairs (1.09 KB, patch)
2014-06-17 14:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 34] - Issues view should show Yes to fines only for items with associated debits in opac (1.77 KB, patch)
2014-06-23 17:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 1] - Update schema files (29.41 KB, patch)
2014-06-25 17:31 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 2] - Add new accounts related modules (25.20 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 3] - Add new TT plugin to deal with currency (3.17 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and payments (74.99 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 5] - Implement new accounting system in the opac (48.66 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts (9.82 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 7] - Update cron scripts (3.13 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 8] - Update existing intranet scripts (3.01 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 9] - Update existing perl modules to support new accounting system (46.62 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 10] - Update reports wizard (3.10 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 11] - Add new utility functions (1.42 KB, patch)
2014-06-25 17:32 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 12] - Add and update unit tests (9.17 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 13] - Add database updates (17.79 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 14] - Delete unused and unnecessary files (116.17 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts (3.02 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 16] - Use AuthorisedValues plugin instead of removed KohaAuthorisedValues plugin (4.86 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 17] - Add cron script to recalculate account balances (2.67 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 18] - Add TableTools plugin for DataTables (1014.22 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 19] - Add full debit and credit table Print and Download features (6.83 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 20] - Update C4::Circulation::AddEnrolmentFeeIfNeeded (1.67 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 21] - Fix ILSDI::Services (1.33 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 22] - Remove unused scripts that reference previous accounts tables, references to old subroutines (31.59 KB, patch)
2014-06-25 17:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 23] - Fix typos, symantic error in GetMemberAccountBalance (3.55 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 24] - Fines with accruing = 0 should not be updated, even if they are for checked out and overdue items (1.80 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 25] - Fix inverted logic in GetMemberAccountBalance (1.64 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 26] - Simplify and improve account normalization and balancing (3.48 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 27] - Reimplement bug 11869 - Add more informations to the member printing pages (6.78 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 28] - Add ability to void payments (18.83 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 29] - Force the amount to pay to display as a two decimal float (1.00 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 30] - Do not auto-print reciepts for manual invoices (840 bytes, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 31] - Restore the lost item fee description (885 bytes, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 32] - Fix koha-qa.pl issues (5.43 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 33] - Remove unescaped key value pairs (1.09 KB, patch)
2014-06-25 17:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 34] - Issues view should show Yes to fines only for items with associated debits in opac (1.77 KB, patch)
2014-06-25 17:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 35] - Update ProcessOfflinePayment (1.09 KB, patch)
2014-06-25 17:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [Part 35] - Add type to note for SIP2 payments (2.08 KB, patch)
2014-06-25 17:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.22 KB, patch)
2014-07-15 16:06 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.69 KB, patch)
2014-07-15 16:06 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.83 KB, patch)
2014-07-15 16:06 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (53.87 KB, patch)
2014-07-15 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-07-15 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-07-15 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.50 KB, patch)
2014-07-15 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (22.95 KB, patch)
2014-07-15 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.61 KB, patch)
2014-07-15 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-07-15 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (144.26 KB, patch)
2014-07-15 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (9.20 KB, patch)
2014-07-15 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.22 KB, patch)
2014-07-15 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.69 KB, patch)
2014-07-15 16:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.83 KB, patch)
2014-07-15 16:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (53.97 KB, patch)
2014-07-15 16:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-07-15 16:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-07-15 16:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.50 KB, patch)
2014-07-15 16:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (22.95 KB, patch)
2014-07-15 16:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.61 KB, patch)
2014-07-15 16:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-07-15 16:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (144.26 KB, patch)
2014-07-15 17:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (10.99 KB, patch)
2014-07-15 17:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.37 KB, patch)
2014-07-29 13:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.69 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.83 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (53.97 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.83 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (22.95 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.29 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-07-29 13:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-07-29 13:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (10.99 KB, patch)
2014-07-29 13:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.37 KB, patch)
2014-07-30 11:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.69 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.83 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (53.97 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.83 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.36 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.29 KB, patch)
2014-07-30 11:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-07-30 11:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-07-30 11:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (10.99 KB, patch)
2014-07-30 11:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.37 KB, patch)
2014-07-31 17:22 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.69 KB, patch)
2014-07-31 17:22 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.83 KB, patch)
2014-07-31 17:22 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (54.04 KB, patch)
2014-07-31 17:22 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-07-31 17:22 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-07-31 17:23 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.83 KB, patch)
2014-07-31 17:23 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.36 KB, patch)
2014-07-31 17:23 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.29 KB, patch)
2014-07-31 17:23 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-07-31 17:23 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-07-31 17:23 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (10.99 KB, patch)
2014-07-31 17:24 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.21 KB, patch)
2014-09-09 12:48 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.49 KB, patch)
2014-09-09 12:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-09-09 12:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.36 KB, patch)
2014-09-09 12:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-09-09 12:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-09-09 12:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.83 KB, patch)
2014-09-09 12:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.36 KB, patch)
2014-09-09 12:49 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.29 KB, patch)
2014-09-09 12:50 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-09-09 12:50 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-09-09 12:50 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-09-09 12:50 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.21 KB, patch)
2014-09-19 16:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.13 KB, patch)
2014-09-19 16:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-09-19 16:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (59.42 KB, patch)
2014-09-19 16:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-09-19 16:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-09-19 16:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.83 KB, patch)
2014-09-19 16:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.36 KB, patch)
2014-09-19 16:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.29 KB, patch)
2014-09-19 16:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-09-19 16:45 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-09-19 16:46 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-09-19 16:46 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.21 KB, patch)
2014-09-19 16:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.13 KB, patch)
2014-09-19 16:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-09-19 16:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (60.36 KB, patch)
2014-09-19 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-09-19 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-09-19 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (78.83 KB, patch)
2014-09-19 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.36 KB, patch)
2014-09-19 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.29 KB, patch)
2014-09-19 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-09-19 16:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-09-19 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-09-19 16:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.21 KB, patch)
2014-10-17 12:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.13 KB, patch)
2014-10-17 12:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-10-17 12:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.62 KB, patch)
2014-10-17 12:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-10-17 12:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-10-17 12:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.11 KB, patch)
2014-10-17 12:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.36 KB, patch)
2014-10-17 12:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.33 KB, patch)
2014-10-17 12:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-10-17 12:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-10-17 12:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-10-17 12:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.83 KB, patch)
2014-10-22 18:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (21.13 KB, patch)
2014-10-22 18:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-10-22 18:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.62 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.11 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.38 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.33 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-10-22 18:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-10-22 18:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.57 KB, patch)
2014-10-28 14:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (20.48 KB, patch)
2014-10-28 14:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-10-28 14:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.62 KB, patch)
2014-10-28 14:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-10-28 14:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-10-28 14:47 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.75 KB, patch)
2014-10-28 14:48 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.38 KB, patch)
2014-10-28 14:48 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.33 KB, patch)
2014-10-28 14:48 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-10-28 14:48 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-10-28 14:48 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-10-28 14:48 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.54 KB, patch)
2014-11-05 16:07 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (20.61 KB, patch)
2014-11-05 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-11-05 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.62 KB, patch)
2014-11-05 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-11-05 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-11-05 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.75 KB, patch)
2014-11-05 16:08 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.38 KB, patch)
2014-11-05 16:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.33 KB, patch)
2014-11-05 16:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-11-05 16:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.64 KB, patch)
2014-11-05 16:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-11-05 16:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.54 KB, patch)
2014-12-03 17:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (20.61 KB, patch)
2014-12-03 17:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-12-03 17:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.54 KB, patch)
2014-12-03 17:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-12-03 17:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-12-03 17:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.75 KB, patch)
2014-12-03 17:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.44 KB, patch)
2014-12-03 18:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.36 KB, patch)
2014-12-03 18:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-12-03 18:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (149.28 KB, patch)
2014-12-03 18:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-12-03 18:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.90 KB, patch)
2014-12-09 13:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (20.61 KB, patch)
2014-12-09 13:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (25.92 KB, patch)
2014-12-09 13:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.54 KB, patch)
2014-12-09 13:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.16 KB, patch)
2014-12-09 13:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.21 KB, patch)
2014-12-09 13:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.75 KB, patch)
2014-12-09 13:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.44 KB, patch)
2014-12-09 13:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.36 KB, patch)
2014-12-09 13:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.49 KB, patch)
2014-12-09 13:01 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (149.28 KB, patch)
2014-12-09 13:02 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.30 KB, patch)
2014-12-09 13:02 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Update database (21.18 KB, patch)
2015-01-14 15:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Update schema files (19.40 KB, patch)
2015-01-14 15:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Add new Accounts related Koha modules (26.04 KB, patch)
2015-01-14 15:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Update existing Koha perl modules (58.63 KB, patch)
2015-01-14 15:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Add new TT plugin to deal with currency (3.28 KB, patch)
2015-01-14 15:09 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Add TableTools plugin for DataTables (1014.34 KB, patch)
2015-01-14 15:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Add new staff scripts for managing accounts (81.86 KB, patch)
2015-01-14 15:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Update existing intranet scripts (23.59 KB, patch)
2015-01-14 15:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Update OPAC scripts (27.50 KB, patch)
2015-01-14 15:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Add & update cron scripts (5.61 KB, patch)
2015-01-14 15:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Delete unused and unnecessary files (149.53 KB, patch)
2015-01-14 15:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Unit Tests (11.42 KB, patch)
2015-01-14 15:10 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6427 - Make fines tabs link to account payment page (4.31 KB, patch)
2015-01-14 15:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-01-15 12:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (21.19 KB, patch)
2015-03-02 15:50 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (19.39 KB, patch)
2015-03-02 15:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (26.02 KB, patch)
2015-03-02 15:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.62 KB, patch)
2015-03-02 15:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.25 KB, patch)
2015-03-02 15:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.31 KB, patch)
2015-03-02 15:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.83 KB, patch)
2015-03-02 15:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.50 KB, patch)
2015-03-02 15:55 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.48 KB, patch)
2015-03-02 15:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.60 KB, patch)
2015-03-02 15:56 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (149.61 KB, patch)
2015-03-02 15:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.41 KB, patch)
2015-03-02 15:58 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Make fines tabs link to account payment page (4.24 KB, patch)
2015-03-02 15:59 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-03-02 16:00 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Drop old accounts tables (10.46 KB, patch)
2015-03-03 10:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Further improvments to updatadatabase (3.98 KB, patch)
2015-03-03 11:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix accounts table default sorting (1.48 KB, patch)
2015-03-03 11:19 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (21.37 KB, patch)
2015-03-23 15:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (19.39 KB, patch)
2015-03-23 15:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (26.03 KB, patch)
2015-03-23 15:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.62 KB, patch)
2015-03-23 15:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.27 KB, patch)
2015-03-23 15:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.32 KB, patch)
2015-03-23 15:12 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.84 KB, patch)
2015-03-23 15:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (23.50 KB, patch)
2015-03-23 15:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.48 KB, patch)
2015-03-23 15:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.60 KB, patch)
2015-03-23 15:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (149.63 KB, patch)
2015-03-23 15:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.41 KB, patch)
2015-03-23 15:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Make fines tabs link to account payment page (4.21 KB, patch)
2015-03-23 15:13 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-03-23 15:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix accounts table default sorting (1.48 KB, patch)
2015-03-23 15:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Drop old accounts tables (841 bytes, patch)
2015-03-23 15:14 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (21.37 KB, patch)
2015-03-23 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (19.39 KB, patch)
2015-03-23 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (26.03 KB, patch)
2015-03-23 17:42 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.62 KB, patch)
2015-03-23 17:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.27 KB, patch)
2015-03-23 17:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.32 KB, patch)
2015-03-23 17:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.84 KB, patch)
2015-03-23 17:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (25.25 KB, patch)
2015-03-23 17:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.48 KB, patch)
2015-03-23 17:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.60 KB, patch)
2015-03-23 17:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (149.63 KB, patch)
2015-03-23 17:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.41 KB, patch)
2015-03-23 17:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Make fines tabs link to account payment page (4.21 KB, patch)
2015-03-23 17:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-03-23 17:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix accounts table default sorting (1.48 KB, patch)
2015-03-23 17:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Drop old accounts tables (841 bytes, patch)
2015-03-23 17:44 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (21.13 KB, patch)
2015-03-25 18:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (19.39 KB, patch)
2015-03-25 18:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (26.03 KB, patch)
2015-03-25 18:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.99 KB, patch)
2015-03-25 18:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.27 KB, patch)
2015-03-25 18:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add TableTools plugin for DataTables (1014.32 KB, patch)
2015-03-25 18:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.84 KB, patch)
2015-03-25 18:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (25.25 KB, patch)
2015-03-25 18:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.48 KB, patch)
2015-03-25 18:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.60 KB, patch)
2015-03-25 18:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (149.63 KB, patch)
2015-03-25 18:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (11.41 KB, patch)
2015-03-25 18:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Make fines tabs link to account payment page (4.21 KB, patch)
2015-03-25 18:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-03-25 18:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix accounts table default sorting (1.48 KB, patch)
2015-03-25 18:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Drop old accounts tables (841 bytes, patch)
2015-03-25 18:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (21.20 KB, patch)
2015-04-21 13:37 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (19.39 KB, patch)
2015-04-21 13:37 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (26.03 KB, patch)
2015-04-21 13:38 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.82 KB, patch)
2015-04-21 13:38 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.27 KB, patch)
2015-04-21 13:38 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.84 KB, patch)
2015-04-21 13:38 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (24.49 KB, patch)
2015-04-21 13:38 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.49 KB, patch)
2015-04-21 13:38 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.60 KB, patch)
2015-04-21 13:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (148.97 KB, patch)
2015-04-21 13:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (16.86 KB, patch)
2015-04-21 13:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Make fines tabs link to account payment page (4.21 KB, patch)
2015-04-21 13:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-04-21 13:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix accounts table default sorting (1.48 KB, patch)
2015-04-21 13:39 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Drop old accounts tables (841 bytes, patch)
2015-04-21 13:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix kohastructure.sql (1.04 KB, patch)
2015-04-21 13:40 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.53 KB, patch)
2015-05-12 12:03 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (17.87 KB, patch)
2015-05-12 12:03 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (26.03 KB, patch)
2015-05-12 12:03 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (58.83 KB, patch)
2015-05-12 12:03 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.27 KB, patch)
2015-05-12 12:03 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.84 KB, patch)
2015-05-12 12:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (24.50 KB, patch)
2015-05-12 12:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.49 KB, patch)
2015-05-12 12:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.60 KB, patch)
2015-05-12 12:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.93 KB, patch)
2015-05-12 12:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (16.86 KB, patch)
2015-05-12 12:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Make fines tabs link to account payment page (4.21 KB, patch)
2015-05-12 12:04 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-05-12 12:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix accounts table default sorting (1.48 KB, patch)
2015-05-12 12:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Drop old accounts tables (840 bytes, patch)
2015-05-12 12:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix kohastructure.sql (1.03 KB, patch)
2015-05-12 12:05 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update database (20.53 KB, patch)
2015-05-29 11:33 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update schema files (17.87 KB, patch)
2015-05-29 11:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new Accounts related Koha modules (26.03 KB, patch)
2015-05-29 11:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing Koha perl modules (59.00 KB, patch)
2015-05-29 11:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new TT plugin to deal with currency (3.27 KB, patch)
2015-05-29 11:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add new staff scripts for managing accounts (81.84 KB, patch)
2015-05-29 11:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update existing intranet scripts (24.50 KB, patch)
2015-05-29 11:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Update OPAC scripts (27.49 KB, patch)
2015-05-29 11:34 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Add & update cron scripts (5.60 KB, patch)
2015-05-29 11:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Delete unused and unnecessary files (146.93 KB, patch)
2015-05-29 11:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Unit Tests (16.86 KB, patch)
2015-05-29 11:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 - Make fines tabs link to account payment page (4.21 KB, patch)
2015-05-29 11:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Improvements to OPAC view (5.06 KB, patch)
2015-05-29 11:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix accounts table default sorting (1.48 KB, patch)
2015-05-29 11:35 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Drop old accounts tables (840 bytes, patch)
2015-05-29 11:36 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 6427 [QA Followup] - Fix kohastructure.sql (1.03 KB, patch)
2015-05-29 11:36 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2011-05-30 04:52:52 UTC
The accounts system is in need of a rewrite. This will solve two purposes:

1) It'll make the code a lot nicer, and things won't be doing direct table access from all over the place. Also, some unused and long dead features will be stripped out.

2) It'll allow the account code to be a lot more flexible, making features like partial payments a whole lot seamless.

This is in progress, it can be viewed here:
http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/bywater/wr78012

And accessed via: git://git.catalyst.net.nz/git/public/koha.git, in the branch "bywater/wr78012"
Comment 1 Katrin Fischer 2013-04-15 17:36:58 UTC
*** Bug 10057 has been marked as a duplicate of this bug. ***
Comment 2 Kyle M Hall (khall) 2013-10-09 14:52:11 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2013-11-04 13:47:49 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall (khall) 2013-11-04 13:47:59 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall (khall) 2013-11-04 14:13:22 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall (khall) 2013-11-04 14:13:50 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall (khall) 2013-11-04 14:14:00 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall (khall) 2013-11-04 14:17:55 UTC
Also available at http://git.bywatersolutions.com/koha.git/shortlog/refs/heads/accounts_rewrite
Comment 9 Kyle M Hall (khall) 2013-11-05 20:43:06 UTC Comment hidden (obsolete)
Comment 10 Kyle M Hall (khall) 2013-11-12 13:09:27 UTC Comment hidden (obsolete)
Comment 11 Kyle M Hall (khall) 2013-11-12 13:09:40 UTC Comment hidden (obsolete)
Comment 12 Kyle M Hall (khall) 2013-11-12 13:21:19 UTC Comment hidden (obsolete)
Comment 13 Kyle M Hall (khall) 2013-11-12 13:29:44 UTC Comment hidden (obsolete)
Comment 14 Kyle M Hall (khall) 2013-11-12 13:37:51 UTC Comment hidden (obsolete)
Comment 15 Kyle M Hall (khall) 2013-11-12 13:39:16 UTC Comment hidden (obsolete)
Comment 16 Kyle M Hall (khall) 2013-11-12 13:42:00 UTC Comment hidden (obsolete)
Comment 17 Kyle M Hall (khall) 2013-11-12 14:33:51 UTC Comment hidden (obsolete)
Comment 18 Kyle M Hall (khall) 2013-11-12 20:50:11 UTC Comment hidden (obsolete)
Comment 19 Kyle M Hall (khall) 2013-11-14 16:35:24 UTC Comment hidden (obsolete)
Comment 20 Kyle M Hall (khall) 2013-11-14 20:07:35 UTC Comment hidden (obsolete)
Comment 21 Kyle M Hall (khall) 2013-11-14 20:27:02 UTC Comment hidden (obsolete)
Comment 22 Kyle M Hall (khall) 2013-11-18 14:16:33 UTC Comment hidden (obsolete)
Comment 23 Kyle M Hall (khall) 2013-11-18 15:40:59 UTC Comment hidden (obsolete)
Comment 24 Jonathan Druart 2013-11-21 13:45:12 UTC
Hi Kyle,
I would like to start a development using DBIx and I am taking a look at this development.
I think we should have some guided guidelines on about how to organize our classes.
Looking at your code, I have some questions to ask:
1/ Don't you think we should avoid calls to Koha::Database in pl files ?
2/ Don't you think new module in the Koha namespace should be OOP (for ex. using Class::Accessor)?

Outside the DBIx scope, I am wondering why do you have 2 scripts account_payment.pl and members/account_payment_do.pl. I suppose it is in order to remove the $op variable. I think it would be better to head towards a REST architecture. For example, here, we could imagine executing the AddCredit routine on a POST method and using the "show/list" view on a GET method.

For discussion.
Comment 25 Jonathan Druart 2013-11-21 13:47:20 UTC
I add Galen, Chris and Paul in the loop. But maybe the discussion should be on the koha-devel mailing-list.
Comment 26 Kyle M Hall (khall) 2013-11-25 14:55:26 UTC Comment hidden (obsolete)
Comment 27 Kyle M Hall (khall) 2013-11-26 13:27:46 UTC Comment hidden (obsolete)
Comment 28 Kyle M Hall (khall) 2013-11-26 16:13:00 UTC Comment hidden (obsolete)
Comment 29 Kyle M Hall (khall) 2013-11-26 17:08:49 UTC Comment hidden (obsolete)
Comment 30 Kyle M Hall (khall) 2013-11-27 14:27:40 UTC Comment hidden (obsolete)
Comment 31 Kyle M Hall (khall) 2013-12-03 14:24:34 UTC
Sorry I missed this comment until now!

> 1/ Don't you think we should avoid calls to Koha::Database in pl files ?

Using DBIx::Class is, afaik, allowed in pl files. Requiring it to be called from modules only just requires yet another layer of abstraction. The only time this is necessary is when business logic needs to be applied. That is, we should definitely keep code DRY by moving repeated chunks of code into a module subroutine, but for a single line call that is not affected by system preferences, this is both unnecessary and unwanted. It would merely slow the system down.

For repeated pieces of code that utilize system preferences, I think they *should* be in modules. Better yet, they should be part of the DBIx::Class files, but we haven't gotten to that stage yet.

If I am violating my own person views written above, it's simply because I am attempting to implement this new accounting system while making as few modifications to existing code as possible. I think any violations will need to be taken care of eventually. This is of course, assuming everyone else agrees with my views. In any case, those violations can and should be taken care of post-push once we have formalized our policies regarding usage of DBIC.

> 2/ Don't you think new module in the Koha namespace should be OOP (for ex.
> using Class::Accessor)?

Modules in the Koha namespace are not required to be OOP, and I can see no advantage to making Koha::Accounts OOP. The data objects themselves are OO, and Koha::Accounts is just a layer around these objects to manage them.

> 
> Outside the DBIx scope, I am wondering why do you have 2 scripts
> account_payment.pl and members/account_payment_do.pl. I suppose it is in
> order to remove the $op variable. I think it would be better to head towards
> a REST architecture. For example, here, we could imagine executing the
> AddCredit routine on a POST method and using the "show/list" view on a GET

That is certainly an interesting proposition. What advantages do you see to this? I'd take it much further and say we should make *all* fetching, creating, and updating of data be via REST methods, and make our scripts use those methods via ajax. I think this will make Koha much more responsive, and allow far more flexible integration with other software. What do you think?
Comment 32 Kyle M Hall (khall) 2013-12-03 14:29:42 UTC
One example of moving business logic into DBIC. Items should be smart enough to know that when item-level_itypes is set to biblio record, the call to $item->itype() should return $item->biblio->itemtype() instead. I imagine there is a way to override the existing itype() method, or we could just add a new method itemtype_by_preference() or similar.
Comment 33 Kyle M Hall (khall) 2013-12-03 15:06:06 UTC Comment hidden (obsolete)
Comment 34 Kyle M Hall (khall) 2013-12-03 17:28:44 UTC Comment hidden (obsolete)
Comment 35 Kyle M Hall (khall) 2013-12-03 17:58:31 UTC Comment hidden (obsolete)
Comment 36 Chris Cormack 2013-12-03 20:16:03 UTC
Comment on attachment 23276 [details] [review]
Bug 6427 - Rewrite of the accounts system

Review of attachment 23276 [details] [review]:
-----------------------------------------------------------------

::: C4/Koha.pm
@@ +1029,4 @@
>  
>  sub GetAuthorisedValues {
>      my ( $category, $selected, $opac ) = @_;
> +    warn "GetAuthorisedValues( $category, $selected, $opac )";

This needs a debug switch, or to be removed

@@ +1076,4 @@
>          push @results, $data;
>      }
>      $sth->finish;
> +    warn "RET: " . Data::Dumper::Dumper( \@results );

And this too, or the logs get loud very very fast

::: misc/release_notes/release_notes_3_10_0.txt
@@ +1762,4 @@
>  	8996	normal	In result page items with negative notforloan are available
>  	9017	normal	Quote of the day: Table footer not translated
>  	5312	minor	XHTML correction in authority summary
> +  8009	minor	Item descriptive data not populated on account_payment.pl

Shouldnt be in the patch, this looks like a search and replace gone wrong

::: misc/release_notes/release_notes_3_12_0.txt
@@ +579,4 @@
>  	8429	minor	Unnecessary use of Exporter in SIP/ILS objects
>  	9292	minor	Remove dead code related to 'publictype'
>  	9401	minor	Javascript used for tags handling wants access to CGISESSID cookie
> + 9582	minor	Unused code in members/account_payment.pl

Hmm not sure why this is in the patch?
Comment 37 Galen Charlton 2013-12-05 18:21:43 UTC
In addition to the specific points that Chris has made -- which, to be frank, do not inspire confidence that the rewrite patch has been sufficiently tested by the patch submitter -- this patch is simply too large to evaluate as is.

I *strongly* encourage you to break it up into a series of patches that, in effect, tell a story that can be evaluated, or at least read, a patch at a time.  A possible sequence might look like this:

* test cases: this is an opportunity for the test cases to describe the new API and provide some confidence that all aspect of the existing behavior have been covered.
* DB schema updates
* schema upgrade -- as this will require particularly close attention
* introduction of the new API in the Koha namespace
* elimination of the old C4 API and staff-side script changes
* public catalog-side changes

Other ways of organizing it are of course possible, but the main point is to break it up into smaller units that can be read one at a time, even if the entire series has to be applied for it to work at all.

It would be even better, although not necessarily possible, to structure the patch series in such a way that parts of it can be independently applied.

Also, to reiterate the point in my first paragraph: the more that you take care to eliminate debug code and trivial violations of the QA guidelines, the easier it will be for patch reviewers to focus on the substance.
Comment 38 Kyle M Hall (khall) 2013-12-11 14:05:34 UTC Comment hidden (obsolete)
Comment 39 Kyle M Hall (khall) 2013-12-11 14:15:57 UTC Comment hidden (obsolete)
Comment 40 Kyle M Hall (khall) 2013-12-11 16:18:10 UTC Comment hidden (obsolete)
Comment 41 Kyle M Hall (khall) 2013-12-11 16:18:22 UTC Comment hidden (obsolete)
Comment 42 Kyle M Hall (khall) 2013-12-11 16:18:32 UTC Comment hidden (obsolete)
Comment 43 Kyle M Hall (khall) 2013-12-11 16:18:41 UTC Comment hidden (obsolete)
Comment 44 Kyle M Hall (khall) 2013-12-11 16:18:51 UTC Comment hidden (obsolete)
Comment 45 Kyle M Hall (khall) 2013-12-11 16:19:01 UTC Comment hidden (obsolete)
Comment 46 Kyle M Hall (khall) 2013-12-11 16:19:12 UTC Comment hidden (obsolete)
Comment 47 Kyle M Hall (khall) 2013-12-11 16:19:22 UTC Comment hidden (obsolete)
Comment 48 Kyle M Hall (khall) 2013-12-11 16:20:19 UTC Comment hidden (obsolete)
Comment 49 Kyle M Hall (khall) 2013-12-11 16:20:30 UTC Comment hidden (obsolete)
Comment 50 Kyle M Hall (khall) 2013-12-11 16:20:40 UTC Comment hidden (obsolete)
Comment 51 Kyle M Hall (khall) 2013-12-11 16:20:59 UTC Comment hidden (obsolete)
Comment 52 Kyle M Hall (khall) 2013-12-11 16:21:10 UTC Comment hidden (obsolete)
Comment 53 Kyle M Hall (khall) 2013-12-11 16:22:12 UTC Comment hidden (obsolete)
Comment 54 Kyle M Hall (khall) 2013-12-11 16:28:23 UTC
Good calls. I had expected koha-qa.pl to pick those warns up ( it usually does ). 

Spot on! Thanks for catching those!

Kyle

(In reply to Chris Cormack from comment #36)
> Comment on attachment 23276 [details] [review] [review]
> Bug 6427 - Rewrite of the accounts system
> 
> Review of attachment 23276 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Koha.pm
> @@ +1029,4 @@
> >  
> >  sub GetAuthorisedValues {
> >      my ( $category, $selected, $opac ) = @_;
> > +    warn "GetAuthorisedValues( $category, $selected, $opac )";
> 
> This needs a debug switch, or to be removed
> 
> @@ +1076,4 @@
> >          push @results, $data;
> >      }
> >      $sth->finish;
> > +    warn "RET: " . Data::Dumper::Dumper( \@results );
> 
> And this too, or the logs get loud very very fast
> 
> ::: misc/release_notes/release_notes_3_10_0.txt
> @@ +1762,4 @@
> >  	8996	normal	In result page items with negative notforloan are available
> >  	9017	normal	Quote of the day: Table footer not translated
> >  	5312	minor	XHTML correction in authority summary
> > +  8009	minor	Item descriptive data not populated on account_payment.pl
> 
> Shouldnt be in the patch, this looks like a search and replace gone wrong
> 
> ::: misc/release_notes/release_notes_3_12_0.txt
> @@ +579,4 @@
> >  	8429	minor	Unnecessary use of Exporter in SIP/ILS objects
> >  	9292	minor	Remove dead code related to 'publictype'
> >  	9401	minor	Javascript used for tags handling wants access to CGISESSID cookie
> > + 9582	minor	Unused code in members/account_payment.pl
> 
> Hmm not sure why this is in the patch?
Comment 55 Kyle M Hall (khall) 2013-12-11 16:39:12 UTC
(In reply to Galen Charlton from comment #37)
> In addition to the specific points that Chris has made -- which, to be
> frank, do not inspire confidence that the rewrite patch has been
> sufficiently tested by the patch submitter -- this patch is simply too large
> to evaluate as is.

I assure you that I have tested it quite a bit, but I also agree with you. I plan to continue testing to with as many add edge cases as I can imagine. So far everything has been quite solid. My largest and foremost concern at that point is to ensure that updatedatabase.pl ports all existing accounting data to the new accounting system properly.

> 
> I *strongly* encourage you to break it up into a series of patches that, in
> effect, tell a story that can be evaluated, or at least read, a patch at a
> time.  A possible sequence might look like this:
> 
> Other ways of organizing it are of course possible, but the main point is to
> break it up into smaller units that can be read one at a time, even if the
> entire series has to be applied for it to work at all.
>

Done! I hope I haven't swung too far the other way with this patch series. I've tried to break it up into functional components as you can see ( schema, modules, intranet, opac, etc... ).

> It would be even better, although not necessarily possible, to structure the
> patch series in such a way that parts of it can be independently applied.

Each of these patches should be independently apply-able. However, I'm afraid some parts will not function without the patches after it ( I'm looking at you part 11 ). Splitting this patch was quite a task, and I'm afraid I did not keep it fully chronological such that each patch only requires the preceding patches to to be functional. If you have any suggestions on re-ordering the patches I will be happy to do so!

> Also, to reiterate the point in my first paragraph: the more that you take
> care to eliminate debug code and trivial violations of the QA guidelines,
> the easier it will be for patch reviewers to focus on the substance.

I agree. This patch series currently passes koha-qa.pl, so I have a fair confidence that I have taken care of all violations at this point!
Comment 56 Kyle M Hall (khall) 2013-12-11 16:54:53 UTC Comment hidden (obsolete)
Comment 57 Kyle M Hall (khall) 2013-12-11 16:55:29 UTC Comment hidden (obsolete)
Comment 58 Kyle M Hall (khall) 2013-12-11 16:55:42 UTC Comment hidden (obsolete)
Comment 59 Kyle M Hall (khall) 2013-12-11 16:55:58 UTC Comment hidden (obsolete)
Comment 60 Kyle M Hall (khall) 2013-12-11 16:56:15 UTC Comment hidden (obsolete)
Comment 61 Kyle M Hall (khall) 2013-12-11 16:56:32 UTC Comment hidden (obsolete)
Comment 62 Kyle M Hall (khall) 2013-12-11 16:56:47 UTC Comment hidden (obsolete)
Comment 63 Kyle M Hall (khall) 2013-12-11 16:57:00 UTC Comment hidden (obsolete)
Comment 64 Kyle M Hall (khall) 2013-12-11 16:57:20 UTC Comment hidden (obsolete)
Comment 65 Kyle M Hall (khall) 2013-12-11 16:57:32 UTC Comment hidden (obsolete)
Comment 66 Kyle M Hall (khall) 2013-12-11 16:57:44 UTC Comment hidden (obsolete)
Comment 67 Kyle M Hall (khall) 2013-12-11 16:57:55 UTC Comment hidden (obsolete)
Comment 68 Kyle M Hall (khall) 2013-12-11 16:58:08 UTC Comment hidden (obsolete)
Comment 69 Kyle M Hall (khall) 2013-12-11 16:58:17 UTC Comment hidden (obsolete)
Comment 70 Kyle M Hall (khall) 2013-12-11 18:16:53 UTC Comment hidden (obsolete)
Comment 71 Kyle M Hall (khall) 2013-12-11 18:17:25 UTC Comment hidden (obsolete)
Comment 72 Kyle M Hall (khall) 2013-12-11 18:17:34 UTC Comment hidden (obsolete)
Comment 73 Kyle M Hall (khall) 2013-12-11 18:17:42 UTC Comment hidden (obsolete)
Comment 74 Kyle M Hall (khall) 2013-12-11 18:17:51 UTC Comment hidden (obsolete)
Comment 75 Kyle M Hall (khall) 2013-12-11 18:18:01 UTC Comment hidden (obsolete)
Comment 76 Kyle M Hall (khall) 2013-12-11 18:18:11 UTC Comment hidden (obsolete)
Comment 77 Kyle M Hall (khall) 2013-12-11 18:18:23 UTC Comment hidden (obsolete)
Comment 78 Kyle M Hall (khall) 2013-12-11 18:18:32 UTC Comment hidden (obsolete)
Comment 79 Kyle M Hall (khall) 2013-12-11 18:18:43 UTC Comment hidden (obsolete)
Comment 80 Kyle M Hall (khall) 2013-12-11 18:18:53 UTC Comment hidden (obsolete)
Comment 81 Kyle M Hall (khall) 2013-12-11 18:19:05 UTC Comment hidden (obsolete)
Comment 82 Kyle M Hall (khall) 2013-12-11 18:19:15 UTC Comment hidden (obsolete)
Comment 83 Kyle M Hall (khall) 2013-12-11 18:19:26 UTC Comment hidden (obsolete)
Comment 84 Kyle M Hall (khall) 2013-12-11 18:19:36 UTC Comment hidden (obsolete)
Comment 85 Kyle M Hall (khall) 2013-12-11 19:33:45 UTC Comment hidden (obsolete)
Comment 86 Kyle M Hall (khall) 2013-12-11 19:34:12 UTC Comment hidden (obsolete)
Comment 87 Kyle M Hall (khall) 2013-12-11 19:34:20 UTC Comment hidden (obsolete)
Comment 88 Kyle M Hall (khall) 2013-12-11 19:34:27 UTC Comment hidden (obsolete)
Comment 89 Kyle M Hall (khall) 2013-12-11 19:34:36 UTC Comment hidden (obsolete)
Comment 90 Kyle M Hall (khall) 2013-12-11 19:34:44 UTC Comment hidden (obsolete)
Comment 91 Kyle M Hall (khall) 2013-12-11 19:34:53 UTC Comment hidden (obsolete)
Comment 92 Kyle M Hall (khall) 2013-12-11 19:35:02 UTC Comment hidden (obsolete)
Comment 93 Kyle M Hall (khall) 2013-12-11 19:35:13 UTC Comment hidden (obsolete)
Comment 94 Kyle M Hall (khall) 2013-12-11 19:35:25 UTC Comment hidden (obsolete)
Comment 95 Kyle M Hall (khall) 2013-12-11 19:35:36 UTC Comment hidden (obsolete)
Comment 96 Kyle M Hall (khall) 2013-12-11 19:35:48 UTC Comment hidden (obsolete)
Comment 97 Kyle M Hall (khall) 2013-12-11 19:36:00 UTC Comment hidden (obsolete)
Comment 98 Kyle M Hall (khall) 2013-12-11 19:36:15 UTC Comment hidden (obsolete)
Comment 99 Kyle M Hall (khall) 2013-12-17 13:35:48 UTC Comment hidden (obsolete)
Comment 100 Kyle M Hall (khall) 2013-12-18 18:12:58 UTC Comment hidden (obsolete)
Comment 101 Kyle M Hall (khall) 2013-12-18 18:13:27 UTC Comment hidden (obsolete)
Comment 102 Kyle M Hall (khall) 2013-12-18 18:13:34 UTC Comment hidden (obsolete)
Comment 103 Kyle M Hall (khall) 2013-12-18 18:13:42 UTC Comment hidden (obsolete)
Comment 104 Kyle M Hall (khall) 2013-12-18 18:13:49 UTC Comment hidden (obsolete)
Comment 105 Kyle M Hall (khall) 2013-12-18 18:13:57 UTC Comment hidden (obsolete)
Comment 106 Kyle M Hall (khall) 2013-12-18 18:14:08 UTC Comment hidden (obsolete)
Comment 107 Kyle M Hall (khall) 2013-12-18 18:14:15 UTC Comment hidden (obsolete)
Comment 108 Kyle M Hall (khall) 2013-12-18 18:14:23 UTC Comment hidden (obsolete)
Comment 109 Kyle M Hall (khall) 2013-12-18 18:14:30 UTC Comment hidden (obsolete)
Comment 110 Kyle M Hall (khall) 2013-12-18 18:14:37 UTC Comment hidden (obsolete)
Comment 111 Kyle M Hall (khall) 2013-12-18 18:14:45 UTC Comment hidden (obsolete)
Comment 112 Kyle M Hall (khall) 2013-12-18 18:14:52 UTC Comment hidden (obsolete)
Comment 113 Kyle M Hall (khall) 2013-12-18 18:15:00 UTC Comment hidden (obsolete)
Comment 114 Kyle M Hall (khall) 2013-12-18 18:15:13 UTC Comment hidden (obsolete)
Comment 115 Larry Baerveldt 2013-12-30 19:36:29 UTC
Warning, this code seems to break SIP functionality. C4/ILS.pm is looking for C4/Accounts.pm, but this update removes it.

Test:
cd C4/SIP
perl -c ILS.pm

Can't locate C4/Accounts.pm in @INC (@INC contains: /home/koha/kohaclone /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at ILS/Transaction/FeePayment.pm line 23.

Please do not signoff until SIP functionality has been restored.

- Larry
Comment 116 Kyle M Hall (khall) 2014-01-06 13:09:56 UTC Comment hidden (obsolete)
Comment 117 Kyle M Hall (khall) 2014-01-06 13:10:23 UTC Comment hidden (obsolete)
Comment 118 Kyle M Hall (khall) 2014-01-06 13:10:27 UTC Comment hidden (obsolete)
Comment 119 Kyle M Hall (khall) 2014-01-06 13:10:31 UTC Comment hidden (obsolete)
Comment 120 Kyle M Hall (khall) 2014-01-06 13:10:35 UTC Comment hidden (obsolete)
Comment 121 Kyle M Hall (khall) 2014-01-06 13:10:38 UTC Comment hidden (obsolete)
Comment 122 Kyle M Hall (khall) 2014-01-06 13:10:42 UTC Comment hidden (obsolete)
Comment 123 Kyle M Hall (khall) 2014-01-06 13:10:47 UTC Comment hidden (obsolete)
Comment 124 Kyle M Hall (khall) 2014-01-06 13:10:52 UTC Comment hidden (obsolete)
Comment 125 Kyle M Hall (khall) 2014-01-06 13:10:56 UTC Comment hidden (obsolete)
Comment 126 Kyle M Hall (khall) 2014-01-06 13:10:59 UTC Comment hidden (obsolete)
Comment 127 Kyle M Hall (khall) 2014-01-06 13:11:04 UTC Comment hidden (obsolete)
Comment 128 Kyle M Hall (khall) 2014-01-06 13:11:08 UTC Comment hidden (obsolete)
Comment 129 Kyle M Hall (khall) 2014-01-06 13:11:12 UTC Comment hidden (obsolete)
Comment 130 Kyle M Hall (khall) 2014-01-06 13:11:17 UTC Comment hidden (obsolete)
Comment 131 Kyle M Hall (khall) 2014-01-06 13:13:08 UTC
This new patch set fixes the SIP2 issue.

(In reply to Larry Baerveldt from comment #115)
> Warning, this code seems to break SIP functionality. C4/ILS.pm is looking
> for C4/Accounts.pm, but this update removes it.
> 
> Test:
> cd C4/SIP
> perl -c ILS.pm
> 
> Can't locate C4/Accounts.pm in @INC (@INC contains: /home/koha/kohaclone
> /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1
> /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10
> /usr/local/lib/site_perl .) at ILS/Transaction/FeePayment.pm line 23.
> 
> Please do not signoff until SIP functionality has been restored.
> 
> - Larry
Comment 132 Kyle M Hall (khall) 2014-01-22 16:11:06 UTC Comment hidden (obsolete)
Comment 133 Kyle M Hall (khall) 2014-01-22 16:11:24 UTC Comment hidden (obsolete)
Comment 134 Kyle M Hall (khall) 2014-01-22 16:11:28 UTC Comment hidden (obsolete)
Comment 135 Kyle M Hall (khall) 2014-01-22 16:11:32 UTC Comment hidden (obsolete)
Comment 136 Kyle M Hall (khall) 2014-01-22 16:11:36 UTC Comment hidden (obsolete)
Comment 137 Kyle M Hall (khall) 2014-01-22 16:11:41 UTC Comment hidden (obsolete)
Comment 138 Kyle M Hall (khall) 2014-01-22 16:11:45 UTC Comment hidden (obsolete)
Comment 139 Kyle M Hall (khall) 2014-01-22 16:11:50 UTC Comment hidden (obsolete)
Comment 140 Kyle M Hall (khall) 2014-01-22 16:11:54 UTC Comment hidden (obsolete)
Comment 141 Kyle M Hall (khall) 2014-01-22 16:11:58 UTC Comment hidden (obsolete)
Comment 142 Kyle M Hall (khall) 2014-01-22 16:12:04 UTC Comment hidden (obsolete)
Comment 143 Kyle M Hall (khall) 2014-01-22 16:12:08 UTC Comment hidden (obsolete)
Comment 144 Kyle M Hall (khall) 2014-01-22 16:12:13 UTC Comment hidden (obsolete)
Comment 145 Kyle M Hall (khall) 2014-01-22 16:12:18 UTC Comment hidden (obsolete)
Comment 146 Kyle M Hall (khall) 2014-01-22 16:12:23 UTC Comment hidden (obsolete)
Comment 147 Kyle M Hall (khall) 2014-01-22 16:49:52 UTC Comment hidden (obsolete)
Comment 148 Kyle M Hall (khall) 2014-01-22 17:01:21 UTC Comment hidden (obsolete)
Comment 149 Kyle M Hall (khall) 2014-01-27 17:41:06 UTC Comment hidden (obsolete)
Comment 150 Kyle M Hall (khall) 2014-01-27 17:41:27 UTC Comment hidden (obsolete)
Comment 151 Kyle M Hall (khall) 2014-01-27 17:41:31 UTC Comment hidden (obsolete)
Comment 152 Kyle M Hall (khall) 2014-01-27 17:41:36 UTC Comment hidden (obsolete)
Comment 153 Kyle M Hall (khall) 2014-01-27 17:41:40 UTC Comment hidden (obsolete)
Comment 154 Kyle M Hall (khall) 2014-01-27 17:41:45 UTC Comment hidden (obsolete)
Comment 155 Kyle M Hall (khall) 2014-01-27 17:41:49 UTC Comment hidden (obsolete)
Comment 156 Kyle M Hall (khall) 2014-01-27 17:41:53 UTC Comment hidden (obsolete)
Comment 157 Kyle M Hall (khall) 2014-01-27 17:41:57 UTC Comment hidden (obsolete)
Comment 158 Kyle M Hall (khall) 2014-01-27 17:42:03 UTC Comment hidden (obsolete)
Comment 159 Kyle M Hall (khall) 2014-01-27 17:42:08 UTC Comment hidden (obsolete)
Comment 160 Kyle M Hall (khall) 2014-01-27 17:42:13 UTC Comment hidden (obsolete)
Comment 161 Kyle M Hall (khall) 2014-01-27 17:42:17 UTC Comment hidden (obsolete)
Comment 162 Kyle M Hall (khall) 2014-01-27 17:42:22 UTC Comment hidden (obsolete)
Comment 163 Kyle M Hall (khall) 2014-01-27 17:42:27 UTC Comment hidden (obsolete)
Comment 164 Kyle M Hall (khall) 2014-01-27 17:42:31 UTC Comment hidden (obsolete)
Comment 165 Kyle M Hall (khall) 2014-01-27 18:00:17 UTC Comment hidden (obsolete)
Comment 166 Kyle M Hall (khall) 2014-01-28 12:00:09 UTC Comment hidden (obsolete)
Comment 167 Kyle M Hall (khall) 2014-01-28 12:00:54 UTC Comment hidden (obsolete)
Comment 168 Kyle M Hall (khall) 2014-01-28 12:00:59 UTC Comment hidden (obsolete)
Comment 169 Kyle M Hall (khall) 2014-01-28 12:01:05 UTC Comment hidden (obsolete)
Comment 170 Kyle M Hall (khall) 2014-01-28 12:01:10 UTC Comment hidden (obsolete)
Comment 171 Kyle M Hall (khall) 2014-01-28 12:01:14 UTC Comment hidden (obsolete)
Comment 172 Kyle M Hall (khall) 2014-01-28 12:01:18 UTC Comment hidden (obsolete)
Comment 173 Kyle M Hall (khall) 2014-01-28 12:01:23 UTC Comment hidden (obsolete)
Comment 174 Kyle M Hall (khall) 2014-01-28 12:01:27 UTC Comment hidden (obsolete)
Comment 175 Kyle M Hall (khall) 2014-01-28 12:01:31 UTC Comment hidden (obsolete)
Comment 176 Kyle M Hall (khall) 2014-01-28 12:01:35 UTC Comment hidden (obsolete)
Comment 177 Kyle M Hall (khall) 2014-01-28 12:01:40 UTC Comment hidden (obsolete)
Comment 178 Kyle M Hall (khall) 2014-01-28 12:01:44 UTC Comment hidden (obsolete)
Comment 179 Kyle M Hall (khall) 2014-01-28 12:01:49 UTC Comment hidden (obsolete)
Comment 180 Kyle M Hall (khall) 2014-01-28 12:01:55 UTC Comment hidden (obsolete)
Comment 181 Kyle M Hall (khall) 2014-01-28 12:01:59 UTC Comment hidden (obsolete)
Comment 182 Kyle M Hall (khall) 2014-01-28 12:02:07 UTC Comment hidden (obsolete)
Comment 183 Kyle M Hall (khall) 2014-01-28 12:10:58 UTC Comment hidden (obsolete)
Comment 184 Kyle M Hall (khall) 2014-01-28 12:11:20 UTC Comment hidden (obsolete)
Comment 185 Kyle M Hall (khall) 2014-01-28 12:11:24 UTC Comment hidden (obsolete)
Comment 186 Kyle M Hall (khall) 2014-01-28 12:11:29 UTC Comment hidden (obsolete)
Comment 187 Kyle M Hall (khall) 2014-01-28 12:11:34 UTC Comment hidden (obsolete)
Comment 188 Kyle M Hall (khall) 2014-01-28 12:11:38 UTC Comment hidden (obsolete)
Comment 189 Kyle M Hall (khall) 2014-01-28 12:11:42 UTC Comment hidden (obsolete)
Comment 190 Kyle M Hall (khall) 2014-01-28 12:11:47 UTC Comment hidden (obsolete)
Comment 191 Kyle M Hall (khall) 2014-01-28 12:11:51 UTC Comment hidden (obsolete)
Comment 192 Kyle M Hall (khall) 2014-01-28 12:11:56 UTC Comment hidden (obsolete)
Comment 193 Kyle M Hall (khall) 2014-01-28 12:12:00 UTC Comment hidden (obsolete)
Comment 194 Kyle M Hall (khall) 2014-01-28 12:12:07 UTC Comment hidden (obsolete)
Comment 195 Kyle M Hall (khall) 2014-01-28 12:12:12 UTC Comment hidden (obsolete)
Comment 196 Kyle M Hall (khall) 2014-01-28 12:12:16 UTC Comment hidden (obsolete)
Comment 197 Kyle M Hall (khall) 2014-01-28 12:12:21 UTC Comment hidden (obsolete)
Comment 198 Kyle M Hall (khall) 2014-01-28 12:12:25 UTC Comment hidden (obsolete)
Comment 199 Kyle M Hall (khall) 2014-01-28 12:12:29 UTC Comment hidden (obsolete)
Comment 200 Kyle M Hall (khall) 2014-01-28 14:42:32 UTC Comment hidden (obsolete)
Comment 201 Kyle M Hall (khall) 2014-01-28 14:42:58 UTC Comment hidden (obsolete)
Comment 202 Kyle M Hall (khall) 2014-01-28 14:43:03 UTC Comment hidden (obsolete)
Comment 203 Kyle M Hall (khall) 2014-01-28 14:43:09 UTC Comment hidden (obsolete)
Comment 204 Kyle M Hall (khall) 2014-01-28 14:43:13 UTC Comment hidden (obsolete)
Comment 205 Kyle M Hall (khall) 2014-01-28 14:43:18 UTC Comment hidden (obsolete)
Comment 206 Kyle M Hall (khall) 2014-01-28 14:43:23 UTC Comment hidden (obsolete)
Comment 207 Kyle M Hall (khall) 2014-01-28 14:43:27 UTC Comment hidden (obsolete)
Comment 208 Kyle M Hall (khall) 2014-01-28 14:43:32 UTC Comment hidden (obsolete)
Comment 209 Kyle M Hall (khall) 2014-01-28 14:43:36 UTC Comment hidden (obsolete)
Comment 210 Kyle M Hall (khall) 2014-01-28 14:43:41 UTC Comment hidden (obsolete)
Comment 211 Kyle M Hall (khall) 2014-01-28 14:43:46 UTC Comment hidden (obsolete)
Comment 212 Kyle M Hall (khall) 2014-01-28 14:43:50 UTC Comment hidden (obsolete)
Comment 213 Kyle M Hall (khall) 2014-01-28 14:43:55 UTC Comment hidden (obsolete)
Comment 214 Kyle M Hall (khall) 2014-01-28 14:44:00 UTC Comment hidden (obsolete)
Comment 215 Kyle M Hall (khall) 2014-01-28 14:44:07 UTC Comment hidden (obsolete)
Comment 216 Kyle M Hall (khall) 2014-01-28 14:44:12 UTC Comment hidden (obsolete)
Comment 217 Kyle M Hall (khall) 2014-01-28 14:44:17 UTC Comment hidden (obsolete)
Comment 218 Kyle M Hall (khall) 2014-01-28 14:44:22 UTC Comment hidden (obsolete)
Comment 219 Rafal Kopaczka 2014-02-14 15:05:41 UTC
I've looked quickly at this patch, got 2 issues (or not, correct me if I'm wrong):

1/ In part 4 patch, there is reference to js file that don't exist in repository, next parts also don't contain this file. 
Bug-6427-Part-04.patch:93:+<script type="text/javascript" src="[% interface %]/[% theme %]/en/js/strings.js"></script>

2/ In part 3, function format_without_symbol don't handle properly, national currencies without leading symbol (eg PLN). It truncate always first character even if it's a number. 
return substr( $self->format( $amount, FMT_SYMBOL ), 1 );
We can't assume that format always return symbol before number.
Comment 220 Kyle M Hall (khall) 2014-03-04 14:24:51 UTC Comment hidden (obsolete)
Comment 221 Kyle M Hall (khall) 2014-03-04 14:25:10 UTC Comment hidden (obsolete)
Comment 222 Kyle M Hall (khall) 2014-03-04 14:25:16 UTC Comment hidden (obsolete)
Comment 223 Kyle M Hall (khall) 2014-03-04 14:25:21 UTC Comment hidden (obsolete)
Comment 224 Kyle M Hall (khall) 2014-03-04 14:25:26 UTC Comment hidden (obsolete)
Comment 225 Kyle M Hall (khall) 2014-03-04 14:25:31 UTC Comment hidden (obsolete)
Comment 226 Kyle M Hall (khall) 2014-03-04 14:25:36 UTC Comment hidden (obsolete)
Comment 227 Kyle M Hall (khall) 2014-03-04 14:25:41 UTC Comment hidden (obsolete)
Comment 228 Kyle M Hall (khall) 2014-03-04 14:25:46 UTC Comment hidden (obsolete)
Comment 229 Kyle M Hall (khall) 2014-03-04 14:25:52 UTC Comment hidden (obsolete)
Comment 230 Kyle M Hall (khall) 2014-03-04 14:25:58 UTC Comment hidden (obsolete)
Comment 231 Kyle M Hall (khall) 2014-03-04 14:26:04 UTC Comment hidden (obsolete)
Comment 232 Kyle M Hall (khall) 2014-03-04 14:26:09 UTC Comment hidden (obsolete)
Comment 233 Kyle M Hall (khall) 2014-03-04 14:26:14 UTC Comment hidden (obsolete)
Comment 234 Kyle M Hall (khall) 2014-03-04 14:26:22 UTC Comment hidden (obsolete)
Comment 235 Kyle M Hall (khall) 2014-03-04 14:26:27 UTC Comment hidden (obsolete)
Comment 236 Kyle M Hall (khall) 2014-03-04 14:26:32 UTC Comment hidden (obsolete)
Comment 237 Kyle M Hall (khall) 2014-03-04 14:26:39 UTC Comment hidden (obsolete)
Comment 238 Kyle M Hall (khall) 2014-03-04 14:26:45 UTC Comment hidden (obsolete)
Comment 239 Kyle M Hall (khall) 2014-03-04 14:56:47 UTC Comment hidden (obsolete)
Comment 240 Kyle M Hall (khall) 2014-03-04 14:57:07 UTC Comment hidden (obsolete)
Comment 241 Kyle M Hall (khall) 2014-03-04 14:57:27 UTC Comment hidden (obsolete)
Comment 242 Kyle M Hall (khall) 2014-03-04 14:57:40 UTC Comment hidden (obsolete)
Comment 243 Kyle M Hall (khall) 2014-03-04 14:57:46 UTC Comment hidden (obsolete)
Comment 244 Kyle M Hall (khall) 2014-03-04 14:57:51 UTC Comment hidden (obsolete)
Comment 245 Kyle M Hall (khall) 2014-03-04 14:57:58 UTC Comment hidden (obsolete)
Comment 246 Kyle M Hall (khall) 2014-03-04 14:58:06 UTC Comment hidden (obsolete)
Comment 247 Kyle M Hall (khall) 2014-03-04 14:58:12 UTC Comment hidden (obsolete)
Comment 248 Kyle M Hall (khall) 2014-03-04 14:58:18 UTC Comment hidden (obsolete)
Comment 249 Kyle M Hall (khall) 2014-03-04 14:58:24 UTC Comment hidden (obsolete)
Comment 250 Kyle M Hall (khall) 2014-03-04 14:58:30 UTC Comment hidden (obsolete)
Comment 251 Kyle M Hall (khall) 2014-03-04 14:58:36 UTC Comment hidden (obsolete)
Comment 252 Kyle M Hall (khall) 2014-03-04 14:58:42 UTC Comment hidden (obsolete)
Comment 253 Kyle M Hall (khall) 2014-03-04 14:58:47 UTC Comment hidden (obsolete)
Comment 254 Kyle M Hall (khall) 2014-03-04 14:58:53 UTC Comment hidden (obsolete)
Comment 255 Kyle M Hall (khall) 2014-03-04 14:58:59 UTC Comment hidden (obsolete)
Comment 256 Kyle M Hall (khall) 2014-03-04 14:59:12 UTC Comment hidden (obsolete)
Comment 257 Kyle M Hall (khall) 2014-03-04 14:59:18 UTC Comment hidden (obsolete)
Comment 258 Kyle M Hall (khall) 2014-03-04 14:59:25 UTC Comment hidden (obsolete)
Comment 259 Kyle M Hall (khall) 2014-03-04 14:59:31 UTC Comment hidden (obsolete)
Comment 260 Kyle M Hall (khall) 2014-03-04 15:09:45 UTC
Thanks for letting me know! I've rolled the fixes for these 2 issues into the main patch set since they are still not signed off, rather than post a qa followup.

(In reply to Rafal Kopaczka from comment #219)
> I've looked quickly at this patch, got 2 issues (or not, correct me if I'm
> wrong):
> 
> 1/ In part 4 patch, there is reference to js file that don't exist in
> repository, next parts also don't contain this file. 
> Bug-6427-Part-04.patch:93:+<script type="text/javascript" src="[% interface
> %]/[% theme %]/en/js/strings.js"></script>
> 
> 2/ In part 3, function format_without_symbol don't handle properly, national
> currencies without leading symbol (eg PLN). It truncate always first
> character even if it's a number. 
> return substr( $self->format( $amount, FMT_SYMBOL ), 1 );
> We can't assume that format always return symbol before number.
Comment 261 Kyle M Hall (khall) 2014-03-07 12:45:39 UTC Comment hidden (obsolete)
Comment 262 Kyle M Hall (khall) 2014-03-07 13:28:37 UTC Comment hidden (obsolete)
Comment 263 Kyle M Hall (khall) 2014-03-07 13:29:41 UTC Comment hidden (obsolete)
Comment 264 Kyle M Hall (khall) 2014-03-07 13:30:01 UTC Comment hidden (obsolete)
Comment 265 Rafal Kopaczka 2014-03-10 17:05:42 UTC Comment hidden (obsolete)
Comment 266 Rafal Kopaczka 2014-03-10 17:08:51 UTC Comment hidden (obsolete)
Comment 267 Rafal Kopaczka 2014-03-10 17:11:31 UTC Comment hidden (obsolete)
Comment 268 Rafal Kopaczka 2014-03-10 17:14:39 UTC Comment hidden (obsolete)
Comment 269 Nicole C. Engard 2014-03-11 12:59:52 UTC Comment hidden (obsolete)
Comment 270 Kyle M Hall (khall) 2014-04-16 12:12:25 UTC Comment hidden (obsolete)
Comment 271 Kyle M Hall (khall) 2014-04-16 12:13:00 UTC Comment hidden (obsolete)
Comment 272 Kyle M Hall (khall) 2014-04-16 12:13:09 UTC Comment hidden (obsolete)
Comment 273 Kyle M Hall (khall) 2014-04-16 12:13:16 UTC Comment hidden (obsolete)
Comment 274 Kyle M Hall (khall) 2014-04-16 12:13:24 UTC Comment hidden (obsolete)
Comment 275 Kyle M Hall (khall) 2014-04-16 12:13:30 UTC Comment hidden (obsolete)
Comment 276 Kyle M Hall (khall) 2014-04-16 12:13:36 UTC Comment hidden (obsolete)
Comment 277 Kyle M Hall (khall) 2014-04-16 12:13:43 UTC Comment hidden (obsolete)
Comment 278 Kyle M Hall (khall) 2014-04-16 12:13:49 UTC Comment hidden (obsolete)
Comment 279 Kyle M Hall (khall) 2014-04-16 12:13:56 UTC Comment hidden (obsolete)
Comment 280 Kyle M Hall (khall) 2014-04-16 12:14:05 UTC Comment hidden (obsolete)
Comment 281 Kyle M Hall (khall) 2014-04-16 12:14:12 UTC Comment hidden (obsolete)
Comment 282 Kyle M Hall (khall) 2014-04-16 12:14:19 UTC Comment hidden (obsolete)
Comment 283 Kyle M Hall (khall) 2014-04-16 12:14:26 UTC Comment hidden (obsolete)
Comment 284 Kyle M Hall (khall) 2014-04-16 12:14:33 UTC Comment hidden (obsolete)
Comment 285 Kyle M Hall (khall) 2014-04-16 12:14:39 UTC Comment hidden (obsolete)
Comment 286 Kyle M Hall (khall) 2014-04-16 12:14:45 UTC Comment hidden (obsolete)
Comment 287 Kyle M Hall (khall) 2014-04-16 12:14:54 UTC Comment hidden (obsolete)
Comment 288 Kyle M Hall (khall) 2014-04-16 12:15:00 UTC Comment hidden (obsolete)
Comment 289 Kyle M Hall (khall) 2014-04-16 12:15:10 UTC Comment hidden (obsolete)
Comment 290 Kyle M Hall (khall) 2014-04-16 12:15:17 UTC Comment hidden (obsolete)
Comment 291 Kyle M Hall (khall) 2014-04-16 12:15:24 UTC Comment hidden (obsolete)
Comment 292 Kyle M Hall (khall) 2014-04-16 12:15:30 UTC Comment hidden (obsolete)
Comment 293 Kyle M Hall (khall) 2014-04-16 13:17:29 UTC Comment hidden (obsolete)
Comment 294 Owen Leonard 2014-04-22 18:36:35 UTC
Auto-merging Koha/DateUtils.pm
CONFLICT (content): Merge conflict in Koha/DateUtils.pm
Failed to merge in the changes.
Comment 295 Galen Charlton 2014-04-30 17:43:58 UTC
Note that the push of bug 6273 adds (at least) three potential payment types to deal with:

Pay00 - SIP2 cash payment
Pay01 - SIP2 VISA payment
Pay02 - SIP2 credit card payment

Of course, it wouldn't be surprising if there are SIP2 devices that define non-standard payment types as well.
Comment 296 Kyle M Hall (khall) 2014-05-08 11:39:08 UTC
(In reply to Galen Charlton from comment #295)
> Note that the push of bug 6273 adds (at least) three potential payment types
> to deal with:
> 
> Pay00 - SIP2 cash payment
> Pay01 - SIP2 VISA payment
> Pay02 - SIP2 credit card payment
> 
> Of course, it wouldn't be surprising if there are SIP2 devices that define
> non-standard payment types as well.

We have two choices here, we can either hard code these payment types in ( which will rarely be used ) *or* we can add setup documentation to have the library define these as MANUAL_DEBIT authorised values! Considering your final statement, I think that would be the best way to go.
Comment 297 Kyle M Hall (khall) 2014-05-08 12:14:52 UTC Comment hidden (obsolete)
Comment 298 Kyle M Hall (khall) 2014-05-08 12:15:13 UTC Comment hidden (obsolete)
Comment 299 Kyle M Hall (khall) 2014-05-08 12:15:19 UTC Comment hidden (obsolete)
Comment 300 Kyle M Hall (khall) 2014-05-08 12:15:25 UTC Comment hidden (obsolete)
Comment 301 Kyle M Hall (khall) 2014-05-08 12:15:30 UTC Comment hidden (obsolete)
Comment 302 Kyle M Hall (khall) 2014-05-08 12:15:35 UTC Comment hidden (obsolete)
Comment 303 Kyle M Hall (khall) 2014-05-08 12:15:40 UTC Comment hidden (obsolete)
Comment 304 Kyle M Hall (khall) 2014-05-08 12:15:45 UTC Comment hidden (obsolete)
Comment 305 Kyle M Hall (khall) 2014-05-08 12:15:50 UTC Comment hidden (obsolete)
Comment 306 Kyle M Hall (khall) 2014-05-08 12:15:54 UTC Comment hidden (obsolete)
Comment 307 Kyle M Hall (khall) 2014-05-08 12:15:59 UTC Comment hidden (obsolete)
Comment 308 Kyle M Hall (khall) 2014-05-08 12:16:04 UTC Comment hidden (obsolete)
Comment 309 Kyle M Hall (khall) 2014-05-08 12:16:09 UTC Comment hidden (obsolete)
Comment 310 Kyle M Hall (khall) 2014-05-08 12:16:14 UTC Comment hidden (obsolete)
Comment 311 Kyle M Hall (khall) 2014-05-08 12:16:20 UTC Comment hidden (obsolete)
Comment 312 Kyle M Hall (khall) 2014-05-08 12:16:25 UTC Comment hidden (obsolete)
Comment 313 Kyle M Hall (khall) 2014-05-08 12:16:30 UTC Comment hidden (obsolete)
Comment 314 Kyle M Hall (khall) 2014-05-08 12:16:38 UTC Comment hidden (obsolete)
Comment 315 Kyle M Hall (khall) 2014-05-08 12:16:44 UTC Comment hidden (obsolete)
Comment 316 Kyle M Hall (khall) 2014-05-08 12:16:49 UTC Comment hidden (obsolete)
Comment 317 Kyle M Hall (khall) 2014-05-08 12:16:54 UTC Comment hidden (obsolete)
Comment 318 Kyle M Hall (khall) 2014-05-08 12:16:59 UTC Comment hidden (obsolete)
Comment 319 Kyle M Hall (khall) 2014-05-08 12:17:04 UTC Comment hidden (obsolete)
Comment 320 Kyle M Hall (khall) 2014-05-08 12:17:09 UTC Comment hidden (obsolete)
Comment 321 Kyle M Hall (khall) 2014-05-08 12:17:14 UTC Comment hidden (obsolete)
Comment 322 Kyle M Hall (khall) 2014-05-29 13:41:07 UTC Comment hidden (obsolete)
Comment 323 Kyle M Hall (khall) 2014-05-29 13:41:38 UTC Comment hidden (obsolete)
Comment 324 Kyle M Hall (khall) 2014-05-29 13:41:43 UTC Comment hidden (obsolete)
Comment 325 Kyle M Hall (khall) 2014-05-29 13:41:48 UTC Comment hidden (obsolete)
Comment 326 Kyle M Hall (khall) 2014-05-29 13:41:54 UTC Comment hidden (obsolete)
Comment 327 Kyle M Hall (khall) 2014-05-29 13:41:59 UTC Comment hidden (obsolete)
Comment 328 Kyle M Hall (khall) 2014-05-29 13:42:04 UTC Comment hidden (obsolete)
Comment 329 Kyle M Hall (khall) 2014-05-29 13:42:08 UTC Comment hidden (obsolete)
Comment 330 Kyle M Hall (khall) 2014-05-29 13:42:13 UTC Comment hidden (obsolete)
Comment 331 Kyle M Hall (khall) 2014-05-29 13:42:18 UTC Comment hidden (obsolete)
Comment 332 Kyle M Hall (khall) 2014-05-29 13:42:23 UTC Comment hidden (obsolete)
Comment 333 Kyle M Hall (khall) 2014-05-29 13:42:28 UTC Comment hidden (obsolete)
Comment 334 Kyle M Hall (khall) 2014-05-29 13:42:33 UTC Comment hidden (obsolete)
Comment 335 Kyle M Hall (khall) 2014-05-29 13:42:39 UTC Comment hidden (obsolete)
Comment 336 Kyle M Hall (khall) 2014-05-29 13:42:44 UTC Comment hidden (obsolete)
Comment 337 Kyle M Hall (khall) 2014-05-29 13:42:49 UTC Comment hidden (obsolete)
Comment 338 Kyle M Hall (khall) 2014-05-29 13:42:54 UTC Comment hidden (obsolete)
Comment 339 Kyle M Hall (khall) 2014-05-29 13:43:02 UTC Comment hidden (obsolete)
Comment 340 Kyle M Hall (khall) 2014-05-29 13:43:07 UTC Comment hidden (obsolete)
Comment 341 Kyle M Hall (khall) 2014-05-29 13:43:11 UTC Comment hidden (obsolete)
Comment 342 Kyle M Hall (khall) 2014-05-29 13:43:16 UTC Comment hidden (obsolete)
Comment 343 Kyle M Hall (khall) 2014-05-29 13:43:22 UTC Comment hidden (obsolete)
Comment 344 Kyle M Hall (khall) 2014-05-29 13:43:28 UTC Comment hidden (obsolete)
Comment 345 Kyle M Hall (khall) 2014-05-29 13:43:34 UTC Comment hidden (obsolete)
Comment 346 Kyle M Hall (khall) 2014-05-29 13:43:40 UTC Comment hidden (obsolete)
Comment 347 Kyle M Hall (khall) 2014-05-29 14:09:39 UTC Comment hidden (obsolete)
Comment 348 Kyle M Hall (khall) 2014-05-29 14:10:53 UTC Comment hidden (obsolete)
Comment 349 Kyle M Hall (khall) 2014-05-29 15:17:28 UTC Comment hidden (obsolete)
Comment 350 Kyle M Hall (khall) 2014-05-29 15:21:27 UTC Comment hidden (obsolete)
Comment 351 Kyle M Hall (khall) 2014-05-29 18:09:09 UTC Comment hidden (obsolete)
Comment 352 Kyle M Hall (khall) 2014-05-29 20:36:04 UTC Comment hidden (obsolete)
Comment 353 Kyle M Hall (khall) 2014-05-29 20:39:20 UTC Comment hidden (obsolete)
Comment 354 Kyle M Hall (khall) 2014-06-12 11:25:43 UTC Comment hidden (obsolete)
Comment 355 Kyle M Hall (khall) 2014-06-12 11:26:26 UTC Comment hidden (obsolete)
Comment 356 Kyle M Hall (khall) 2014-06-12 11:26:31 UTC Comment hidden (obsolete)
Comment 357 Kyle M Hall (khall) 2014-06-12 11:26:37 UTC Comment hidden (obsolete)
Comment 358 Kyle M Hall (khall) 2014-06-12 11:26:43 UTC Comment hidden (obsolete)
Comment 359 Kyle M Hall (khall) 2014-06-12 11:26:49 UTC Comment hidden (obsolete)
Comment 360 Kyle M Hall (khall) 2014-06-12 11:26:54 UTC Comment hidden (obsolete)
Comment 361 Kyle M Hall (khall) 2014-06-12 11:27:00 UTC Comment hidden (obsolete)
Comment 362 Kyle M Hall (khall) 2014-06-12 11:27:06 UTC Comment hidden (obsolete)
Comment 363 Kyle M Hall (khall) 2014-06-12 11:27:12 UTC Comment hidden (obsolete)
Comment 364 Kyle M Hall (khall) 2014-06-12 11:27:18 UTC Comment hidden (obsolete)
Comment 365 Kyle M Hall (khall) 2014-06-12 11:27:23 UTC Comment hidden (obsolete)
Comment 366 Kyle M Hall (khall) 2014-06-12 11:27:29 UTC Comment hidden (obsolete)
Comment 367 Kyle M Hall (khall) 2014-06-12 11:27:35 UTC Comment hidden (obsolete)
Comment 368 Kyle M Hall (khall) 2014-06-12 11:27:40 UTC Comment hidden (obsolete)
Comment 369 Kyle M Hall (khall) 2014-06-12 11:27:46 UTC Comment hidden (obsolete)
Comment 370 Kyle M Hall (khall) 2014-06-12 11:27:52 UTC Comment hidden (obsolete)
Comment 371 Kyle M Hall (khall) 2014-06-12 11:28:00 UTC Comment hidden (obsolete)
Comment 372 Kyle M Hall (khall) 2014-06-12 11:28:06 UTC Comment hidden (obsolete)
Comment 373 Kyle M Hall (khall) 2014-06-12 11:28:12 UTC Comment hidden (obsolete)
Comment 374 Kyle M Hall (khall) 2014-06-12 11:28:18 UTC Comment hidden (obsolete)
Comment 375 Kyle M Hall (khall) 2014-06-12 11:28:24 UTC Comment hidden (obsolete)
Comment 376 Kyle M Hall (khall) 2014-06-12 11:28:29 UTC Comment hidden (obsolete)
Comment 377 Kyle M Hall (khall) 2014-06-12 11:28:35 UTC Comment hidden (obsolete)
Comment 378 Kyle M Hall (khall) 2014-06-12 11:28:41 UTC Comment hidden (obsolete)
Comment 379 Kyle M Hall (khall) 2014-06-12 11:28:47 UTC Comment hidden (obsolete)
Comment 380 Kyle M Hall (khall) 2014-06-12 11:28:53 UTC Comment hidden (obsolete)
Comment 381 Kyle M Hall (khall) 2014-06-12 11:28:59 UTC Comment hidden (obsolete)
Comment 382 Kyle M Hall (khall) 2014-06-17 13:05:55 UTC Comment hidden (obsolete)
Comment 383 Kyle M Hall (khall) 2014-06-17 13:06:02 UTC Comment hidden (obsolete)
Comment 384 Kyle M Hall (khall) 2014-06-17 13:06:09 UTC Comment hidden (obsolete)
Comment 385 Kyle M Hall (khall) 2014-06-17 13:26:23 UTC Comment hidden (obsolete)
Comment 386 Kyle M Hall (khall) 2014-06-17 14:04:12 UTC Comment hidden (obsolete)
Comment 387 Kyle M Hall (khall) 2014-06-23 17:55:14 UTC Comment hidden (obsolete)
Comment 388 Kyle M Hall (khall) 2014-06-25 17:31:38 UTC Comment hidden (obsolete)
Comment 389 Kyle M Hall (khall) 2014-06-25 17:32:06 UTC Comment hidden (obsolete)
Comment 390 Kyle M Hall (khall) 2014-06-25 17:32:11 UTC Comment hidden (obsolete)
Comment 391 Kyle M Hall (khall) 2014-06-25 17:32:17 UTC Comment hidden (obsolete)
Comment 392 Kyle M Hall (khall) 2014-06-25 17:32:23 UTC Comment hidden (obsolete)
Comment 393 Kyle M Hall (khall) 2014-06-25 17:32:28 UTC Comment hidden (obsolete)
Comment 394 Kyle M Hall (khall) 2014-06-25 17:32:33 UTC Comment hidden (obsolete)
Comment 395 Kyle M Hall (khall) 2014-06-25 17:32:38 UTC Comment hidden (obsolete)
Comment 396 Kyle M Hall (khall) 2014-06-25 17:32:44 UTC Comment hidden (obsolete)
Comment 397 Kyle M Hall (khall) 2014-06-25 17:32:49 UTC Comment hidden (obsolete)
Comment 398 Kyle M Hall (khall) 2014-06-25 17:32:54 UTC Comment hidden (obsolete)
Comment 399 Kyle M Hall (khall) 2014-06-25 17:33:00 UTC Comment hidden (obsolete)
Comment 400 Kyle M Hall (khall) 2014-06-25 17:33:05 UTC Comment hidden (obsolete)
Comment 401 Kyle M Hall (khall) 2014-06-25 17:33:11 UTC Comment hidden (obsolete)
Comment 402 Kyle M Hall (khall) 2014-06-25 17:33:18 UTC Comment hidden (obsolete)
Comment 403 Kyle M Hall (khall) 2014-06-25 17:33:23 UTC Comment hidden (obsolete)
Comment 404 Kyle M Hall (khall) 2014-06-25 17:33:28 UTC Comment hidden (obsolete)
Comment 405 Kyle M Hall (khall) 2014-06-25 17:33:36 UTC Comment hidden (obsolete)
Comment 406 Kyle M Hall (khall) 2014-06-25 17:33:41 UTC Comment hidden (obsolete)
Comment 407 Kyle M Hall (khall) 2014-06-25 17:33:47 UTC Comment hidden (obsolete)
Comment 408 Kyle M Hall (khall) 2014-06-25 17:33:52 UTC Comment hidden (obsolete)
Comment 409 Kyle M Hall (khall) 2014-06-25 17:33:58 UTC Comment hidden (obsolete)
Comment 410 Kyle M Hall (khall) 2014-06-25 17:34:03 UTC Comment hidden (obsolete)
Comment 411 Kyle M Hall (khall) 2014-06-25 17:34:08 UTC Comment hidden (obsolete)
Comment 412 Kyle M Hall (khall) 2014-06-25 17:34:14 UTC Comment hidden (obsolete)
Comment 413 Kyle M Hall (khall) 2014-06-25 17:34:19 UTC Comment hidden (obsolete)
Comment 414 Kyle M Hall (khall) 2014-06-25 17:34:26 UTC Comment hidden (obsolete)
Comment 415 Kyle M Hall (khall) 2014-06-25 17:34:32 UTC Comment hidden (obsolete)
Comment 416 Kyle M Hall (khall) 2014-06-25 17:34:37 UTC Comment hidden (obsolete)
Comment 417 Kyle M Hall (khall) 2014-06-25 17:34:43 UTC Comment hidden (obsolete)
Comment 418 Kyle M Hall (khall) 2014-06-25 17:34:48 UTC Comment hidden (obsolete)
Comment 419 Kyle M Hall (khall) 2014-06-25 17:34:53 UTC Comment hidden (obsolete)
Comment 420 Kyle M Hall (khall) 2014-06-25 17:34:59 UTC Comment hidden (obsolete)
Comment 421 Kyle M Hall (khall) 2014-06-25 17:35:05 UTC Comment hidden (obsolete)
Comment 422 Kyle M Hall (khall) 2014-06-25 17:35:11 UTC Comment hidden (obsolete)
Comment 423 Kyle M Hall (khall) 2014-06-25 17:47:04 UTC Comment hidden (obsolete)
Comment 424 Owen Leonard 2014-06-27 17:26:21 UTC
Is there a reason why there are so many separate patches? Is there one all-encompassing test plan for all?
Comment 425 Jesse Maseto 2014-07-08 19:53:54 UTC
Kyle,

I think these patches need to be rebased.

-Jesse
Comment 426 Kyle M Hall (khall) 2014-07-15 16:06:26 UTC Comment hidden (obsolete)
Comment 427 Kyle M Hall (khall) 2014-07-15 16:06:49 UTC Comment hidden (obsolete)
Comment 428 Kyle M Hall (khall) 2014-07-15 16:06:59 UTC Comment hidden (obsolete)
Comment 429 Kyle M Hall (khall) 2014-07-15 16:07:07 UTC Comment hidden (obsolete)
Comment 430 Kyle M Hall (khall) 2014-07-15 16:07:16 UTC Comment hidden (obsolete)
Comment 431 Kyle M Hall (khall) 2014-07-15 16:07:25 UTC Comment hidden (obsolete)
Comment 432 Kyle M Hall (khall) 2014-07-15 16:07:39 UTC Comment hidden (obsolete)
Comment 433 Kyle M Hall (khall) 2014-07-15 16:07:48 UTC Comment hidden (obsolete)
Comment 434 Kyle M Hall (khall) 2014-07-15 16:07:55 UTC Comment hidden (obsolete)
Comment 435 Kyle M Hall (khall) 2014-07-15 16:08:03 UTC Comment hidden (obsolete)
Comment 436 Kyle M Hall (khall) 2014-07-15 16:08:12 UTC Comment hidden (obsolete)
Comment 437 Kyle M Hall (khall) 2014-07-15 16:08:20 UTC Comment hidden (obsolete)
Comment 438 Kyle M Hall (khall) 2014-07-15 16:57:57 UTC Comment hidden (obsolete)
Comment 439 Kyle M Hall (khall) 2014-07-15 16:58:48 UTC Comment hidden (obsolete)
Comment 440 Kyle M Hall (khall) 2014-07-15 16:58:54 UTC Comment hidden (obsolete)
Comment 441 Kyle M Hall (khall) 2014-07-15 16:59:02 UTC Comment hidden (obsolete)
Comment 442 Kyle M Hall (khall) 2014-07-15 16:59:08 UTC Comment hidden (obsolete)
Comment 443 Kyle M Hall (khall) 2014-07-15 16:59:18 UTC Comment hidden (obsolete)
Comment 444 Kyle M Hall (khall) 2014-07-15 16:59:26 UTC Comment hidden (obsolete)
Comment 445 Kyle M Hall (khall) 2014-07-15 16:59:34 UTC Comment hidden (obsolete)
Comment 446 Kyle M Hall (khall) 2014-07-15 16:59:41 UTC Comment hidden (obsolete)
Comment 447 Kyle M Hall (khall) 2014-07-15 16:59:52 UTC Comment hidden (obsolete)
Comment 448 Kyle M Hall (khall) 2014-07-15 17:00:02 UTC Comment hidden (obsolete)
Comment 449 Kyle M Hall (khall) 2014-07-15 17:00:13 UTC Comment hidden (obsolete)
Comment 450 Kyle M Hall (khall) 2014-07-29 13:43:33 UTC Comment hidden (obsolete)
Comment 451 Kyle M Hall (khall) 2014-07-29 13:44:01 UTC Comment hidden (obsolete)
Comment 452 Kyle M Hall (khall) 2014-07-29 13:44:08 UTC Comment hidden (obsolete)
Comment 453 Kyle M Hall (khall) 2014-07-29 13:44:15 UTC Comment hidden (obsolete)
Comment 454 Kyle M Hall (khall) 2014-07-29 13:44:22 UTC Comment hidden (obsolete)
Comment 455 Kyle M Hall (khall) 2014-07-29 13:44:30 UTC Comment hidden (obsolete)
Comment 456 Kyle M Hall (khall) 2014-07-29 13:44:38 UTC Comment hidden (obsolete)
Comment 457 Kyle M Hall (khall) 2014-07-29 13:44:45 UTC Comment hidden (obsolete)
Comment 458 Kyle M Hall (khall) 2014-07-29 13:44:51 UTC Comment hidden (obsolete)
Comment 459 Kyle M Hall (khall) 2014-07-29 13:44:58 UTC Comment hidden (obsolete)
Comment 460 Kyle M Hall (khall) 2014-07-29 13:45:05 UTC Comment hidden (obsolete)
Comment 461 Kyle M Hall (khall) 2014-07-29 13:45:12 UTC Comment hidden (obsolete)
Comment 462 Kyle M Hall (khall) 2014-07-30 11:07:20 UTC Comment hidden (obsolete)
Comment 463 Kyle M Hall (khall) 2014-07-30 11:08:00 UTC Comment hidden (obsolete)
Comment 464 Kyle M Hall (khall) 2014-07-30 11:08:07 UTC Comment hidden (obsolete)
Comment 465 Kyle M Hall (khall) 2014-07-30 11:08:14 UTC Comment hidden (obsolete)
Comment 466 Kyle M Hall (khall) 2014-07-30 11:08:20 UTC Comment hidden (obsolete)
Comment 467 Kyle M Hall (khall) 2014-07-30 11:08:29 UTC Comment hidden (obsolete)
Comment 468 Kyle M Hall (khall) 2014-07-30 11:08:35 UTC Comment hidden (obsolete)
Comment 469 Kyle M Hall (khall) 2014-07-30 11:08:45 UTC Comment hidden (obsolete)
Comment 470 Kyle M Hall (khall) 2014-07-30 11:08:55 UTC Comment hidden (obsolete)
Comment 471 Kyle M Hall (khall) 2014-07-30 11:09:02 UTC Comment hidden (obsolete)
Comment 472 Kyle M Hall (khall) 2014-07-30 11:09:09 UTC Comment hidden (obsolete)
Comment 473 Kyle M Hall (khall) 2014-07-30 11:09:22 UTC Comment hidden (obsolete)
Comment 474 Kyle M Hall (khall) 2014-07-31 17:22:04 UTC Comment hidden (obsolete)
Comment 475 Kyle M Hall (khall) 2014-07-31 17:22:34 UTC Comment hidden (obsolete)
Comment 476 Kyle M Hall (khall) 2014-07-31 17:22:42 UTC Comment hidden (obsolete)
Comment 477 Kyle M Hall (khall) 2014-07-31 17:22:49 UTC Comment hidden (obsolete)
Comment 478 Kyle M Hall (khall) 2014-07-31 17:22:56 UTC Comment hidden (obsolete)
Comment 479 Kyle M Hall (khall) 2014-07-31 17:23:08 UTC Comment hidden (obsolete)
Comment 480 Kyle M Hall (khall) 2014-07-31 17:23:17 UTC Comment hidden (obsolete)
Comment 481 Kyle M Hall (khall) 2014-07-31 17:23:27 UTC Comment hidden (obsolete)
Comment 482 Kyle M Hall (khall) 2014-07-31 17:23:35 UTC Comment hidden (obsolete)
Comment 483 Kyle M Hall (khall) 2014-07-31 17:23:42 UTC Comment hidden (obsolete)
Comment 484 Kyle M Hall (khall) 2014-07-31 17:23:55 UTC Comment hidden (obsolete)
Comment 485 Kyle M Hall (khall) 2014-07-31 17:24:02 UTC Comment hidden (obsolete)
Comment 486 Kyle M Hall (khall) 2014-09-09 12:48:32 UTC Comment hidden (obsolete)
Comment 487 Kyle M Hall (khall) 2014-09-09 12:49:12 UTC Comment hidden (obsolete)
Comment 488 Kyle M Hall (khall) 2014-09-09 12:49:20 UTC Comment hidden (obsolete)
Comment 489 Kyle M Hall (khall) 2014-09-09 12:49:28 UTC Comment hidden (obsolete)
Comment 490 Kyle M Hall (khall) 2014-09-09 12:49:34 UTC Comment hidden (obsolete)
Comment 491 Kyle M Hall (khall) 2014-09-09 12:49:44 UTC Comment hidden (obsolete)
Comment 492 Kyle M Hall (khall) 2014-09-09 12:49:51 UTC Comment hidden (obsolete)
Comment 493 Kyle M Hall (khall) 2014-09-09 12:49:58 UTC Comment hidden (obsolete)
Comment 494 Kyle M Hall (khall) 2014-09-09 12:50:06 UTC Comment hidden (obsolete)
Comment 495 Kyle M Hall (khall) 2014-09-09 12:50:13 UTC Comment hidden (obsolete)
Comment 496 Kyle M Hall (khall) 2014-09-09 12:50:22 UTC Comment hidden (obsolete)
Comment 497 Kyle M Hall (khall) 2014-09-09 12:50:29 UTC Comment hidden (obsolete)
Comment 498 Kyle M Hall (khall) 2014-09-19 16:44:19 UTC Comment hidden (obsolete)
Comment 499 Kyle M Hall (khall) 2014-09-19 16:44:44 UTC Comment hidden (obsolete)
Comment 500 Kyle M Hall (khall) 2014-09-19 16:44:51 UTC Comment hidden (obsolete)
Comment 501 Kyle M Hall (khall) 2014-09-19 16:44:58 UTC Comment hidden (obsolete)
Comment 502 Kyle M Hall (khall) 2014-09-19 16:45:09 UTC Comment hidden (obsolete)
Comment 503 Kyle M Hall (khall) 2014-09-19 16:45:20 UTC Comment hidden (obsolete)
Comment 504 Kyle M Hall (khall) 2014-09-19 16:45:28 UTC Comment hidden (obsolete)
Comment 505 Kyle M Hall (khall) 2014-09-19 16:45:35 UTC Comment hidden (obsolete)
Comment 506 Kyle M Hall (khall) 2014-09-19 16:45:44 UTC Comment hidden (obsolete)
Comment 507 Kyle M Hall (khall) 2014-09-19 16:45:55 UTC Comment hidden (obsolete)
Comment 508 Kyle M Hall (khall) 2014-09-19 16:46:06 UTC Comment hidden (obsolete)
Comment 509 Kyle M Hall (khall) 2014-09-19 16:46:13 UTC Comment hidden (obsolete)
Comment 510 Kyle M Hall (khall) 2014-09-19 16:55:28 UTC Comment hidden (obsolete)
Comment 511 Kyle M Hall (khall) 2014-09-19 16:55:51 UTC Comment hidden (obsolete)
Comment 512 Kyle M Hall (khall) 2014-09-19 16:55:58 UTC Comment hidden (obsolete)
Comment 513 Kyle M Hall (khall) 2014-09-19 16:56:05 UTC Comment hidden (obsolete)
Comment 514 Kyle M Hall (khall) 2014-09-19 16:56:12 UTC Comment hidden (obsolete)
Comment 515 Kyle M Hall (khall) 2014-09-19 16:56:23 UTC Comment hidden (obsolete)
Comment 516 Kyle M Hall (khall) 2014-09-19 16:56:31 UTC Comment hidden (obsolete)
Comment 517 Kyle M Hall (khall) 2014-09-19 16:56:40 UTC Comment hidden (obsolete)
Comment 518 Kyle M Hall (khall) 2014-09-19 16:56:47 UTC Comment hidden (obsolete)
Comment 519 Kyle M Hall (khall) 2014-09-19 16:56:54 UTC Comment hidden (obsolete)
Comment 520 Kyle M Hall (khall) 2014-09-19 16:57:02 UTC Comment hidden (obsolete)
Comment 521 Kyle M Hall (khall) 2014-09-19 16:57:09 UTC Comment hidden (obsolete)
Comment 522 Olli-Antti Kivilahti 2014-10-08 13:15:06 UTC
Good work on this one Kyle!
I hope we get this to master some day!
Comment 523 Kyle M Hall (khall) 2014-10-17 12:39:20 UTC Comment hidden (obsolete)
Comment 524 Kyle M Hall (khall) 2014-10-17 12:39:35 UTC Comment hidden (obsolete)
Comment 525 Kyle M Hall (khall) 2014-10-17 12:39:42 UTC Comment hidden (obsolete)
Comment 526 Kyle M Hall (khall) 2014-10-17 12:39:49 UTC Comment hidden (obsolete)
Comment 527 Kyle M Hall (khall) 2014-10-17 12:39:56 UTC Comment hidden (obsolete)
Comment 528 Kyle M Hall (khall) 2014-10-17 12:40:06 UTC Comment hidden (obsolete)
Comment 529 Kyle M Hall (khall) 2014-10-17 12:40:14 UTC Comment hidden (obsolete)
Comment 530 Kyle M Hall (khall) 2014-10-17 12:40:21 UTC Comment hidden (obsolete)
Comment 531 Kyle M Hall (khall) 2014-10-17 12:40:29 UTC Comment hidden (obsolete)
Comment 532 Kyle M Hall (khall) 2014-10-17 12:40:36 UTC Comment hidden (obsolete)
Comment 533 Kyle M Hall (khall) 2014-10-17 12:40:44 UTC Comment hidden (obsolete)
Comment 534 Kyle M Hall (khall) 2014-10-17 12:40:51 UTC Comment hidden (obsolete)
Comment 535 Kyle M Hall (khall) 2014-10-22 18:55:29 UTC Comment hidden (obsolete)
Comment 536 Kyle M Hall (khall) 2014-10-22 18:55:46 UTC Comment hidden (obsolete)
Comment 537 Kyle M Hall (khall) 2014-10-22 18:55:54 UTC Comment hidden (obsolete)
Comment 538 Kyle M Hall (khall) 2014-10-22 18:56:02 UTC Comment hidden (obsolete)
Comment 539 Kyle M Hall (khall) 2014-10-22 18:56:11 UTC Comment hidden (obsolete)
Comment 540 Kyle M Hall (khall) 2014-10-22 18:56:20 UTC Comment hidden (obsolete)
Comment 541 Kyle M Hall (khall) 2014-10-22 18:56:29 UTC Comment hidden (obsolete)
Comment 542 Kyle M Hall (khall) 2014-10-22 18:56:36 UTC Comment hidden (obsolete)
Comment 543 Kyle M Hall (khall) 2014-10-22 18:56:43 UTC Comment hidden (obsolete)
Comment 544 Kyle M Hall (khall) 2014-10-22 18:56:51 UTC Comment hidden (obsolete)
Comment 545 Kyle M Hall (khall) 2014-10-22 18:56:58 UTC Comment hidden (obsolete)
Comment 546 Kyle M Hall (khall) 2014-10-22 18:57:07 UTC Comment hidden (obsolete)
Comment 547 Kyle M Hall (khall) 2014-10-28 14:47:08 UTC Comment hidden (obsolete)
Comment 548 Kyle M Hall (khall) 2014-10-28 14:47:24 UTC Comment hidden (obsolete)
Comment 549 Kyle M Hall (khall) 2014-10-28 14:47:32 UTC Comment hidden (obsolete)
Comment 550 Kyle M Hall (khall) 2014-10-28 14:47:39 UTC Comment hidden (obsolete)
Comment 551 Kyle M Hall (khall) 2014-10-28 14:47:46 UTC Comment hidden (obsolete)
Comment 552 Kyle M Hall (khall) 2014-10-28 14:47:56 UTC Comment hidden (obsolete)
Comment 553 Kyle M Hall (khall) 2014-10-28 14:48:06 UTC Comment hidden (obsolete)
Comment 554 Kyle M Hall (khall) 2014-10-28 14:48:15 UTC Comment hidden (obsolete)
Comment 555 Kyle M Hall (khall) 2014-10-28 14:48:22 UTC Comment hidden (obsolete)
Comment 556 Kyle M Hall (khall) 2014-10-28 14:48:29 UTC Comment hidden (obsolete)
Comment 557 Kyle M Hall (khall) 2014-10-28 14:48:38 UTC Comment hidden (obsolete)
Comment 558 Kyle M Hall (khall) 2014-10-28 14:48:46 UTC Comment hidden (obsolete)
Comment 559 Kyle M Hall (khall) 2014-11-05 16:07:53 UTC Comment hidden (obsolete)
Comment 560 Kyle M Hall (khall) 2014-11-05 16:08:10 UTC Comment hidden (obsolete)
Comment 561 Kyle M Hall (khall) 2014-11-05 16:08:18 UTC Comment hidden (obsolete)
Comment 562 Kyle M Hall (khall) 2014-11-05 16:08:26 UTC Comment hidden (obsolete)
Comment 563 Kyle M Hall (khall) 2014-11-05 16:08:34 UTC Comment hidden (obsolete)
Comment 564 Kyle M Hall (khall) 2014-11-05 16:08:44 UTC Comment hidden (obsolete)
Comment 565 Kyle M Hall (khall) 2014-11-05 16:08:52 UTC Comment hidden (obsolete)
Comment 566 Kyle M Hall (khall) 2014-11-05 16:09:00 UTC Comment hidden (obsolete)
Comment 567 Kyle M Hall (khall) 2014-11-05 16:09:08 UTC Comment hidden (obsolete)
Comment 568 Kyle M Hall (khall) 2014-11-05 16:09:16 UTC Comment hidden (obsolete)
Comment 569 Kyle M Hall (khall) 2014-11-05 16:09:24 UTC Comment hidden (obsolete)
Comment 570 Kyle M Hall (khall) 2014-11-05 16:09:31 UTC Comment hidden (obsolete)
Comment 571 Kyle M Hall (khall) 2014-12-03 17:59:01 UTC Comment hidden (obsolete)
Comment 572 Kyle M Hall (khall) 2014-12-03 17:59:17 UTC Comment hidden (obsolete)
Comment 573 Kyle M Hall (khall) 2014-12-03 17:59:24 UTC Comment hidden (obsolete)
Comment 574 Kyle M Hall (khall) 2014-12-03 17:59:32 UTC Comment hidden (obsolete)
Comment 575 Kyle M Hall (khall) 2014-12-03 17:59:39 UTC Comment hidden (obsolete)
Comment 576 Kyle M Hall (khall) 2014-12-03 17:59:49 UTC Comment hidden (obsolete)
Comment 577 Kyle M Hall (khall) 2014-12-03 17:59:56 UTC Comment hidden (obsolete)
Comment 578 Kyle M Hall (khall) 2014-12-03 18:00:05 UTC Comment hidden (obsolete)
Comment 579 Kyle M Hall (khall) 2014-12-03 18:00:13 UTC Comment hidden (obsolete)
Comment 580 Kyle M Hall (khall) 2014-12-03 18:00:21 UTC Comment hidden (obsolete)
Comment 581 Kyle M Hall (khall) 2014-12-03 18:00:29 UTC Comment hidden (obsolete)
Comment 582 Kyle M Hall (khall) 2014-12-03 18:00:37 UTC Comment hidden (obsolete)
Comment 583 Jonathan Druart 2014-12-04 14:36:42 UTC
Super quick look:
1/ TableTool: Could you explain what is the goal of this plugin (I just have seen a (+) with a 'print receipt' button)? All the files included are needed (html?)

2/ It seems that some tests are missing (AddIssue and AddReturn for instance)

3/ Is this patch set introduced changes compared to master or it's just a rewrite?

4/ What's the interest of splitting pl in 2 files (*_go.pl)? I am really not sure it's useful.

(The updatedatabase.pl changes are not at the right place (not at the end))
Comment 584 Kyle M Hall (khall) 2014-12-09 13:00:16 UTC Comment hidden (obsolete)
Comment 585 Kyle M Hall (khall) 2014-12-09 13:00:42 UTC Comment hidden (obsolete)
Comment 586 Kyle M Hall (khall) 2014-12-09 13:00:50 UTC Comment hidden (obsolete)
Comment 587 Kyle M Hall (khall) 2014-12-09 13:00:59 UTC Comment hidden (obsolete)
Comment 588 Kyle M Hall (khall) 2014-12-09 13:01:08 UTC Comment hidden (obsolete)
Comment 589 Kyle M Hall (khall) 2014-12-09 13:01:19 UTC Comment hidden (obsolete)
Comment 590 Kyle M Hall (khall) 2014-12-09 13:01:27 UTC Comment hidden (obsolete)
Comment 591 Kyle M Hall (khall) 2014-12-09 13:01:35 UTC Comment hidden (obsolete)
Comment 592 Kyle M Hall (khall) 2014-12-09 13:01:43 UTC Comment hidden (obsolete)
Comment 593 Kyle M Hall (khall) 2014-12-09 13:01:51 UTC Comment hidden (obsolete)
Comment 594 Kyle M Hall (khall) 2014-12-09 13:02:00 UTC Comment hidden (obsolete)
Comment 595 Kyle M Hall (khall) 2014-12-09 13:02:09 UTC Comment hidden (obsolete)
Comment 596 Martin Renvoize (ashimema) 2014-12-15 20:48:56 UTC
Is this re-write meant to deprecate the 'accountlines' table?  If so, there are still a few references to it that I can see... and the table is still present after the updatedb run:

1) C4/Reports/Guided.pm
2) C4/Overdues.pm
3) offline_circ/download.pl

And a few tests ;)

1) /db_dependent/Circulation_Branch.t
2) /db_dependent/Members.t
3) /db_dependent/Circulation_issue.t
Comment 597 Martin Renvoize (ashimema) 2014-12-16 06:32:43 UTC
Comment on attachment 34204 [details] [review]
Bug 6427 - Update database

Review of attachment 34204 [details] [review]:
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +9709,5 @@
> +        'W'   => Koha::Accounts::CreditTypes::WriteOff,
> +        'C'   => Koha::Accounts::CreditTypes::Credit,
> +        'CR'  => Koha::Accounts::CreditTypes::Credit,
> +    };
> +

Should there be any additional handling for existing authorised values for types here... ?

@@ +9767,5 @@
> +                }
> +            );
> +        }
> +    }
> +

Should there also be a 'DROP TABLE accountlines' somewhere in here...?
Comment 598 Martin Renvoize (ashimema) 2014-12-16 09:26:07 UTC
The installer wizard currently gives the below error with these patches: 

ERROR 1064 (42000) at line 3466: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'account_credits ( credit_id int(11) NOT NULL AUTO_INCREMENT, borrow' at line 1
Comment 599 Martin Renvoize (ashimema) 2014-12-30 10:20:10 UTC
Testing feedback spreadsheet available at: https://docs.google.com/a/ptfs-europe.com/spreadsheets/d/1EcBAPmPAF0L95uYxWtRcnV9n1sD78IAxTHW2N-9u2K0/edit#gid=0
Comment 600 Kyle M Hall (khall) 2015-01-14 15:09:07 UTC Comment hidden (obsolete)
Comment 601 Kyle M Hall (khall) 2015-01-14 15:09:28 UTC Comment hidden (obsolete)
Comment 602 Kyle M Hall (khall) 2015-01-14 15:09:36 UTC Comment hidden (obsolete)
Comment 603 Kyle M Hall (khall) 2015-01-14 15:09:44 UTC Comment hidden (obsolete)
Comment 604 Kyle M Hall (khall) 2015-01-14 15:09:52 UTC Comment hidden (obsolete)
Comment 605 Kyle M Hall (khall) 2015-01-14 15:10:03 UTC Comment hidden (obsolete)
Comment 606 Kyle M Hall (khall) 2015-01-14 15:10:12 UTC Comment hidden (obsolete)
Comment 607 Kyle M Hall (khall) 2015-01-14 15:10:21 UTC Comment hidden (obsolete)
Comment 608 Kyle M Hall (khall) 2015-01-14 15:10:29 UTC Comment hidden (obsolete)
Comment 609 Kyle M Hall (khall) 2015-01-14 15:10:37 UTC Comment hidden (obsolete)
Comment 610 Kyle M Hall (khall) 2015-01-14 15:10:45 UTC Comment hidden (obsolete)
Comment 611 Kyle M Hall (khall) 2015-01-14 15:10:54 UTC Comment hidden (obsolete)
Comment 612 Kyle M Hall (khall) 2015-01-14 15:11:02 UTC Comment hidden (obsolete)
Comment 613 Kyle M Hall (khall) 2015-01-15 12:33:52 UTC Comment hidden (obsolete)
Comment 614 Katrin Fischer 2015-02-11 15:25:59 UTC
I'd really like to see some testing notes about this feature with the sign-off. This is huge and no library uses all features.
Comment 615 Jonathan Druart 2015-02-26 15:25:14 UTC
Applying: Bug 6427 - Update existing Koha perl modules
CONFLICT (content): Merge conflict in C4/SIP/ILS/Transaction/FeePayment.pm
CONFLICT (content): Merge conflict in C4/Reserves.pm
Comment 616 Martin Renvoize (ashimema) 2015-02-27 10:43:14 UTC
I don't see how this got to a signed off state, a large part of the testing spreadsheet recording test results shows half of it is untested.

I know when I tested it, I found all sorts of issues with display on the staff client.

I also found issues with the code when delving into it to try and fix said bugs, I'd love to see a good comprehensive re-write of accounts, but this code shows that it was written some time ago and I don't believe it actually improved matters.

PTFS Europe spent a fair chunk of time attempting to get this in shape for passing through community so we could base our Cash Management work upon it, but we didn't even complete testing before we realised how difficult it would be to extend/enhance it further.

I also found that too much changed in this one bug.. The db backend and th display both change dramatically, which means doing a side by side comparison to check that the db update it actually catching everything is near impossible.

Martin
Comment 617 Martin Renvoize (ashimema) 2015-02-27 10:45:24 UTC
Further to the above, when I attempted to lookup the original RFC for this, it does not remotely resemble the actually work, further confusing testing.

Please don't see this as completely negative.. I just feel things have moved on allot since this patch was written.. and that the way in which it has been posted as one massive bug is unmanageable for both testers and qa team.

I have a alternative schema I'd love to post as a counter patch.. but that all depends upon having a moment to get to it.
Comment 618 Martin Renvoize (ashimema) 2015-02-27 10:45:33 UTC
Further to the above, when I attempted to lookup the original RFC for this, it does not remotely resemble the actually work, further confusing testing.

Please don't see this as completely negative.. I just feel things have moved on allot since this patch was written.. and that the way in which it has been posted as one massive bug is unmanageable for both testers and qa team.

I have a alternative schema I'd love to post as a counter patch.. but that all depends upon having a moment to get to it.
Comment 619 Kyle M Hall (khall) 2015-03-02 14:59:37 UTC
I must disagree. This work closely resembles the original RFC some table and column name changes, as well as a few additions.

I've spend countless hours to track this feature against master. Nothing has moved on. It has simply been a lack of persons willing to test and qa this feature that has been the problem so far.

(In reply to Martin Renvoize from comment #618)
> Further to the above, when I attempted to lookup the original RFC for this,
> it does not remotely resemble the actually work, further confusing testing.
> 
> Please don't see this as completely negative.. I just feel things have moved
> on allot since this patch was written.. and that the way in which it has
> been posted as one massive bug is unmanageable for both testers and qa team.
> 
> I have a alternative schema I'd love to post as a counter patch.. but that
> all depends upon having a moment to get to it.
Comment 620 Nicole C. Engard 2015-03-02 15:06:01 UTC
I'd like to add that 2 libraries are using it in production and have given their sign off to the features. They are not having issues with anything - and since we're talking money related issues you'd expect a lot of screaming if there were issues.

Nicole
Comment 621 Sean McGarvey 2015-03-02 15:27:03 UTC
I think i can help out here, Pasco County Library system has been using this patch in production for almost an entire year. We've tested pretty much every way this upgrade works and have made a lot of improvements. We've even found new and interesting ways to break things that no one but a patron could have thought of. Just to confirm I even stepped out to talk to my head of finance who agreed that the system is solid and is functioning as described. We've had 7 libraries using it 5 days a week. At this point human error is what is causing the vast majority of our problems. When this is live in master we hope that other libraries can help us make more tweaks.  

I can confirm that the system is tested and functioning. Had it not been our county clerk would have made it perfectly clear. If there are individual questions about aspects ill try and answer them as best i can regarding actual function in the library.
Comment 622 Kyle M Hall (khall) 2015-03-02 15:50:39 UTC Comment hidden (obsolete)
Comment 623 Kyle M Hall (khall) 2015-03-02 15:52:42 UTC Comment hidden (obsolete)
Comment 624 Kyle M Hall (khall) 2015-03-02 15:53:05 UTC Comment hidden (obsolete)
Comment 625 Kyle M Hall (khall) 2015-03-02 15:53:33 UTC Comment hidden (obsolete)
Comment 626 Kyle M Hall (khall) 2015-03-02 15:53:58 UTC Comment hidden (obsolete)
Comment 627 Kyle M Hall (khall) 2015-03-02 15:54:21 UTC Comment hidden (obsolete)
Comment 628 Kyle M Hall (khall) 2015-03-02 15:54:44 UTC Comment hidden (obsolete)
Comment 629 Kyle M Hall (khall) 2015-03-02 15:55:26 UTC Comment hidden (obsolete)
Comment 630 Kyle M Hall (khall) 2015-03-02 15:56:12 UTC Comment hidden (obsolete)
Comment 631 Kyle M Hall (khall) 2015-03-02 15:56:32 UTC Comment hidden (obsolete)
Comment 632 Kyle M Hall (khall) 2015-03-02 15:57:36 UTC Comment hidden (obsolete)
Comment 633 Kyle M Hall (khall) 2015-03-02 15:58:47 UTC Comment hidden (obsolete)
Comment 634 Kyle M Hall (khall) 2015-03-02 15:59:23 UTC Comment hidden (obsolete)
Comment 635 Kyle M Hall (khall) 2015-03-02 16:00:05 UTC Comment hidden (obsolete)
Comment 636 Chris Cormack 2015-03-02 17:55:32 UTC
(In reply to Kyle M Hall from comment #619)
> I must disagree. This work closely resembles the original RFC some table and
> column name changes, as well as a few additions.
> 
> I've spend countless hours to track this feature against master. Nothing has
> moved on. It has simply been a lack of persons willing to test and qa this
> feature that has been the problem so far.
> 
Hmmm, Martin and others have spent hours trying to QA this. They found problems, they reported them in the spreadsheet. Have you read through the spreadsheet?
Or the comment proceeding the one you replied to?

I find it quite insulting you just dismiss their findings, and blame them instead.
Comment 637 Sherry Sakovich 2015-03-02 19:07:52 UTC
Here at Huntsville-Madison County Public Library, we've been using the accounts re-write in production since we went live on Koha a year ago.  We absolutely love the granularity this feature allows for payment types and reporting.  As a public library, our city/county auditors strictly require this type of detailed information.  Also, as a 12 branch county-wide library system, we're able to make better decisions as we now have better accounting.  Finally, our patrons really appreciate that our system tracks what they've paid for and by what method.
Comment 638 Aaron Sakovich 2015-03-02 19:37:07 UTC
As Sherry said, we at HMCPL have been using this code in production for a whole year. We have tested this exhaustively, on both 3.14 and 3.16, during that period. And by "we", I mean a 12 branch library system open 7 days a week, with well over 2 million items circulated in that time, exclusively using this code.
The current code base is functioning nominally, and even relatively gracefully handled the upgrade from 3.14 to 3.16, as well as multiple patches since.
We've no outstanding bugs logged against this current version of the code on our internal nor ByWater's ticketing systems. This current piece of kit is rock solid and well tested; it is well beyond the beta stage that we started with a year ago, and I humbly suggest that it is suitably ready for production.
Comment 639 Brendan Gallagher 2015-03-02 21:30:44 UTC
(In reply to Chris Cormack from comment #636)
> (In reply to Kyle M Hall from comment #619)
> > I must disagree. This work closely resembles the original RFC some table and
> > column name changes, as well as a few additions.
> > 
> > I've spend countless hours to track this feature against master. Nothing has
> > moved on. It has simply been a lack of persons willing to test and qa this
> > feature that has been the problem so far.
> > 
> Hmmm, Martin and others have spent hours trying to QA this. They found
> problems, they reported them in the spreadsheet. Have you read through the
> spreadsheet?
> Or the comment proceeding the one you replied to?
> 
> I find it quite insulting you just dismiss their findings, and blame them
> instead.

Hi All - 

Please let's not read any tone into any message.  We are all friends here and we speak many different languages - I am at fault for using the wrong word with Katrin (someone that I would go to battle for and have the most respect for).  

So that being said.  I think Kyle needs to know how to work with this "BIG IDEA" of the accounts rewrite and work with everyone - from the most experienced (Tomas and Jonathan) to the most experienced me (Brendan).  

It may take 10 times of telling us to change certain things - but we are more than will to work with anyone of you all - to make those changes.  Tempers fly - and I say that is lost in translation.  

ok - how to change this.   Well we are going to sit down with Katrin, Tomas, Jonathan, and hopefully Martin (on google hangouts), and talk about what needs to be changed and how to submit the patches so that it works for everyone.  

Please remember that all of us - LOVE LOVE LOVE to be part of this community - and all we ever want is to be part of this community.  many things are lost in translation - if you need proof - just ask Paul about baseball.  

Seriously - all we want is to show that we've got so good code and we totally realize that we need tons of help to get it in.

Tons of Respect,
Brendan Gallagher
Comment 640 Brendan Gallagher 2015-03-02 21:32:42 UTC
(In reply to Brendan Gallagher from comment #639)
> (In reply to Chris Cormack from comment #636)
> > (In reply to Kyle M Hall from comment #619)
> > > I must disagree. This work closely resembles the original RFC some table and
> > > column name changes, as well as a few additions.
> > > 
> > > I've spend countless hours to track this feature against master. Nothing has
> > > moved on. It has simply been a lack of persons willing to test and qa this
> > > feature that has been the problem so far.
> > > 
> > Hmmm, Martin and others have spent hours trying to QA this. They found
> > problems, they reported them in the spreadsheet. Have you read through the
> > spreadsheet?
> > Or the comment proceeding the one you replied to?
> > 
> > I find it quite insulting you just dismiss their findings, and blame them
> > instead.
> 
> Hi All - 
> 
> Please let's not read any tone into any message.  We are all friends here
> and we speak many different languages - I am at fault for using the wrong
> word with Katrin (someone that I would go to battle for and have the most
> respect for).  
That should be the most INexperienced me (bag)  darn typos 

> 
> So that being said.  I think Kyle needs to know how to work with this "BIG
> IDEA" of the accounts rewrite and work with everyone - from the most
> experienced (Tomas and Jonathan) to the most experienced me (Brendan).  
> 
> It may take 10 times of telling us to change certain things - but we are
> more than will to work with anyone of you all - to make those changes. 
> Tempers fly - and I say that is lost in translation.  
> 
> ok - how to change this.   Well we are going to sit down with Katrin, Tomas,
> Jonathan, and hopefully Martin (on google hangouts), and talk about what
> needs to be changed and how to submit the patches so that it works for
> everyone.  
> 
> Please remember that all of us - LOVE LOVE LOVE to be part of this community
> - and all we ever want is to be part of this community.  many things are
> lost in translation - if you need proof - just ask Paul about baseball.  
> 
> Seriously - all we want is to show that we've got so good code and we
> totally realize that we need tons of help to get it in.
> 
> Tons of Respect,
> Brendan Gallagher
Comment 641 Kyle M Hall (khall) 2015-03-02 23:18:41 UTC
(In reply to Martin Renvoize from comment #616)
> I don't see how this got to a signed off state, a large part of the testing
> spreadsheet recording test results shows half of it is untested.

The signer was an independent tester.

> I know when I tested it, I found all sorts of issues with display on the
> staff client.

Please let me know what those issue are!

> I also found issues with the code when delving into it to try and fix said
> bugs, I'd love to see a good comprehensive re-write of accounts, but this
> code shows that it was written some time ago and I don't believe it actually
> improved matters.

Again, pleases let me know what these bugs are!

I believe that this feature improves matters very much. The partners that have been testing this have been able to do far more advanced reporting on fees and payments than is possible with our current schema. I don't see how it *doesn't* improve matters!

> 
> PTFS Europe spent a fair chunk of time attempting to get this in shape for
> passing through community so we could base our Cash Management work upon it,
> but we didn't even complete testing before we realised how difficult it
> would be to extend/enhance it further.

I can understand that you want to add a new feature to Koha, and this feature is making it more difficult for you. I've been in the same situation. However, I don't think that's reasonable justification for tossing it out.

If you can outline what parts of this are limiting for you, and how I can help resolve this, I would be more than happy to! Have you posted an RFC for your Cash Management feature?
Comment 642 Kyle M Hall (khall) 2015-03-03 10:34:48 UTC Comment hidden (obsolete)
Comment 643 Kyle M Hall (khall) 2015-03-03 11:12:13 UTC Comment hidden (obsolete)
Comment 644 Kyle M Hall (khall) 2015-03-03 11:19:09 UTC Comment hidden (obsolete)
Comment 645 Kyle M Hall (khall) 2015-03-23 15:12:06 UTC Comment hidden (obsolete)
Comment 646 Kyle M Hall (khall) 2015-03-23 15:12:21 UTC Comment hidden (obsolete)
Comment 647 Kyle M Hall (khall) 2015-03-23 15:12:30 UTC Comment hidden (obsolete)
Comment 648 Kyle M Hall (khall) 2015-03-23 15:12:38 UTC Comment hidden (obsolete)
Comment 649 Kyle M Hall (khall) 2015-03-23 15:12:46 UTC Comment hidden (obsolete)
Comment 650 Kyle M Hall (khall) 2015-03-23 15:12:57 UTC Comment hidden (obsolete)
Comment 651 Kyle M Hall (khall) 2015-03-23 15:13:07 UTC Comment hidden (obsolete)
Comment 652 Kyle M Hall (khall) 2015-03-23 15:13:15 UTC Comment hidden (obsolete)
Comment 653 Kyle M Hall (khall) 2015-03-23 15:13:23 UTC Comment hidden (obsolete)
Comment 654 Kyle M Hall (khall) 2015-03-23 15:13:31 UTC Comment hidden (obsolete)
Comment 655 Kyle M Hall (khall) 2015-03-23 15:13:40 UTC Comment hidden (obsolete)
Comment 656 Kyle M Hall (khall) 2015-03-23 15:13:48 UTC Comment hidden (obsolete)
Comment 657 Kyle M Hall (khall) 2015-03-23 15:13:56 UTC Comment hidden (obsolete)
Comment 658 Kyle M Hall (khall) 2015-03-23 15:14:04 UTC Comment hidden (obsolete)
Comment 659 Kyle M Hall (khall) 2015-03-23 15:14:12 UTC Comment hidden (obsolete)
Comment 660 Kyle M Hall (khall) 2015-03-23 15:14:20 UTC Comment hidden (obsolete)
Comment 661 Kyle M Hall (khall) 2015-03-23 17:42:15 UTC Comment hidden (obsolete)
Comment 662 Kyle M Hall (khall) 2015-03-23 17:42:48 UTC Comment hidden (obsolete)
Comment 663 Kyle M Hall (khall) 2015-03-23 17:42:56 UTC Comment hidden (obsolete)
Comment 664 Kyle M Hall (khall) 2015-03-23 17:43:04 UTC Comment hidden (obsolete)
Comment 665 Kyle M Hall (khall) 2015-03-23 17:43:12 UTC Comment hidden (obsolete)
Comment 666 Kyle M Hall (khall) 2015-03-23 17:43:22 UTC Comment hidden (obsolete)
Comment 667 Kyle M Hall (khall) 2015-03-23 17:43:31 UTC Comment hidden (obsolete)
Comment 668 Kyle M Hall (khall) 2015-03-23 17:43:39 UTC Comment hidden (obsolete)
Comment 669 Kyle M Hall (khall) 2015-03-23 17:43:47 UTC Comment hidden (obsolete)
Comment 670 Kyle M Hall (khall) 2015-03-23 17:43:55 UTC Comment hidden (obsolete)
Comment 671 Kyle M Hall (khall) 2015-03-23 17:44:04 UTC Comment hidden (obsolete)
Comment 672 Kyle M Hall (khall) 2015-03-23 17:44:13 UTC Comment hidden (obsolete)
Comment 673 Kyle M Hall (khall) 2015-03-23 17:44:20 UTC Comment hidden (obsolete)
Comment 674 Kyle M Hall (khall) 2015-03-23 17:44:29 UTC Comment hidden (obsolete)
Comment 675 Kyle M Hall (khall) 2015-03-23 17:44:37 UTC Comment hidden (obsolete)
Comment 676 Kyle M Hall (khall) 2015-03-23 17:44:45 UTC Comment hidden (obsolete)
Comment 677 Kyle M Hall (khall) 2015-03-25 18:52:12 UTC Comment hidden (obsolete)
Comment 678 Kyle M Hall (khall) 2015-03-25 18:52:33 UTC Comment hidden (obsolete)
Comment 679 Kyle M Hall (khall) 2015-03-25 18:52:41 UTC Comment hidden (obsolete)
Comment 680 Kyle M Hall (khall) 2015-03-25 18:52:50 UTC Comment hidden (obsolete)
Comment 681 Kyle M Hall (khall) 2015-03-25 18:52:58 UTC Comment hidden (obsolete)
Comment 682 Kyle M Hall (khall) 2015-03-25 18:53:09 UTC Comment hidden (obsolete)
Comment 683 Kyle M Hall (khall) 2015-03-25 18:53:18 UTC Comment hidden (obsolete)
Comment 684 Kyle M Hall (khall) 2015-03-25 18:53:26 UTC Comment hidden (obsolete)
Comment 685 Kyle M Hall (khall) 2015-03-25 18:53:35 UTC Comment hidden (obsolete)
Comment 686 Kyle M Hall (khall) 2015-03-25 18:53:43 UTC Comment hidden (obsolete)
Comment 687 Kyle M Hall (khall) 2015-03-25 18:53:52 UTC Comment hidden (obsolete)
Comment 688 Kyle M Hall (khall) 2015-03-25 18:54:00 UTC Comment hidden (obsolete)
Comment 689 Kyle M Hall (khall) 2015-03-25 18:54:08 UTC Comment hidden (obsolete)
Comment 690 Kyle M Hall (khall) 2015-03-25 18:54:17 UTC Comment hidden (obsolete)
Comment 691 Kyle M Hall (khall) 2015-03-25 18:54:25 UTC Comment hidden (obsolete)
Comment 692 Kyle M Hall (khall) 2015-03-25 18:54:33 UTC Comment hidden (obsolete)
Comment 693 Josef Moravec 2015-03-28 08:27:18 UTC
I tried this by creating new instance, but web installer presented an SQL error when creating db structure:

ERROR 1064 (42000) at line 3484: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'account_credits ( credit_id int(11) NOT NULL AUTO_INCREMENT, borrow' at line 1 


I think the problem is on this line in kohastructure.sql:

3484 CREATE TABLE IF account_credits (
Comment 694 Josef Moravec 2015-03-28 08:51:03 UTC
I think that account_credits table should have foreign key to account_debits.debit_id, without this key, it´s impossible to group payments by fee type in reports. 

But this work is almost done, so it may be the best approach to open new bug for this enhancement...
Comment 695 Josef Moravec 2015-03-30 05:24:32 UTC
(In reply to Josef Moravec from comment #694)
> I think that account_credits table should have foreign key to
> account_debits.debit_id, without this key, it´s impossible to group payments
> by fee type in reports. 
> 
> But this work is almost done, so it may be the best approach to open new bug
> for this enhancement...

I am sorry, I just missed the table account_offsets...
Comment 696 Jeremy Wellner 2015-04-17 21:02:08 UTC
With Stanwood-Camano School District our textbook libraries really need this functionality to the point that we will offer to have this move onto our production server for more testing.

Fines are a big deal for us as it prevents 12th graders from being allowed to graduate.

What can we do to help this along further?
Comment 697 Katrin Fischer 2015-04-17 21:12:05 UTC
There have been some commnts that need to be addressed - I am switching to failed QA for the moment.
Comment 698 Kyle M Hall (khall) 2015-04-21 13:37:38 UTC Comment hidden (obsolete)
Comment 699 Kyle M Hall (khall) 2015-04-21 13:37:59 UTC Comment hidden (obsolete)
Comment 700 Kyle M Hall (khall) 2015-04-21 13:38:08 UTC Comment hidden (obsolete)
Comment 701 Kyle M Hall (khall) 2015-04-21 13:38:18 UTC Comment hidden (obsolete)
Comment 702 Kyle M Hall (khall) 2015-04-21 13:38:26 UTC Comment hidden (obsolete)
Comment 703 Kyle M Hall (khall) 2015-04-21 13:38:36 UTC Comment hidden (obsolete)
Comment 704 Kyle M Hall (khall) 2015-04-21 13:38:45 UTC Comment hidden (obsolete)
Comment 705 Kyle M Hall (khall) 2015-04-21 13:38:56 UTC Comment hidden (obsolete)
Comment 706 Kyle M Hall (khall) 2015-04-21 13:39:06 UTC Comment hidden (obsolete)
Comment 707 Kyle M Hall (khall) 2015-04-21 13:39:15 UTC Comment hidden (obsolete)
Comment 708 Kyle M Hall (khall) 2015-04-21 13:39:24 UTC Comment hidden (obsolete)
Comment 709 Kyle M Hall (khall) 2015-04-21 13:39:33 UTC Comment hidden (obsolete)
Comment 710 Kyle M Hall (khall) 2015-04-21 13:39:43 UTC Comment hidden (obsolete)
Comment 711 Kyle M Hall (khall) 2015-04-21 13:39:53 UTC Comment hidden (obsolete)
Comment 712 Kyle M Hall (khall) 2015-04-21 13:40:03 UTC Comment hidden (obsolete)
Comment 713 Kyle M Hall (khall) 2015-04-21 13:40:14 UTC Comment hidden (obsolete)
Comment 714 Kyle M Hall (khall) 2015-05-12 12:03:12 UTC Comment hidden (obsolete)
Comment 715 Kyle M Hall (khall) 2015-05-12 12:03:29 UTC Comment hidden (obsolete)
Comment 716 Kyle M Hall (khall) 2015-05-12 12:03:38 UTC Comment hidden (obsolete)
Comment 717 Kyle M Hall (khall) 2015-05-12 12:03:47 UTC Comment hidden (obsolete)
Comment 718 Kyle M Hall (khall) 2015-05-12 12:03:56 UTC Comment hidden (obsolete)
Comment 719 Kyle M Hall (khall) 2015-05-12 12:04:05 UTC Comment hidden (obsolete)
Comment 720 Kyle M Hall (khall) 2015-05-12 12:04:14 UTC Comment hidden (obsolete)
Comment 721 Kyle M Hall (khall) 2015-05-12 12:04:22 UTC Comment hidden (obsolete)
Comment 722 Kyle M Hall (khall) 2015-05-12 12:04:31 UTC Comment hidden (obsolete)
Comment 723 Kyle M Hall (khall) 2015-05-12 12:04:40 UTC Comment hidden (obsolete)
Comment 724 Kyle M Hall (khall) 2015-05-12 12:04:49 UTC Comment hidden (obsolete)
Comment 725 Kyle M Hall (khall) 2015-05-12 12:04:58 UTC Comment hidden (obsolete)
Comment 726 Kyle M Hall (khall) 2015-05-12 12:05:08 UTC Comment hidden (obsolete)
Comment 727 Kyle M Hall (khall) 2015-05-12 12:05:17 UTC Comment hidden (obsolete)
Comment 728 Kyle M Hall (khall) 2015-05-12 12:05:26 UTC Comment hidden (obsolete)
Comment 729 Kyle M Hall (khall) 2015-05-12 12:05:35 UTC Comment hidden (obsolete)
Comment 730 Kyle M Hall (khall) 2015-05-29 11:33:45 UTC
Created attachment 39671 [details] [review]
Bug 6427 - Update database

This patch set re-engineers Koha's accounting system to be faster, more
stable, and have a better historical accounting of fees and payments
while also unifying much of the payment logic and simplifying the code
behind it.

Three new tables have been created:
account_debits stores fines and fees owed by the patron.

account_credits stores payments, write-offs, and other line items that
reduce the amount owed by a patron.

account_offsets stores data about changes to debits and credits,
including which credits paid which debits.

borrowers.account_balance stores the current balance of the
patron, so it does not have to be calculated each time it needs to be
displayed.

issues.issue_id has been added so that individual fines can be directly
linked to the issue that caused them without ambiguity.

The various accounting code strings ( F, FU, Rent, etc ), some of which
have little or no documentation have been replaced by what enumerated
data types which are documented via POD.
There are three, one for each of Debits ( fees/fines ), Credits ( payments ),
and Offsets.

The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT )
while additionally allowing custom payment types ( MANUAL_CREDIT ).

The system also allows for overpayment, the the outstanding credit being
applied to future fees as they are created.

The system also allows for a librarian to accept a different amount of
money than what is to be paid, and will calculate the change to be
given.

Test Plan:
1) Apply this patch
2) Create some manual fees
3) Test the fee payments
   * Pay one fee
   * Pay multiple fees
   * Make a partial payment
   * Write off a fee
4) View the fees/payments, verify they are correct
5) Check out some items as overdue that should have fines
6) Run fines.pl, verify fines were generated
7) Pay on an accruing fine
8) Run fines.pl again, verify the fine hasn't changed
9) Increase the daily fine in issuing rules
10) Run fines.pl again, verify the fine has increased
11) Decrease the daily fine in issuing rules
12) Run fines.pl again, verify the fine has decreased
13) Test dropbox mode
14) Test WhenLostChargeReplacementFee both ways
15) Test RefundLostItemFeeOnReturn both ways
16) Test WhenLostForgiveFine both ways
17) Test CalculateFinesOnReturn both ways

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 731 Kyle M Hall (khall) 2015-05-29 11:34:02 UTC
Created attachment 39672 [details] [review]
Bug 6427 - Update schema files

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 732 Kyle M Hall (khall) 2015-05-29 11:34:12 UTC
Created attachment 39673 [details] [review]
Bug 6427 - Add new Accounts related Koha modules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 733 Kyle M Hall (khall) 2015-05-29 11:34:21 UTC
Created attachment 39674 [details] [review]
Bug 6427 - Update existing Koha perl modules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 734 Kyle M Hall (khall) 2015-05-29 11:34:30 UTC
Created attachment 39675 [details] [review]
Bug 6427 - Add new TT plugin to deal with currency

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 735 Kyle M Hall (khall) 2015-05-29 11:34:40 UTC
Created attachment 39676 [details] [review]
Bug 6427 - Add new staff scripts for managing accounts

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 736 Kyle M Hall (khall) 2015-05-29 11:34:49 UTC
Created attachment 39677 [details] [review]
Bug 6427 - Update existing intranet scripts

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 737 Kyle M Hall (khall) 2015-05-29 11:34:57 UTC
Created attachment 39678 [details] [review]
Bug 6427 - Update OPAC scripts

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 738 Kyle M Hall (khall) 2015-05-29 11:35:07 UTC
Created attachment 39679 [details] [review]
Bug 6427 - Add & update cron scripts

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 739 Kyle M Hall (khall) 2015-05-29 11:35:17 UTC
Created attachment 39680 [details] [review]
Bug 6427 - Delete unused and unnecessary files

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 740 Kyle M Hall (khall) 2015-05-29 11:35:27 UTC
Created attachment 39681 [details] [review]
Bug 6427 - Unit Tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 741 Kyle M Hall (khall) 2015-05-29 11:35:36 UTC
Created attachment 39682 [details] [review]
Bug 6427 - Make fines tabs link to account payment page

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Sean McGarvey <seanm@pascolibraries.org>
Comment 742 Kyle M Hall (khall) 2015-05-29 11:35:44 UTC
Created attachment 39683 [details] [review]
Bug 6427 [QA Followup] - Improvements to OPAC view
Comment 743 Kyle M Hall (khall) 2015-05-29 11:35:53 UTC
Created attachment 39684 [details] [review]
Bug 6427 [QA Followup] - Fix accounts table default sorting
Comment 744 Kyle M Hall (khall) 2015-05-29 11:36:02 UTC
Created attachment 39685 [details] [review]
Bug 6427 [QA Followup] - Drop old accounts tables
Comment 745 Kyle M Hall (khall) 2015-05-29 11:36:11 UTC
Created attachment 39686 [details] [review]
Bug 6427 [QA Followup] - Fix kohastructure.sql
Comment 746 Katrin Fischer 2015-10-18 14:58:42 UTC
Hi Kyle, 

not sure about the dependency on 13790 - maybe this should be blocked by it and not the other way around (might have made a mistake there)? Also I saw you split of some patches for a more granular approach - what shall we do here?

Patch currently doesn't apply - so choosing that for now.
Comment 747 Kyle M Hall 2015-10-19 13:26:56 UTC

*** This bug has been marked as a duplicate of bug 14825 ***