The table with order information is 'out of order' - the column headings don't match the content and it runs wider than the page width. I am trying to see if maybe it's the changes from bug 18736 missing here.
Nope, it's Bug 12110: (follow-up) add French and German translation $titleinfo. ($line->{order_vendornote} ? "\n----------------\nLieferantennotiz : ". $line->{order_vendornote} : '' ), $line->{quantity}, $line->{quantity}, We only need quantity once.
Created attachment 105295 [details] [review] Bug 25507: Fix table in basket group PDF German 2-pages A variable was doubled up which made the columns in the table of orders no longer line up (different number of headers to columns). To test: - Create at least one basket with one or more orders - Close the basket - Add the basket to a basket group manually or let Koha do it on closing - Change the OrderPdfFormat system preference to 'German 2-page' - Go to the basket group page and print the PDF of the basket - Verify the table of orders doesn't look right and runs outside the page - Apply patch - Repeat the PDF print - now table should look right
Created attachment 105674 [details] [review] Bug 25507: Fix table in basket group PDF German 2-pages A variable was doubled up which made the columns in the table of orders no longer line up (different number of headers to columns). To test: - Create at least one basket with one or more orders - Close the basket - Add the basket to a basket group manually or let Koha do it on closing - Change the OrderPdfFormat system preference to 'German 2-page' - Go to the basket group page and print the PDF of the basket - Verify the table of orders doesn't look right and runs outside the page - Apply patch - Repeat the PDF print - now table should look right Signed-off-by: David Nind <david@davidnind.com>
Thank you, David! The "German" fixes are a bit hard to get tested!
Created attachment 105738 [details] [review] Bug 25507: Fix table in basket group PDF German 2-pages A variable was doubled up which made the columns in the table of orders no longer line up (different number of headers to columns). To test: - Create at least one basket with one or more orders - Close the basket - Add the basket to a basket group manually or let Koha do it on closing - Change the OrderPdfFormat system preference to 'German 2-page' - Go to the basket group page and print the PDF of the basket - Verify the table of orders doesn't look right and runs outside the page - Apply patch - Repeat the PDF print - now table should look right Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Trivial fix that passes qa scripts, makes sense and passes local testing. Passing QA
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.12
Thx all!