Now that Bug 9416 is pushed, we can improve Basketgroup PDFs to display the note made for the vendor. We can also replace the internal order note with the vendor order note. M. Saby
Created attachment 27310 [details] [review] [PATCH] Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF This bug adds the "vendor note" for each order in the PDF for basketgroups. The note is display only if it exists, just under the bibliographic information. I added a separation line "--------" between bibliographic information and the note, so that it could be visible at 1st glance It also replaces the internal note with the vendor in the CSV for basket and basketgroup It is more logical and useful for libraries to export the note made for vendor, as those files are destined to be sent to the vendor. Test plan : - fill a basket with some orders, some with internal notes, some with vendor notes - export the basket in CSV : only the vendor notes should be present - put the basket in a basketgroup - export the basketgroup in CSV : only the vendor notes should be present - Select "English-2 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information - Select "English-3 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information
Created attachment 28111 [details] [review] [PATCH] Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF Rebased (to take into account the changes made by bug 11859)
Back to need sign off Of course, you can discuss the ergonomy of the display for the vendor note (maybe the "----------" before the note is not very nice) Mathieu
I test against master 3.15.00.051 . All is OK. So I pass the patch to "Signed Off" status.
Created attachment 28168 [details] [review] Display the order vendor note in basket and basketgroup
I think the change should be done in all packages existing in acqui/pdfformat. Marked as Failed QA.
(In reply to Jonathan Druart from comment #6) > I think the change should be done in all packages existing in > acqui/pdfformat. > > Marked as Failed QA. I suppose you mean in german and french version. I can do it for french, of course, and try to do something for german. I don't speak german, but Google Translate proposes "Hinweise für den Lieferanten" for "Note for vendor". I will ask Katrin to be sure. Mathieu
I think "Lieferantennotiz" is what we use in some other places, so that might work :)
I was just writing you a mail ;-) Thank you for the advice Mathieu
Created attachment 28314 [details] [review] Bug 12110 [PATCH 2/2] QA followup : french and german translation This followup - translates "vendor note" in french and german. - replaces "Notes for vendor" with "Note for vendor" in english template (as there can only be 1 note) - fixes a typo in french template (Qte => Qté, for "Quantité") Test plan : set OrderPdfFormat preference to "French 3-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Notes pour le fournisseur" set OrderPdfFormat preference to "German 2-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Lieferantennotiz"
Created attachment 28381 [details] [review] Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF (Rebased after bug 11859 is pushed) This bug adds the "vendor note" for each order in the PDF for basketgroups. The note is display only if it exists, just under the bibliographic information. I added a separation line "--------" between bibliographic information and the note, so that it could be visible at 1st glance It also replaces the internal note with the vendor in the CSV for basket and basketgroup It is more logical and useful for libraries to export the note made for vendor, as those files are destined to be sent to the vendor. Test plan : - fill a basket with some orders, some with internal notes, some with vendor notes - export the basket in CSV : only the vendor notes should be present - put the basket in a basketgroup - export the basketgroup in CSV : only the vendor notes should be present - Select "English-2 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information - Select "English-3 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 28382 [details] [review] Bug 12110 : Display the order vendor note in basket and basketgroup CSV and PDF (Rebased after bug 11859 is pushed) This bug adds the "vendor note" for each order in the PDF for basketgroups. The note is display only if it exists, just under the bibliographic information. I added a separation line "--------" between bibliographic information and the note, so that it could be visible at 1st glance It also replaces the internal note with the vendor in the CSV for basket and basketgroup It is more logical and useful for libraries to export the note made for vendor, as those files are destined to be sent to the vendor. Test plan : - fill a basket with some orders, some with internal notes, some with vendor notes - export the basket in CSV : only the vendor notes should be present - put the basket in a basketgroup - export the basketgroup in CSV : only the vendor notes should be present - Select "English-2 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information - Select "English-3 pages" template for basketgroups in Sysprefs - export the basket in PDF : the vendor notes should be present under the bibliographic information Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 28383 [details] [review] Bug 12110 [PATCH 2/2] QA followup : french and german translation This followup - translates "vendor note" in french and german. - replaces "Notes for vendor" with "Note for vendor" in english template (as there can only be 1 note) - fixes a typo in french template (Qte => Qté, for "Quantité") Test plan : set OrderPdfFormat preference to "French 3-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Notes pour le fournisseur" set OrderPdfFormat preference to "German 2-pages" Print a basketgroup containing an order with a vendornote, and check the note is displayed and introduced by "Lieferantennotiz" Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Mathieu!