There are some visual glitches on the self checkout screens. Mainly: With SCOAllowCheckin allowed: - Have an item checked out that can be renewed - Log into self checkout (sco-main) - On the checkouts table, there is a renew link, but it doesn't stand out as a button anymore - Try to checkout an item not for loan - The button in the message will look not quite right
Created attachment 110257 [details] [review] Bug 26478: Display issue with buttons on the self checkout screens This patch adds missing Bootstrap classes to a few buttons on the self checkout page. Without the classes the buttons are not styled correctly. To test, apply the patch and open the self checkout page for a patron with multiple checkouts, some renewable and some non-renewable. In the table of the user's checkouts the "Renew item" button should be styled as a green button. The "Check in item" button should be styled as a blue button. Try to check out an item which cannot be circulated. On the page warning you "Item cannot be checked out," the "Return to account summary" button should be styled as a blue button.
Created attachment 110417 [details] [review] Bug 26478: Display issue with buttons on the self checkout screens This patch adds missing Bootstrap classes to a few buttons on the self checkout page. Without the classes the buttons are not styled correctly. To test, apply the patch and open the self checkout page for a patron with multiple checkouts, some renewable and some non-renewable. In the table of the user's checkouts the "Renew item" button should be styled as a green button. The "Check in item" button should be styled as a blue button. Try to check out an item which cannot be circulated. On the page warning you "Item cannot be checked out," the "Return to account summary" button should be styled as a blue button. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 110420 [details] [review] Bug 26478: Display issue with buttons on the self checkout screens This patch adds missing Bootstrap classes to a few buttons on the self checkout page. Without the classes the buttons are not styled correctly. To test, apply the patch and open the self checkout page for a patron with multiple checkouts, some renewable and some non-renewable. In the table of the user's checkouts the "Renew item" button should be styled as a green button. The "Check in item" button should be styled as a blue button. Try to check out an item which cannot be circulated. On the page warning you "Item cannot be checked out," the "Return to account summary" button should be styled as a blue button. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
doesnt apply cleanly to 20.05.x, no backport