When the AllowCheckoutNotes system preference is enabled the logged-in OPAC user can add notes to items they have checked out. The submit button for this process was not updated with the correct Bootstrap 4 classes.
Created attachment 110599 [details] [review] Bug 26512: Display issue with buttons for OPAC checkout note This patch adds the correct Bootstrap 4 class to the buttons for submitting checkout notes in the OPAC. The markup has been updated to use <button> instead of <a> because of a style conflict with jQueryUI's CSS. To test, apply the patch and enable the AllowCheckoutNotes system preference. - Log in to the OPAC as a patron with checkouts. - On the "Your summary" page, enter some text into a field in the "Notes" column of the checkouts table. - Upon typing in the field a button should appear, "Submit note." - The button should be styled as a green button. - Submit the note. - Make a change to the text in the field. A button should appear, "Submit changes." It should also be styled correctly.
Created attachment 110624 [details] [review] Bug 26512: Display issue with buttons for OPAC checkout note This patch adds the correct Bootstrap 4 class to the buttons for submitting checkout notes in the OPAC. The markup has been updated to use <button> instead of <a> because of a style conflict with jQueryUI's CSS. To test, apply the patch and enable the AllowCheckoutNotes system preference. - Log in to the OPAC as a patron with checkouts. - On the "Your summary" page, enter some text into a field in the "Notes" column of the checkouts table. - Upon typing in the field a button should appear, "Submit note." - The button should be styled as a green button. - Submit the note. - Make a change to the text in the field. A button should appear, "Submit changes." It should also be styled correctly. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 110628 [details] [review] Bug 26512: Display issue with buttons for OPAC checkout note This patch adds the correct Bootstrap 4 class to the buttons for submitting checkout notes in the OPAC. The markup has been updated to use <button> instead of <a> because of a style conflict with jQueryUI's CSS. To test, apply the patch and enable the AllowCheckoutNotes system preference. - Log in to the OPAC as a patron with checkouts. - On the "Your summary" page, enter some text into a field in the "Notes" column of the checkouts table. - Upon typing in the field a button should appear, "Submit note." - The button should be styled as a green button. - Submit the note. - Make a change to the text in the field. A button should appear, "Submit changes." It should also be styled correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.05
I am not sure if this should be backported - the dependency (Bootstrap 4 update) is not in 20.05.
Cait, You are right, that was a mistake on my part. Reverting this patch.
missing dependencies, not backported to 19.11.x