26577 – Make basket.pl and cancelorder.pl use $order->cancel

Bug 26577 - Make basket.pl and cancelorder.pl use $order->cancel

Summary: Make basket.pl and cancelorder.pl use $order->cancel

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Architecture, internals, and plumbing (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Tomás Cohen Arazi (tcohen)
QA Contact:	Kyle M Hall (khall)

URL:
Keywords:

Depends on:	26515
Blocks:	26579 26580
	Show dependency tree / graph

Reported:	2020-09-30 11:04 UTC by Tomás Cohen Arazi (tcohen)
Modified:	2021-06-14 21:33 UTC (History)
CC List:	5 users (show)

See Also:	10869
Change sponsored?:	---
Patch complexity:	Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	This patch refactors order cancelling code usage to prepare the ground for code cleanup.
Version(s) released in:	20.11.00
Circulation function:

Attachments
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel (6.28 KB, patch) 2020-09-30 14:29 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel (6.35 KB, patch) 2020-10-01 11:42 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel (6.42 KB, patch) 2020-10-02 17:52 UTC, Kyle M Hall (khall)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Tomás Cohen Arazi (tcohen) 2020-09-30 11:04:21 UTC

Comment 1 Tomás Cohen Arazi (tcohen) 2020-09-30 14:29:04 UTC

Created attachment 110993 [details] [review]
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel

This patch makes the mentioned controller scripts use the new
$order->cancel method instead of DelOrder.

To test:
1. Apply this patches
2. Have a basket with some orders
3. Play with cancelling orders and removing baskets
=> SUCCESS: No behaviour change!
=> SUCCESS: No errors!
4. Sign off :-D

Comment 2 Martin Renvoize (ashimema) 2020-10-01 11:42:18 UTC

Created attachment 111035 [details] [review]
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel

This patch makes the mentioned controller scripts use the new
$order->cancel method instead of DelOrder.

To test:
1. Apply this patches
2. Have a basket with some orders
3. Play with cancelling orders and removing baskets
=> SUCCESS: No behaviour change!
=> SUCCESS: No errors!
4. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 3 Martin Renvoize (ashimema) 2020-10-01 11:42:50 UTC

It's great to see this scripts getting tidied up.. works as expected.

Signing off

Comment 4 Kyle M Hall (khall) 2020-10-02 17:52:48 UTC

Created attachment 111174 [details] [review]
Bug 26577: Make basket.pl and cancelorder.pl use ->cancel

This patch makes the mentioned controller scripts use the new
$order->cancel method instead of DelOrder.

To test:
1. Apply this patches
2. Have a basket with some orders
3. Play with cancelling orders and removing baskets
=> SUCCESS: No behaviour change!
=> SUCCESS: No errors!
4. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Comment 5 Jonathan Druart 2020-10-15 13:25:20 UTC

Pushed to master for 20.11, thanks to everybody involved!

Comment 6 Lucas Gass (lukeg) 2020-11-13 15:51:19 UTC

enhancement will not be backported to 20.05.x