As of bug 26577, it is only used in a bunch of test files.
Created attachment 110996 [details] [review] Bug 26579: Remove unused C4::Acquisition::DelOrder function This patch removes an unused function, its tests, and adjusts other test files that relied on it by replacing it with $order->cancel calls. To test: 1. Run: $ kshell k$ prove t/db_dependent/Acquisition.t \ t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t \ t/db_dependent/Acquisition/close_reopen_basket.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 111040 [details] [review] Bug 26579: Remove unused C4::Acquisition::DelOrder function This patch removes an unused function, its tests, and adjusts other test files that relied on it by replacing it with $order->cancel calls. To test: 1. Run: $ kshell k$ prove t/db_dependent/Acquisition.t \ t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t \ t/db_dependent/Acquisition/close_reopen_basket.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 111138 [details] [review] Bug 26579: Remove unused C4::Acquisition::DelOrder function This patch removes an unused function, its tests, and adjusts other test files that relied on it by replacing it with $order->cancel calls. To test: 1. Run: $ kshell k$ prove t/db_dependent/Acquisition.t \ t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t \ t/db_dependent/Acquisition/close_reopen_basket.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
I concur DelOrder is no longer required. Passing QA
Blocked by dependancies which need QA
If I am reading the code correctly there is a behaviour changed: before: the order is cancelled and the items that can be deleted are deleted after : the order is cancelled but if at least 1 item cannot be deleted, none are deleted
(In reply to Jonathan Druart from comment #6) > If I am reading the code correctly there is a behaviour changed: > > before: the order is cancelled and the items that can be deleted are deleted > after : the order is cancelled but if at least 1 item cannot be deleted, > none are deleted To clarify the situation: the whole tree is blocked by this.
(In reply to Jonathan Druart from comment #7) > (In reply to Jonathan Druart from comment #6) > > If I am reading the code correctly there is a behaviour changed: > > > > before: the order is cancelled and the items that can be deleted are deleted > > after : the order is cancelled but if at least 1 item cannot be deleted, > > none are deleted > > To clarify the situation: the whole tree is blocked by this. Oh, I forgot about it. Will fix it!
Solved, with follow-ups on bug 26515 and bug 26555.
Created attachment 111726 [details] [review] Bug 26579: Remove unused C4::Acquisition::DelOrder function This patch removes an unused function, its tests, and adjusts other test files that relied on it by replacing it with $order->cancel calls. To test: 1. Run: $ kshell k$ prove t/db_dependent/Acquisition.t \ t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t \ t/db_dependent/Acquisition/close_reopen_basket.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat (1) => SUCCESS: Tests pass! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Rebased against master, test count error.
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x