Bug 26926 - Omnibus: Update all occurrences of <input type="number"> to apply ACC2 coding guideline
Summary: Omnibus: Update all occurrences of <input type="number"> to apply ACC2 coding...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Eden
QA Contact: Testopia
URL: https://wiki.koha-community.org/wiki/...
Keywords: accessibility
Depends on: 27290 27404 27405 27406 27407 27408 27409 27410 27411 27412 28134 28135 28283
Blocks: 23003
  Show dependency tree / graph
 
Reported: 2020-11-04 15:55 UTC by Martin Renvoize (ashimema)
Modified: 2021-12-13 21:10 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2020-11-04 15:55:53 UTC 
Retroactively apply ACC2 coding guideline

We need to update all `input type="number"` occurrences to use `<input type="text" inputmode="numeric" pattern="[0-9]*">` as per the new accessibility guideline.
Comment 1 Katrin Fischer 2021-01-11 22:12:35 UTC 
This bug split into multiple might make a good Academy task?
Comment 2 Martin Renvoize (ashimema) 2021-01-12 10:27:03 UTC 
(In reply to Katrin Fischer from comment #1)
> This bug split into multiple might make a good Academy task?

Done
Comment 4 David Nind 2021-02-20 23:14:59 UTC 
Owen Leonard updated Bug 27408 and Bug 27410 for currency strings, and I've updated Bug 27405:

- inputmode changed to "decimal"
- regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt

"The regex validating the modified field doesn't allow for currency-formatted values like "1.00" because of the dot."
Comment 5 Henry Bolshaw 2021-04-12 09:48:12 UTC 
I think all of these occurrences have been fixed now. Is that correct?
Comment 6 Owen Leonard 2021-04-12 11:39:49 UTC 
(In reply to Henry Bolshaw from comment #5)
> I think all of these occurrences have been fixed now. Is that correct?

I think Bug 28134 and 28135 are the last.