Inputs of type="number" need updating to reflect ACC2 in intranet-tmpl/prog/en/modules/members/boraccount.tt
Created attachment 115397 [details] [review] Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed.
There is more to do when converting a "type='number'" input: If present, the "step," "max," and "min" attributes should be removed too. They are invalid if applied to a standard text input. Example errors from the w3c validator: Error: Attribute step not allowed on element input at this point. Error: Attribute min not allowed on element input at this point.
Created attachment 115460 [details] [review] Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines In addition, all "min" and "step" attributes have been removed from these inputs (Thanks Owen). Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed.
Created attachment 115481 [details] [review] Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines In addition, all "min" and "step" attributes have been removed from these inputs (Thanks Owen). Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 115520 [details] [review] Bug 27409: Update intranet-tmpl/prog/en/modules/members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines In addition, all "min" and "step" attributes have been removed from these inputs (Thanks Owen). Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Excellent work again, Passing QA
Created attachment 115555 [details] [review] Bug 27409: Update members/boraccount.tt for ACC2 This patch changes all instances of type="number" in inputs to adhere with the ACC2 guidelines In addition, all "min" and "step" attributes have been removed from these inputs (Thanks Owen). Test plan: Go through the boraccount.tt file and insure that no instances of type="number" were missed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed to master for 21.05, thanks to everybody involved!
I tested this in Chrome both on the desktop and from a mobile (to test inputmode) Both allowed me to input decimals as required.. but Owen has since highlighted that the regex in the pattern is a little strict so it sounds like this should work.. Leaving as a note here so I can revisit tomorrow to see if we need a follow-up.