The value of PatronSelfRegistrationLibraryList is used to display the dropdown list of the libraries, but not after the form is submitted.
Created attachment 116271 [details] [review] Bug 27604: Make sure PatronSelfRegistrationLibraryList is used The value of PatronSelfRegistrationLibraryList is used to display the dropdown list of the libraries, but not after the form is submitted. Test plan: 1. Empty PatronSelfRegistrationLibraryList 2. Self register a new patron => Confirm the dropdown list with the libraries contain all the libraries 3. Fill in PatronSelfRegistrationLibraryList with branchcodes (eg. "CPL|MPL") 4. Self register a new patron 5. Edit the HTML form and replace the option's value with another branchcode (FPL) 6. Save => Without this patch the branchcode FPL is used => With this patch applied an ugly 500 is returned
Created attachment 116286 [details] [review] Bug 27604: Make sure PatronSelfRegistrationLibraryList is used The value of PatronSelfRegistrationLibraryList is used to display the dropdown list of the libraries, but not after the form is submitted. Test plan: 1. Empty PatronSelfRegistrationLibraryList 2. Self register a new patron => Confirm the dropdown list with the libraries contain all the libraries 3. Fill in PatronSelfRegistrationLibraryList with branchcodes (eg. "CPL|MPL") 4. Self register a new patron 5. Edit the HTML form and replace the option's value with another branchcode (FPL) 6. Save => Without this patch the branchcode FPL is used => With this patch applied an ugly 500 is returned Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 116424 [details] [review] Bug 27604: Make sure PatronSelfRegistrationLibraryList is used The value of PatronSelfRegistrationLibraryList is used to display the dropdown list of the libraries, but not after the form is submitted. Test plan: 1. Empty PatronSelfRegistrationLibraryList 2. Self register a new patron => Confirm the dropdown list with the libraries contain all the libraries 3. Fill in PatronSelfRegistrationLibraryList with branchcodes (eg. "CPL|MPL") 4. Self register a new patron 5. Edit the HTML form and replace the option's value with another branchcode (FPL) 6. Save => Without this patch the branchcode FPL is used => With this patch applied an ugly 500 is returned Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=11983
Created attachment 116425 [details] [review] Bug 27604: (QA follow-up) Limit the libraries during the query Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=11983
Created attachment 116497 [details] [review] Bug 27604: Init to {}
Pushed to master for 21.05, thanks to everybody involved!
Created attachment 116907 [details] [review] Bug 27604: Deal with empty pref
(In reply to Jonathan Druart from comment #7) > Created attachment 116907 [details] [review] [review] > Bug 27604: Deal with empty pref Patch pushed to master.
tl;dr can't backport to 19.11, help needed with the conflicts Thanks Andrew for testing on 20.05 As this applies without any issue on 20.05, that means my hope of using the 20.05 version to solve the conflicts won't realize. ^^" Reply from Fridolin via email > I see Bug 25136 affects this code, its only in >= 20.05. > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25136 Bug 25136 didn't introduced the bug, I can reproduce it on 19.11 > Or maybe try to apply 3 patches squashed as one. Same conflict :(
Created attachment 117020 [details] [review] Bug 27604: [19.11] Make sure PatronSelfRegistrationLibraryList is used The value of PatronSelfRegistrationLibraryList is used to display the dropdown list of the libraries, but not after the form is submitted. Test plan: 1. Empty PatronSelfRegistrationLibraryList 2. Self register a new patron => Confirm the dropdown list with the libraries contain all the libraries 3. Fill in PatronSelfRegistrationLibraryList with branchcodes (eg. "CPL|MPL") 4. Self register a new patron 5. Edit the HTML form and replace the option's value with another branchcode (FPL) 6. Save => Without this patch the branchcode FPL is used => With this patch applied an ugly 500 is returned Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=11983 Bug 27604: (QA follow-up) Limit the libraries during the query Signed-off-by: Nick Clemens <nick@bywatersolutions.com> https://bugs.koha-community.org/show_bug.cgi?id=11983 Bug 27604: Init to {} Bug 27604: Deal with empty pref
I picked the code from master and it's working correctly it seems (ie. it embemds bug 25136).
It works, thanks a lot Jonathan :)
Pushed to 20.11.x for 20.11.03
Backported: Pushed to 19.11.x branch for 19.11.15
And pushed to master for 21.05