---- Reported by paul.poulain@biblibre.com 2008-11-13 06:09:23 ---- A lot of strings have more than the 1st word ucfirst(). koha-devel think it would be better to have uppercase only on the 1st word : On Wed, Nov 12, 2008 at 9:39 AM, Galen Charlton <galen.charlton@liblime.com> wrote: > > Hi, > > > > On Wed, Nov 12, 2008 at 4:32 AM, Paul POULAIN <paul.poulain@free.fr> wrote: >> >> Do we (mainly owen ?) have a rule for uppercase & lower case ? >> >> something like : >> >> - in button, each word has ucfirst >> >> - otherwise, only the 1st word has ucfirst > > > > I don't think that's been standardized, but I think it would nice to > > establish something. I have a slight preference for capitalizing only > > the first word, but either way would be fine. I agree, capitalizing on the first word except for proper nouns I suppose. Josh ---- Additional Comments From nengard@gmail.com 2009-12-23 17:59:45 ---- This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:55 UTC --- This bug was previously known as _bug_ 2780 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2780 Actual time not defined. Setting to 0.0
Most strings are now correctly capitalized. Marking as resolved, reopen with detailled informations (which page / which string) if you find forgotten strings
I think we still mix capitalization in a lot of places and forms. When working on the translations I notice that too, often the same words or labels appear with different captalization.
Created attachment 8804 [details] [review] Bug 2780 - Capitalize strings consistently (Acquisitions) Corrections to Acquisitions include files. Patch also includes some corrections to unescaped ampersands.
Created attachment 8805 [details] [review] Bug 2780 - Capitalize strings consistently (Authorities) Corrections to Authorities-related includes.
Created attachment 8807 [details] [review] Bug 2780 - Capitalize strings consistently (catalog) Correcting catalog-related includes.
Created attachment 8808 [details] [review] Bug 2780 - Capitalize strings consistently (Budgets) Correcting Budgets-related includes.
Created attachment 8810 [details] [review] Bug 2780 - Capitalize strings consistently (Circulation) Correcting Circulation-related includes
Created attachment 8812 [details] [review] Bug 2780 - Capitalize strings consistently (Labels) Correcting Labels-related includes
Created attachment 8813 [details] [review] Bug 2780 - Capitalize strings consistently (Patron cards) Correcting Patron card creator-related includes
Created attachment 8815 [details] [review] Bug 2780 - Capitalize strings consistently (Patrons) Correcting Patron-related includes
Created attachment 8817 [details] [review] Bug 2780 - Capitalize strings consistently (Serials) Correcting Serials-related includes
Created attachment 8818 [details] [review] Bug 2780 - Capitalize strings consistently (Cataloging) Correcting Cataloging-related includes
Created attachment 8819 [details] [review] Bug 2780 - Capitalize strings consistently (Administration) Correcting System administration-related includes
Created attachment 8820 [details] [review] Bug 2780 - Capitalize strings consistently (Reports) Correcting Reports-related includes
Created attachment 8821 [details] [review] Bug 2780 - Capitalize strings consistently (Tools) Correcting Tools-related includes
Created attachment 8823 [details] [review] Bug 2780 - Capitalize strings consistently (miscellaneous) Correcting all remaining includes
Created attachment 8829 [details] [review] Bug 2780 - Capitalize strings consistently (Acquisitions pages) Correcting capitalization on strings in Acquisitions templates
Applying: Bug 2780 - Capitalize strings consistently (Administration) error: patch failed: koha-tmpl/intranet-tmpl/prog/en/includes/budgetperiods-admin.inc:19 error: koha-tmpl/intranet-tmpl/prog/en/includes/budgetperiods-admin.inc: patch does not apply Patch failed at 0001 Bug 2780 - Capitalize strings consistently (Administration)
Created attachment 8832 [details] [review] Bug 2780 - Capitalize strings consistently (Acquisitions pages) Correcting capitalization on strings in Acquisitions templates
> koha-tmpl/intranet-tmpl/prog/en/includes/budgetperiods-admin.inc:19 Looks like the problem is that two of my patches touch the same file (because I forgot I had already included it in another patch). These patches should apply fine separately. I assumed that it would be easier for people to sign off if I didn't submit one huge patch.
Created attachment 8840 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently Corrections to Acquisitions include files. Patch also includes some corrections to unescaped ampersands. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8841 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently Corrections to Authorities-related includes. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8842 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (catalog) Correcting catalog-related includes. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8843 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Budgets) Correcting Budgets-related includes. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8844 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Circulation) Correcting Circulation-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8845 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Labels) Correcting Labels-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8846 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Patron cards) Correcting Patron card creator-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8847 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Patrons) Correcting Patron-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8848 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Serials) Correcting Serials-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8849 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Cataloging) Correcting Cataloging-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8850 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Administration) Correcting System administration-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8851 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Reports) Correcting Reports-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8852 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Tools) Correcting Tools-related includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8853 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (miscellaneous) Correcting all remaining includes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 8854 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Acquisitions pages) Correcting capitalization on strings in Acquisitions templates Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
There may have been a few strings overlooked ("Add MARC Record" on the main page still has "Record" capitalized, for example), but this is a huge improvement over the way it was before. Signing off. Additional strings can be corrected in follow-ups.
Created attachment 8866 [details] [review] Bug 2780 - Capitalize strings consistently (Admin pages) Correcting capitalization in Administration templates.
Created attachment 8870 [details] [review] Bug 2780 - Capitalize strings consistently (Authorities pages) Correcting capitalization in Authorities templates
Created attachment 8871 [details] [review] Bug 2780 - Capitalize strings consistently (Staff client cart) Correcting capitalization in the staff client's cart templates
Created attachment 8875 [details] [review] Bug 2780 - Capitalize strings consistently (Catalog pages) Correcting capitalization in the staff client catalog pages
Comment on attachment 8840 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently patch pushed
Comment on attachment 8841 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently patch pushed
Comment on attachment 8842 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (catalog) patch pushed
Comment on attachment 8843 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Budgets) patch pushed
Comment on attachment 8844 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Circulation) patch pushed
Comment on attachment 8845 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Labels) patch pushed
Comment on attachment 8846 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Patron cards) patch pushed
Comment on attachment 8847 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Patrons) patch pushed
Comment on attachment 8848 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Serials) patch pushed
Comment on attachment 8849 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Cataloging) patch pushed
Comment on attachment 8850 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Administration) patch pushed
Comment on attachment 8851 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Reports) patch pushed
Comment on attachment 8852 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Tools) patch pushed
Comment on attachment 8853 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (miscellaneous) patch pushed
Comment on attachment 8854 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Acquisitions pages) patch pushed
QA comment: all signed-off patches are related to string/capitalization changes only, passed QA. All have been pushed, switching back to "need signoff" for others. PS: the circulation patch had a conflict CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/circ-toolbar.inc caused by bug 7888 pushed a few hours ago. I've solved it, it was easy
Created attachment 8880 [details] [review] Bug 2780 - Capitalize strings consistently (Cataloging plugins) Correcting capitalization in Cataloging plugins. Also correcting some instances of invalid HTML.
Created attachment 8882 [details] [review] Bug 2780 - Capitalize strings consistently (Cataloging pages) Correcting capitalization in Cataloging templates
Created attachment 8883 [details] [review] Bug 2780 - Capitalize strings consistently (Circulation) Correcting capitalization in Circulation templates
Created attachment 8884 [details] [review] Bug 2780 - Capitalize strings consistently (OPAC includes) Correcting capitalization in OPAC includes
Just a comment from a non-native speaker ;) For titles like main menu options, command buttons, and so on I feel that we should not per se decapitalize all words except the first. There are (English) grammar rules about capitalizing words in titles. The problem here is: what do we call a title? I think the label of a main menu option or a button is a good candidate. So I would be in favor of keeping things like Advanced Search and Search the Catalog! (While scrolling through some Google search results for Advanced Search, I had the impression that the two-capitals variant had more occurrences than the one-capital form.) If we agree on what a title is, we can still be consistent in following that rule.
I think the easier the rule the greater is the chance that we will reach some consistency.
(In reply to comment #61) > There are (English) grammar rules about capitalizing words in titles. The > problem here is: what do we call a title? There are rules in English for capitalizing words in a title, but those words depend on the context. When I cite a title in a paper I capitalize the first letter of each word. When I catalog that title in Koha I don't capitalize. I think there are too many variations of the rules to be able to apply them consistently and easily in Koha. Better to have a simple rule.
Created attachment 8926 [details] [review] Bug 2780 - Capitalize strings consistently (OPAC pages) Correcting capitalization in OPAC templates
Created attachment 8928 [details] [review] Bug 2780 - Capitalize strings consistently (Error pages) Correcting capitalization in staff client error pages
Created attachment 8929 [details] [review] Bug 2780 - Capitalize strings consistently (Acqui help) Correcting capitalization in Acquisitions help templates
Created attachment 8930 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (OPAC pages) Correcting capitalization in OPAC templates Signed-off-by: Liz Rea <wizzyrea@gmail.com> Passes tests, changes look consistent by reading through the patch. What a doozy!
Created attachment 8935 [details] [review] Bug 2780 - Capitalize strings consistently (Admin help) Correcting capitalization in Administration help templates
Created attachment 8954 [details] [review] Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help) Correcting capitalization in Authorities and Cataloging help pages
Created attachment 8960 [details] [review] Bug 2780 - Capitalize strings consistently (Circulation help) Correcting capitalization in Circulation help templates
Comment on attachment 8930 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (OPAC pages) this patch has been pushed
switching back to "need signoff", because many are still needing...
Created attachment 8977 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Admin pages) Correcting capitalization in Administration templates. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8978 [details] [review] Bug 2780 - Follow up - Capitalize strings consistently (Admin pages) Fixes some missed strings.
Created attachment 8979 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Authorities pages) Correcting capitalization in Authorities templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8980 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Staff client cart) Correcting capitalization in the staff client's cart templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8981 [details] [review] Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart)
Created attachment 8983 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Catalog pages) Correcting capitalization in the staff client catalog pages Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8984 [details] [review] Bug 2780 - Capitalize strings consistently (Misc. help pages) Correcting capitalization in various help templates
Created attachment 8985 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Cataloging plugins) Correcting capitalization in Cataloging plugins. Also correcting some instances of invalid HTML. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8986 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Cataloging pages) Correcting capitalization in Cataloging templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8987 [details] [review] Bug 2780 - Capitalize strings consistently (Labels help) Correcting capitalization in Labels help templates
Created attachment 8988 [details] [review] Bug 2780 - Capitalize strings consistently (Installer) Correcting capitalization in Installer templates
Created attachment 8989 [details] [review] Bug 2780 - Capitalize strings consistently (Labels templates) Correcting capitalization in Labels templates
Created attachment 8990 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Circulation) Correcting capitalization in Circulation templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8991 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (OPAC includes) Correcting capitalization in OPAC includes Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8992 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Error pages) Correcting capitalization in staff client error pages Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8993 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Installer) Correcting capitalization in Installer templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8994 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Acqui help) Correcting capitalization in Acquisitions help templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8995 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Admin help) Correcting capitalization in Administration help templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 8996 [details] [review] Bug 2780: Capitalize strings consistently Some missing strings.
Created attachment 9013 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help) Correcting capitalization in Authorities and Cataloging help pages Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 9014 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Circulation help) Correcting capitalization in Circulation help templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 9015 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Misc. help pages) Correcting capitalization in various help templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 9016 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Labels help) Correcting capitalization in Labels help templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 9017 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Labels templates) Correcting capitalization in Labels templates Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 9018 [details] [review] Bug 2780: Capitalize strings consistently Fixes some more strings.
Created attachment 9019 [details] [review] Bug 2780 - Capitalize strings consistently (members)
Created attachment 9020 [details] [review] Bug 2780 - Capitalize strings consistently (members)
Created attachment 9021 [details] [review] Bug 2780 - Capitalize strings consistently (offline circulation)
Created attachment 9022 [details] [review] Bug 2780 - Capitalize strings consistently (patron cards)
Created attachment 9023 [details] [review] Bug 2780 - Capitalize strings consistently (reports)
Created attachment 9024 [details] [review] Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections)
Created attachment 9025 [details] [review] Bug 2780 - Capitalize strings consistently (serials)
Created attachment 9026 [details] [review] Bug 2780 - Capitalize strings consistently - various
Created attachment 9027 [details] [review] Bug 2780 - Capitalize strings consistently (virtualshelves)
Created attachment 9028 [details] [review] Bug 2780 - Capitalize strings consistently (tools)
Created attachment 9029 [details] [review] Bug 2780 - Capitalize strings consistently (home, about, login)
I finished off the templates for the modules, there are still help pages mising. And all my patches still need proof reading.
Created attachment 9047 [details] [review] [SIGNED-OFF] Bug 2780 - Follow up - Capitalize strings consistently (Admin pages)
Created attachment 9048 [details] [review] [SIGNED-OFF] Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart)
Note that attachment 9047 [details] [review] and attachment 9048 [details] [review] must be applied after the patches to which they are follow-ups.
Created attachment 9052 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (members)
Created attachment 9054 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (offline circulation) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 9055 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (patron cards) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 9056 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 9057 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (serials) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 9058 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently - various Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment on attachment 8977 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Admin pages) this patch has been pushed
Comment on attachment 8979 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Authorities pages) This patch has been pushed
Comment on attachment 8980 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Staff client cart) This patch has been pushed
Comment on attachment 8983 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Catalog pages) This patch has been pushed
Comment on attachment 8985 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Cataloging plugins) This patch has been pushed
Comment on attachment 8986 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Cataloging pages) This patch has been pushed
Comment on attachment 8990 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Circulation) This patch has been pushed
Comment on attachment 8991 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (OPAC includes) This patch has been pushed
Comment on attachment 8992 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Error pages) This patch has been pushed
Comment on attachment 8993 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Installer) This patch has been pushed
Comment on attachment 8994 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Acqui help) This patch has been pushed
Comment on attachment 8995 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Admin help) This patch has been pushed
Comment on attachment 9013 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help) This patch has been pushed
Comment on attachment 9014 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Circulation help) This patch has been pushed
Comment on attachment 9015 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Misc. help pages) This patch has been pushed
Comment on attachment 9016 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Labels help) This patch has been pushed
Comment on attachment 9017 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (Labels templates) This patch has been pushed
Comment on attachment 9047 [details] [review] [SIGNED-OFF] Bug 2780 - Follow up - Capitalize strings consistently (Admin pages) This patch has been pushed
Comment on attachment 9048 [details] [review] [SIGNED-OFF] Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart) This patch has been pushed
Comment on attachment 9052 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (members) This patch has been pushed
Comment on attachment 9054 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (offline circulation) This patch has been pushed
Comment on attachment 9055 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (patron cards) This patch has been pushed
Comment on attachment 9056 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections) This patch has been pushed
Comment on attachment 9057 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently (serials) This patch has been pushed
Comment on attachment 9058 [details] [review] [SIGNED-OFF] Bug 2780 - Capitalize strings consistently - various This patch has been pushed
Created attachment 9068 [details] [review] [SIGNED-OFF]Bug 2780: Capitalize strings consistently Fixes some more strings. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Created attachment 9069 [details] [review] [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports) Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Created attachment 9070 [details] [review] [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves) Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> This patch also fixes some vocabulary replacing "shelf" by "list"
Created attachment 9071 [details] [review] [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools) Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> This patch also fixes some strings: * itemcallnumber => item call number * Profile marcfields=> Profile MARC fields
Created attachment 9072 [details] [review] Bug 2780 - Capitalize strings consistently - various Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment on attachment 9068 [details] [review] [SIGNED-OFF]Bug 2780: Capitalize strings consistently This patch has been pushed
Comment on attachment 9069 [details] [review] [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports) This patch has been pushed
Comment on attachment 9070 [details] [review] [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves) This patch has been pushed
Comment on attachment 9071 [details] [review] [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools) This patch has been pushed
Created attachment 9073 [details] [review] Bug 2780 - Capitalize strings consistently (home, about, login)
Comment on attachment 9073 [details] [review] Bug 2780 - Capitalize strings consistently (home, about, login) This patch has been pushed (on master branch, not on new/bug_2780 where it does not apply anymore)
Created attachment 9089 [details] [review] Bug 2780 [FOLLOW-UP] Capitalize strings consistently Changes to the case of some hidden input values prevented the user from being able to save a new SQL report.
Created attachment 9091 [details] [review] Bug 2780 [FOLLOW-UP] Capitalize strings consistently Changes to the case of some hidden input values prevented the user from being able to save a new SQL report. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Comment on attachment 9091 [details] [review] Bug 2780 [FOLLOW-UP] Capitalize strings consistently messed up. real patch inc.
Created attachment 9092 [details] [review] Bug 2780 [FOLLOW-UP] Capitalize strings consistently Changes to the case of some hidden input values prevented the user from being able to save a new SQL report. Signed-off-by: Liz Rea <wizzyrea@gmail.com> passes tests, can now save sql reports.
Template only change, fixes capitalization that is required for certain parts of scripts to function. Marking Passed QA.
Comment on attachment 9092 [details] [review] Bug 2780 [FOLLOW-UP] Capitalize strings consistently This patch has been pushed
I'm sure there are minor instances of this remaining to be fixed, but they can be handled individually as we find them.