This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/modules/acqui/lateorders.tt intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt intranet-tmpl/prog/en/modules/acqui/ordered.tt intranet-tmpl/prog/en/modules/acqui/orderreceive.tt intranet-tmpl/prog/en/modules/acqui/parcels.tt intranet-tmpl/prog/en/modules/acqui/spent.tt intranet-tmpl/prog/en/modules/acqui/supplier.tt
Created attachment 118466 [details] [review] Bug 27982: Replace obsolete title-string sorting: Acquisitions templates part 1 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Vendor search - Acquisitions -> Vendor -> Basket -> Add to basket -> From a staged file -> From existing orders (copy) - Acquisitions -> EDIFACT messages - Acquisitions -> Order search - With AcqEnableFiles enabled, attach some files to an invoice: - Acquisitions -> Invoices Acquisitions -> Invoices -> Manage invoice files
Created attachment 118467 [details] [review] Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Late orders - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription - Acquisitions -> "All available funds" table -> Click an "Ordered" value -> Click a "Spent" value - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> test sorting of contracts in the "Contracts" table
Created attachment 118490 [details] [review] Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Late orders - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription - Acquisitions -> "All available funds" table -> Click an "Ordered" value -> Click a "Spent" value - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> test sorting of contracts in the "Contracts" table
Created attachment 118579 [details] [review] Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Late orders - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription - Acquisitions -> "All available funds" table -> Click an "Ordered" value -> Click a "Spent" value - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> test sorting of contracts in the "Contracts" table Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Excellent work, diligently worked through. All works well, passing QA
Created attachment 118782 [details] [review] Bug 27983: (follow-up) Address missing instances This patch cleans up some instances I missed on the first round: - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> "All available funds" table -> Click an "Ordered" value -> Click a "Spent" value - Acquisitions -> Vendor -> test sorting of contracts in the "Contracts" table
Created attachment 118848 [details] [review] Bug 27983: Replace obsolete title-string sorting: Acquisitions templates part 2 This patch modifies several acquisitions templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Acquisitions -> Late orders - Acquisitions -> Vendor -> Basket -> Add to basket -> From a subscription - Acquisitions -> "All available funds" table -> Click an "Ordered" value -> Click a "Spent" value - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> Vendor -> test sorting of contracts in the "Contracts" table Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 118849 [details] [review] Bug 27983: (follow-up) Address missing instances This patch cleans up some instances I missed on the first round: - Acquisitions -> Vendor -> Receive shipments - Acquisitions -> "All available funds" table -> Click an "Ordered" value -> Click a "Spent" value - Acquisitions -> Vendor -> test sorting of contracts in the "Contracts" table Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Applied 27982 and 27983 together. Grepped for title-string in the acqui dir and in js includes. No further cases found.. well caught on the extra's Owen. Passing QA
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x