This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/modules/tools/access_files.tt intranet-tmpl/prog/en/modules/tools/holidays.tt intranet-tmpl/prog/en/modules/tools/inventory.tt intranet-tmpl/prog/en/modules/tools/koha-news.tt intranet-tmpl/prog/en/modules/tools/letter.tt intranet-tmpl/prog/en/modules/tools/modborrowers.tt intranet-tmpl/prog/en/modules/tools/problem-reports.tt
Created attachment 118618 [details] [review] Bug 28007: Replace obsolete title-string sorting: Tools templates This patch modifies several tools templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Tools -> Access files - You must modify koha-conf.xml to uncomment and populate the access_dirs section with a path to a directory containing some files. - Tools -> Calendar - Test the date sorting in the "Exceptions," "Yearly - Repeating holidays," and "Unique holidays" tables. - Tools -> Inventory (I wasn't able to test this because of Bug 28015). - Tools -> News - Tools -> Notices - Tools -> Batch patron modification - Tools -> OPAC problem reports - You must enable the "OPACReportProblem" system preference and submit some problem reports from the OPAC.
Created attachment 118671 [details] [review] Bug 28007: Replace obsolete title-string sorting: Tools templates To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Tools -> Access files - You must modify koha-conf.xml to uncomment and populate the access_dirs section with a path to a directory containing some files. - Tools -> Calendar - Test the date sorting in the "Exceptions," "Yearly - Repeating holidays," and "Unique holidays" tables. - Tools -> Inventory (I wasn't able to test this because of Bug 28015). - Tools -> News - Tools -> Notices - Tools -> Batch patron modification - Tools -> OPAC problem reports - You must enable the "OPACReportProblem" system preference and submit some problem reports from the OPAC.
Created attachment 118791 [details] [review] Bug 28007: (follow-up) Address missing instances This patch removes the "title-string" option from some dataTable initializations.
Created attachment 118897 [details] [review] Bug 28007: Replace obsolete title-string sorting: Tools templates This patch modifies several tools templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - Tools -> Access files - You must modify koha-conf.xml to uncomment and populate the access_dirs section with a path to a directory containing some files. - Tools -> Calendar - Test the date sorting in the "Exceptions," "Yearly - Repeating holidays," and "Unique holidays" tables. - Tools -> Inventory (I wasn't able to test this because of Bug 28015). - Tools -> News - Tools -> Notices - Tools -> Batch patron modification - Tools -> OPAC problem reports - You must enable the "OPACReportProblem" system preference and submit some problem reports from the OPAC. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 118898 [details] [review] Bug 28007: (follow-up) Address missing instances This patch removes the "title-string" option from some dataTable initializations. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Enhancement not pushed to 20.11.x