It would be useful to be able to configure table settings for the preview and results of batch patron modification
Created attachment 118610 [details] [review] Bug 28014: Add table settings to batch patron modification This patch adds table settings to the tables shown before and after a batch of patrons has been submitted for batch patron modification. To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages.
Created attachment 118669 [details] [review] Bug 28014: Add table settings to batch patron modification To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages.
Created attachment 118912 [details] [review] Bug 28014: Add table settings to batch patron modification This patch adds table settings to the tables shown before and after a batch of patrons has been submitted for batch patron modification. To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please rebase on top of bug 28007.
Created attachment 119419 [details] [review] Bug 28014: Add table settings to batch patron modification This patch adds table settings to the tables shown before and after a batch of patrons has been submitted for batch patron modification. To test you must have ExtendedPatronAttributes enabled and at least one configured. - Go to Tools -> Batch patron modification - Submit a set of patrons for modification - In the table showing patron records which will be modified, confirm that all DataTables controls work correctly. - Confirm that the column visibility settings work correctly, including the controls for extended patron attribute columns. - Submit a change to your patron batch. - On the page showing the results, confirm that the DataTables controls continue to work as expected. - Go to Administraion -> Table settings and confirm that making changes to the default configuration for this table (Tools -> batch_patron_modification -> borrowerst) results in the correct default columns being shown on the batch patron modification pages. Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Not directly related to this (I think), but I found something: The NoSort is not taken into account (the first column, the checkboxes, is sortable). It could have been caused by bug 28055, but not sure I understand the problem correctly. Reverting the following changes seem to fix the problem: - if ( new_parameters["aoColumnDefs"] === undefined ) { - new_parameters["aoColumnDefs"] = default_column_defs; + if ( new_parameters["columnDefs"] === undefined ) { + new_parameters["columnDefs"] = default_column_defs; Owen, could you have a look please (certainly need to be fixed as a follow-up of bug 28055 if the assertion is correct)?
You're correct Jonathan, the changes to columns_settings.inc adversely affect several pages which still use the old "aoColumnDefs" option. Those particular lines should be only be converted to use "columnDefs" if the patch includes changes to those other files at the same time. Would you prefer the follow-up here or on Bug 28055? Or a new bug?
A follow-up on bug 28055 would be perfect!
Pushed to master for 21.05, thanks to everybody involved!
Depends on Bug 28007 not in 20.11.x