When RestrictionBlockRenewing is set to Allow, it only allows renewal via the intranet. The wording on the syspref does not make this clear. It says: If a patron is restricted, (allow/block) renewing of items. We should amend it to: If a patron is restricted, (allow/block) renewing of items from the staff interface.
Created attachment 123100 [details] [review] Bug 28747: Clarify working on RestrictionBlockRenewal To test, apply patch, restart services and reload page, confirm that now the syspref says "from the staff interface."
Created attachment 123157 [details] [review] Bug 28747: Clarify working on RestrictionBlockRenewal To test, apply patch, restart services and reload page, confirm that now the syspref says "from the staff interface." Signed-off-by: David Nind <david@davidnind.com>
The check is located in CanBookBeRenewed, but in OPAC there seems to be an additional check on restrictions that prevent the patron from renewing before this method can even be called.
Created attachment 123173 [details] [review] Bug 28747: Clarify working on RestrictionBlockRenewal To test, apply patch, restart services and reload page, confirm that now the syspref says "from the staff interface." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.03
Pushed to 20.11.x for 20.11.09
Missing dependencies for 20.05.x, it shouldn't be affected, no backport.
errata: no issue related to dependencies, anyway: Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.