In bug 28747 we changed the wording on this syspref to: If a patron is restricted, (allow/block) renewing of items from the staff interface. In retrospect, we should mentioned auto-renewals: If a patron is restricted, (allow/block) renewing of items from the staff interface and via the automatic_renewals cronjob.
Created attachment 133692 [details] [review] Bug 30597: Update RestrictionBlockRenewal description to include auto renew To test: - apply the patch, find the syspref, see the new wording To confirm the behavior: - set the syspref to Block - give a patron an auto-renewing checkout and a restriction - run automatic_renewal.pl, see item does not renew - switch syspref to allow, repeat, see renewal
Created attachment 133900 [details] [review] Bug 30597: Update RestrictionBlockRenewing description to include auto renew To test: - apply the patch, find the syspref, see the new wording To confirm the behavior: - set the syspref to Block - give a patron an auto-renewing checkout and a restriction - run automatic_renewal.pl, see item does not renew - switch syspref to allow, repeat, see renewal Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 133902 [details] [review] Bug 30597: Update RestrictionBlockRenewing description to include auto renew To test: - apply the patch, find the syspref, see the new wording To confirm the behavior: - set the syspref to Block - give a patron an auto-renewing checkout and a restriction - run automatic_renewal.pl, see item does not renew - switch syspref to allow, repeat, see renewal Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.06
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.