Bug 2930 - Put 'other name' on checkout screen
Summary: Put 'other name' on checkout screen
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.10
Hardware: All All
: P3 enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-27 06:56 UTC by David Schuster
Modified: 2013-05-23 06:24 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch for this bug - modifies circulation.pl and circulation.tmpl (55.32 KB, patch)
2010-02-11 14:25 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 2930 - Put other name on checkout screen (18.31 KB, patch)
2012-08-23 13:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 2930 [REVISED] Put other name on checkout screen (4.44 KB, patch)
2012-09-06 16:32 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 2930 [REVISED] Put other name on checkout screen (4.54 KB, patch)
2012-09-18 18:20 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:04:26 UTC


---- Reported by dschust1@gmail.com 2009-01-27 06:56:23 ----

Currently this information only displays on the Detail screen - Since several borrowers don't use their legal name, but we load them that way schools are putting in the "Other name" information.  It would be helpful if that would display right under the name or behind it on the CKO screen.  We are having to put it in the "notes" field to show on the CKO screen.

example - Charolett Elam actually goes by Mary - but you don't know that on the CKO screen.



---- Additional Comments From mjr@ttllp.co.uk 2009-05-11 14:33:27 ----

Does CKO mean checkout?




---- Additional Comments From gmcharlt@gmail.com 2009-05-11 14:37:14 ----

(In reply to comment #1)
> Does CKO mean checkout?
> 

Yes - usage from a couple legacy ILSs.



---- Additional Comments From dschust1@gmail.com 2010-02-11 14:25:43 ----

Created an attachment
patch for this bug - modifies circulation.pl and circulation.tmpl





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:04 UTC  ---

This bug was previously known as _bug_ 2930 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2930
Imported an attachment (id=973)

Actual time not defined. Setting to 0.0
CC member mjr@ttllp.co.uk does not have an account here
The original submitter of attachment 973 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Katrin Fischer 2012-06-09 17:35:56 UTC
The attached patch makes a lot of changes not related to the bug description. The display name of the patron is generated in an include file now:

[% IF category_type == 'I' %]
    [% surname %] [% IF othernames %] ([% othernames %]) [% END %]
[% ELSE %]
    [% firstname %] [% surname %]
[% END %]
([% cardnumber %])

So for an "organisation" the othername will already be displyed. How should the display for othername look like? Can we agree on something here?
Comment 2 MJ Ray (software.coop) 2012-06-12 08:53:00 UTC
(In reply to comment #1)
> So for an "organisation" the othername will already be displyed. How should
> the display for othername look like? Can we agree on something here?

I suspect it should be:

[% firstname %] [% IF othernames %] ([% othernames %]) [% END %] [% surname %]

Does anyone see a problem with that?

It is one of the suggested forms in
http://dictionary2.classic.reference.com/writing/styleguide/personal.html
Comment 3 Owen Leonard 2012-08-23 13:24:47 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2012-09-04 09:54:05 UTC
This patch introduces a side-effect in the member results page.
Links are not displayed.

Marked as failed qa
Comment 5 Owen Leonard 2012-09-06 16:32:55 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2012-09-18 18:20:05 UTC
Created attachment 12321 [details] [review]
[SIGNED-OFF] Bug 2930 [REVISED] Put other name on checkout screen

This patch adds other name to the include which is used
to display patron names and adds this include in several
places where it can be used in place of direct output.

The patron-title include has been modified to handle the
two possible variable scopes throughout patron-related
templates. This is a hack similar to having both
circ-menu.tt and circ-menu.inc, but keeping both in the
same file.

Changes to some scripts were necessary to make the
othernames variable available to the include.

This patch also corrects some <title> tags and fixes
some incorrect capitalization (see Bug 2780).

To test, view each of the pages affected by these
template changes and confirm that the patron's name
displays correctly, including their "other name."

Signed-off-by: Marc Veron <veron@veron.ch>
Followed instructions above, works as expected.
Comment 7 Jonathan Druart 2012-09-19 08:13:57 UTC
Hi Owen,
Is it normal that  your last patch uses the include file in only 1 tt file?
I think your first proposed patch was more interesting, it used the include in several places instead of just one.
What problem did you encounter?
Comment 8 Paul Poulain 2012-10-09 10:25:26 UTC
QA comment
 * small patch, template only
 * koha-qa.pl OK

passed QA
Comment 9 Paul Poulain 2012-10-09 10:25:40 UTC
Patch pushed to master