Template just contains: <a role="menuitem" class="dropdown-item download-list" data-format="isbd" href="#">ISBD</a> We c/should test OPACISBD here?
Note that the option is not even listed on the staff counterpart.
Created attachment 128107 [details] [review] Bug 29601: Lists: Test OPACISBD before showing ISBD download Test plan: Check if you see Download/ISBD for a list on OPAC. Clear OPACISBD. Check if the link is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
More than trivial: self signoff
Created attachment 128125 [details] [review] Bug 29601: Lists: Test OPACISBD before showing ISBD download Test plan: Check if you see Download/ISBD for a list on OPAC. Clear OPACISBD. Check if the link is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 128128 [details] [review] Bug 29601: Lists: Test OPACISBD before showing ISBD download Test plan: Check if you see Download/ISBD for a list on OPAC. Clear OPACISBD. Check if the link is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I felt down a rabbit hole and opened bug 29609.
Pushed to master for 22.05, thanks to everybody involved!
(In reply to Fridolin Somers from comment #7) > Pushed to master for 22.05, thanks to everybody involved! Where to ?
(In reply to Marcel de Rooy from comment #8) > (In reply to Fridolin Somers from comment #7) > > Pushed to master for 22.05, thanks to everybody involved! > > Where to ? Found it. Test was still running..
Pushed to 21.11.x for 21.11.01
Pushed to 21.05.x for 21.05.08
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.