It's spread in different places, we could have a BLOCK in an include file to avoid code to be duplicated.
Created attachment 128129 [details] [review] Bug 29609: Centralized code to build the link to a biblio detail page There are 2 prefs that control the default view of biblio detail pages: IntranetBiblioDefaultView for staff and BiblioDefaultView for OPAC. There are as well viewISBD, viewLabeledMARC and viewMARC to allow/don't allow access to those page for staff members. This code need to be in a single place to avoid discrepancy. Test plan: Play with BiblioDefaultView and IntranetBiblioDefaultView and confirm that the links of biblio point to the correct view.
Whaoo super to remove duplicated code. I'll test it.
Created attachment 129618 [details] [review] Bug 29609: Centralized code to build the link to a biblio detail page There are 2 prefs that control the default view of biblio detail pages: IntranetBiblioDefaultView for staff and BiblioDefaultView for OPAC. There are as well viewISBD, viewLabeledMARC and viewMARC to allow/don't allow access to those page for staff members. This code need to be in a single place to avoid discrepancy. Test plan: Play with BiblioDefaultView and IntranetBiblioDefaultView and confirm that the links of biblio point to the correct view. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice bit of clean up here.. signing off
Some parsing errors in the QA test tools: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc FAIL filters missing_filter at line 82 ( [%- this_biblio_href %][% biblionumber | url -%]) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt line 158: unexpected end of input FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/reports/cat_issues_top.tt line 88: unexpected token (ELSE) [% ELSE %] FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc FAIL filters missing_filter at line 34 ( [%- this_biblio_href %][% biblionumber | url -%])
Created attachment 132297 [details] [review] Bug 29609: Centralized code to build the link to a biblio detail page There are 2 prefs that control the default view of biblio detail pages: IntranetBiblioDefaultView for staff and BiblioDefaultView for OPAC. There are as well viewISBD, viewLabeledMARC and viewMARC to allow/don't allow access to those page for staff members. This code need to be in a single place to avoid discrepancy. Test plan: Play with BiblioDefaultView and IntranetBiblioDefaultView and confirm that the links of biblio point to the correct view. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 132372 [details] [review] Bug 29609: Centralized code to build the link to a biblio detail page There are 2 prefs that control the default view of biblio detail pages: IntranetBiblioDefaultView for staff and BiblioDefaultView for OPAC. There are as well viewISBD, viewLabeledMARC and viewMARC to allow/don't allow access to those page for staff members. This code need to be in a single place to avoid discrepancy. Test plan: Play with BiblioDefaultView and IntranetBiblioDefaultView and confirm that the links of biblio point to the correct view. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]