---- Reported by gmcharlt@gmail.com 2009-03-05 07:33:07 ---- A patch of yours pushed to 3.0.x and (as of today) HEAD translated the value_builder templates for UNIMARC to English. However, there are four that are still in French: unimarc_field_128c.tmpl unimarc_field_700-4.tmpl unimarc_leader.tmpl macles.tmpl --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:05 UTC --- This bug was previously known as _bug_ 3007 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3007 Actual time not defined. Setting to 0.0
also unimarc_field_128b.tt unimarc_leader.tt has since been translated.
I checked this on current master and following plugins are still French and need translations: unimarc_field_128b.tt unimarc_field_128c.tmpl unimarc_field_700-4.tmpl macles.tmpl
Bug 10189 takes care of 2 untranslated plugins, that leaves: unimarc_field_700-4.tmpl macles.tmpl
Both plugins still exist untranslated.
Still valid. Note: it would be nice to fix this as the untranslated strings end up in the po files of various languages and cause confusion there.
Created attachment 130269 [details] [review] Bug 30007: Regression tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 130270 [details] [review] Bug 30007: Add Koha::Exceptions::SysPref Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 130271 [details] [review] Bug 30007: Make ->anonymize methods throw an exception if AnonymousPatron is not set This patch makes the ->anonymize methods throw a Koha::Exceptions::SysPref::NotSet exception when trying to anonymize holds and checkouts without AnonymousPatron properly set. To test: 1. Apply the regression tests patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Checkouts.t \ t/db_dependent/Koha/Old/Holds.t \ t/db_dependent/Koha/Old/Hold.t => FAIL: Tests fail, no exception thrown 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Oops. wrong bug! Obsoleted patches
Noting that with the acceptance of the patch for bug 30435 that the only affected template left is unimarc_field_700-4.tt
Created attachment 156700 [details] [review] Bug 3007: Remove unimarc_field_700-4.pl value builder I tried translating it, found it not working and replaced by the annif authorised value list with relator terms/codes. To test: * Make sure the unimarc_field_700-4.pl is no longer listed in frameworks. * Make sure it's not used in the standard frameworks.
Maybe making a risky suggestion here: but after I tried to translate the value builder and fount it not working... and an authorised value list used instead in the sample frameworks. I wonder: maybe we should remove it?
Created attachment 156713 [details] [review] Bug 3007: Remove unimarc_field_700-4.pl value builder I tried translating it, found it not working and replaced by the annif authorised value list with relator terms/codes. To test: * Make sure the unimarc_field_700-4.pl is no longer listed in frameworks. * Make sure it's not used in the standard frameworks. Signed-off-by: David Nind <david@davidnind.com>
(In reply to Katrin Fischer from comment #12) > Maybe making a risky suggestion here: but after I tried to translate the > value builder and fount it not working... and an authorised value list used > instead in the sample frameworks. I wonder: maybe we should remove it? This makes sense to me (with my limited understanding of UNIMARC). An authorized value list seems a much easier way to maintain a standard list of values. Also, I found that IFLA has just recently published a consolidated and freely available manual/description of all the UNIMARC tags and values! (Although not yet endorsed by IFLA, and is licensed with a CC BY 4.0.) https://www.ifla.org/unimarc-updates/unimarc-bibliographic-format-manual-online-ed/ The 7XX tags start at page 642 of the PDF. And the values for $7XX$4 are in Appendix B, these start at page 739. This should make it much easier to update the UNIMARC framework and authorized value lists in the future.
> This makes sense to me (with my limited understanding of UNIMARC). Same for me (including the limited understanding of UNIMARC :P) I asked confirmation in the french mailing list to hear from people to which this speaks more.
Created attachment 157216 [details] [review] Bug 3007: Remove unimarc_field_700-4.pl value builder I tried translating it, found it not working and replaced by the annif authorised value list with relator terms/codes. To test: * Make sure the unimarc_field_700-4.pl is no longer listed in frameworks. * Make sure it's not used in the standard frameworks. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 157217 [details] [review] Bug 3007: Remove unimarc_field_700-4.pl value builder I tried translating it, found it not working and replaced by the qualif authorised value list with relator terms/codes. To test: * Make sure the unimarc_field_700-4.pl is no longer listed in frameworks. * Make sure it's not used in the standard frameworks. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Got one response from Laurence at BibLibre. Plugin's list is indeed incomplete, in many years they never got a request to use the plugin. Which is supposed to take the code, get the label in the limited list from the plugin. And put it in the $8. But that doesn't even work. And with the qualif authorized value, we can the see the label instead of the code. So no expressed need to have the label added in the record. So patch works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.11. Nice work everyone, thanks!
Whaouu old stuff. Still I prefer not backport a remove.