Bug 3007 - Remove untranslated unimarc_field_700-4 value builder
Summary: Remove untranslated unimarc_field_700-4 value builder
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P3 normal (vote)
Assignee: Katrin Fischer
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-05 07:33 UTC by Galen Charlton
Modified: 2023-10-25 07:40 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 30007: Regression tests (6.21 KB, patch)
2022-02-08 09:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30007: Add Koha::Exceptions::SysPref (2.08 KB, patch)
2022-02-08 09:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 30007: Make ->anonymize methods throw an exception if AnonymousPatron is not set (2.94 KB, patch)
2022-02-08 09:47 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 3007: Remove unimarc_field_700-4.pl value builder (6.85 KB, patch)
2023-10-07 19:39 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 3007: Remove unimarc_field_700-4.pl value builder (6.90 KB, patch)
2023-10-08 20:23 UTC, David Nind
Details | Diff | Splinter Review
Bug 3007: Remove unimarc_field_700-4.pl value builder (7.17 KB, patch)
2023-10-16 21:19 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 3007: Remove unimarc_field_700-4.pl value builder (7.17 KB, patch)
2023-10-16 21:22 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:05:18 UTC


---- Reported by gmcharlt@gmail.com 2009-03-05 07:33:07 ----

A patch of yours pushed to 3.0.x and (as of today) HEAD translated the value_builder templates for UNIMARC to English.  However, there are four that are still in French:

unimarc_field_128c.tmpl
unimarc_field_700-4.tmpl
unimarc_leader.tmpl
macles.tmpl



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:05 UTC  ---

This bug was previously known as _bug_ 3007 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3007

Actual time not defined. Setting to 0.0

Comment 1 Owen Leonard 2011-10-25 17:00:26 UTC
also unimarc_field_128b.tt

unimarc_leader.tt has since been translated.
Comment 2 Katrin Fischer 2012-04-03 06:43:37 UTC
I checked this on current master and following plugins are still French and need translations:

unimarc_field_128b.tt
unimarc_field_128c.tmpl
unimarc_field_700-4.tmpl
macles.tmpl
Comment 3 Katrin Fischer 2013-07-14 12:05:21 UTC
Bug 10189 takes care of 2 untranslated plugins, that leaves:

unimarc_field_700-4.tmpl
macles.tmpl
Comment 4 Katrin Fischer 2015-06-06 19:15:05 UTC
Both plugins still exist untranslated.
Comment 5 Katrin Fischer 2018-05-16 00:21:35 UTC
Still valid.

Note: it would be nice to fix this as the untranslated strings end up in the po files of various languages and cause confusion there.
Comment 6 Martin Renvoize 2022-02-08 09:47:27 UTC Comment hidden (obsolete)
Comment 7 Martin Renvoize 2022-02-08 09:47:31 UTC Comment hidden (obsolete)
Comment 8 Martin Renvoize 2022-02-08 09:47:34 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2022-02-08 09:49:12 UTC
Oops. wrong bug! Obsoleted patches
Comment 10 Galen Charlton 2023-01-25 17:07:06 UTC
Noting that with the acceptance of the patch for bug 30435 that the only affected template left is unimarc_field_700-4.tt
Comment 11 Katrin Fischer 2023-10-07 19:39:04 UTC
Created attachment 156700 [details] [review]
Bug 3007: Remove unimarc_field_700-4.pl value builder

I tried translating it, found it not working and replaced
by the annif authorised value list with relator terms/codes.

To test:
* Make sure the unimarc_field_700-4.pl is no longer listed in
  frameworks.
* Make sure it's not used in the standard frameworks.
Comment 12 Katrin Fischer 2023-10-07 19:40:49 UTC
Maybe making a risky suggestion here: but after I tried to translate the value builder and fount it not working... and an authorised value list used instead in the sample frameworks. I wonder: maybe we should remove it?
Comment 13 David Nind 2023-10-08 20:23:39 UTC
Created attachment 156713 [details] [review]
Bug 3007: Remove unimarc_field_700-4.pl value builder

I tried translating it, found it not working and replaced
by the annif authorised value list with relator terms/codes.

To test:
* Make sure the unimarc_field_700-4.pl is no longer listed in
  frameworks.
* Make sure it's not used in the standard frameworks.

Signed-off-by: David Nind <david@davidnind.com>
Comment 14 David Nind 2023-10-08 20:35:28 UTC
(In reply to Katrin Fischer from comment #12)
> Maybe making a risky suggestion here: but after I tried to translate the
> value builder and fount it not working... and an authorised value list used
> instead in the sample frameworks. I wonder: maybe we should remove it?

This makes sense to me (with my limited understanding of UNIMARC).

An authorized value list seems a much easier way to maintain a standard list of values.

Also, I found that IFLA has just recently published a consolidated and freely available manual/description of all the UNIMARC tags and values! (Although not yet endorsed by IFLA, and is licensed with a CC BY 4.0.)
https://www.ifla.org/unimarc-updates/unimarc-bibliographic-format-manual-online-ed/

The 7XX tags start at page 642 of the PDF. And the values for $7XX$4 are in Appendix B, these start at page 739.

This should make it much easier to update the UNIMARC framework and authorized value lists in the future.
Comment 15 Victor Grousset/tuxayo 2023-10-10 23:35:14 UTC
> This makes sense to me (with my limited understanding of UNIMARC).

Same for me (including the limited understanding of UNIMARC :P)

I asked confirmation in the french mailing list to hear from people to which this speaks more.
Comment 16 Victor Grousset/tuxayo 2023-10-16 21:19:20 UTC
Created attachment 157216 [details] [review]
Bug 3007: Remove unimarc_field_700-4.pl value builder

I tried translating it, found it not working and replaced
by the annif authorised value list with relator terms/codes.

To test:
* Make sure the unimarc_field_700-4.pl is no longer listed in
  frameworks.
* Make sure it's not used in the standard frameworks.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 17 Victor Grousset/tuxayo 2023-10-16 21:22:44 UTC
Created attachment 157217 [details] [review]
Bug 3007: Remove unimarc_field_700-4.pl value builder

I tried translating it, found it not working and replaced
by the qualif authorised value list with relator terms/codes.

To test:
* Make sure the unimarc_field_700-4.pl is no longer listed in
  frameworks.
* Make sure it's not used in the standard frameworks.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 18 Victor Grousset/tuxayo 2023-10-16 21:35:42 UTC
Got one response from Laurence at BibLibre. Plugin's list is indeed incomplete, in many years they never got a request to use the plugin. Which is supposed to take the code, get the label in the limited list from the plugin. And put it in the $8. But that doesn't even work. And with the qualif authorized value, we can the see the label instead of the code. So no expressed need to have the label added in the record.

So patch works, makes sense, QA script happy, code looks good, passing QA :)
Comment 19 Tomás Cohen Arazi 2023-10-18 18:43:40 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 20 Fridolin Somers 2023-10-25 07:40:36 UTC
Whaouu old stuff.
Still I prefer not backport a remove.