This is part of the refactoring happening in bug 30975
Created attachment 146140 [details] [review] Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 146808 [details] [review] Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before
Created attachment 149004 [details] [review] Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com>
How I tested ~~~~~~~~~~~~ 1. Remove the qualif authorized value list from 700$4 and add the unimarc_field_700-4.pl cataloging plugin to the UNIMARC bibliographic framework in KTD. 2. Edit a bibliographic record. 3. Select the tag editor for the subfield. 4. Options and values should be the same before and after the patch is applied. Description ~~~~~~~~~~~ This is a standard UNIMARC value builder for a subfield - it displays a form to select the values that make up the subfield. Note: With the cataloguing plugin there are a limited number of options available (5) compared with using the qualif authorized values list (Function codes (author, editor, collaborator, etc.) used in UNIMARC 7XX $4 (French)). Also, the text on the form is written in French. Maybe this needs to be reviewed by someone familiar with UNIMARC to determine whether this plugin is still current.
Created attachment 150093 [details] [review] Bug 32874: Fix cataloguing/value_builder/unimarc_field_700-4.pl Use event parameter This is part of the refactoring happening in bug 30975 Test plan: 1. Verify that the plugin continues to work as before Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Just an FYI - Bug 3007 will now remove this value builder.