Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875
Created attachment 130808 [details] [review] Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected
All the steps worked except #5. On step 5 - I created a new suggestion and saved it but the screen defaulted to the Accepted tab instead of the Pending tab. Also, editing and saving a suggestion defaulted to the Accepted tab instead of Pending. Since the Pending tab is the most important one I think it should be the first tab followed by Accepted and then any other tabs a library uses.
Created attachment 134431 [details] [review] Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected
I've changed how I do the fix, changing directly the perl so that pending is always the first tab. And added step 8 to test plan
For me, after applying the patch and adding some suggestions, I no longer get any tabs displaying for suggestions by status (tried in Firefox and Google Chrome). I can post a screenshot if that doesn't make senses.
(In reply to David Nind from comment #5) > For me, after applying the patch and adding some suggestions, I no longer > get any tabs displaying for suggestions by status (tried in Firefox and > Google Chrome). > > I can post a screenshot if that doesn't make senses. Ah indeed typo I repush patch
Created attachment 134478 [details] [review] Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected
Created attachment 134485 [details] [review] Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected Signed-off-by: David Nind <david@davidnind.com>
Looking here
This appears to work, but can you clarify where the behavior changed? When I test without the patches, the pending tab is also always the one displayed. >7) Edit an existing suggestion, click on '<< Back to suggestions' >=> You see pending tab selected This one could be debatable, but it behaves like this already in my tests. Someone might expect that you see the same tab that you edited the suggestion from. So if you edit an accepted suggestion, you return to this tab. (absolute not blocker)
Never mind, I found my mistake.
Created attachment 134714 [details] [review] Bug 30127: By default show pending suggestions tab Pending suggestions are the most important ones in links pointing to suggestions. This tab should be the default one, like did Bug 7875 Changing order in perl code seems really difficult because it is a generic code using GetDistinctValues() Test plan : 1) Create some suggetions, accept some of them 2) In staff interface, click on 'More > Suggestions' => You see pending tab selected 3) In left menu, click on 'Suggestions' under 'Late orders' => You see pending tab selected 4) In left menu, use a filter, then click on '[clear]' => You see pending tab selected 5) Create a suggestion, click on 'cancel' => You see pending tab selected 6) Create a suggestion, click on 'Suggestions' in breadcrumbs => You see pending tab selected 7) Edit an existing suggestion, click on '<< Back to suggestions' => You see pending tab selected 8) Create a suggestion, click on 'Submit your suggestion' => You see pending tab selected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 22.05, thanks to everybody involved [U+1F984]