The pending approvals count on the staff client home page directs to the "accepted" tab of suggestion management instead of the "pending" tab. It's really a minor thing, but it did manage to confuse several people here, so thought I'd report it.
Created attachment 16000 [details] [review] Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions Pending suggestion link from staff client home directs to accepted suggestions instead of pending suggestions. This patch changes the link so that it directs to pending suggestions. To test : 1 - create 2 suggestions, accept 1 of them 2 - click on the link on home page M. Saby
Created attachment 16046 [details] [review] [SIGNED-OFF] Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions Pending suggestion link from staff client home directs to accepted suggestions instead of pending suggestions. This patch changes the link so that it directs to pending suggestions. To test : 1 - create 2 suggestions, accept 1 of them 2 - click on the link on home page Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 16201 [details] [review] Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions Pending suggestion link from staff client home directs to accepted suggestions instead of pending suggestions. This patch changes the link so that it directs to pending suggestions. To test : 1 - create 2 suggestions, accept 1 of them 2 - click on the link on home page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Trivial change. Should normally work. (I had somehow 2 old suggestions that were counted on the home page, but were not displayed under Pending. Could not reproduce. After deleting them and adding new ones, no problems.) Passed QA
On home page, I think you see all pending suggestions for all branches... It could be fixed in an other patch if you think it is not the good behavior. Maybe home page could say "XX suggestions for all branches, and YY for your branch" ? M. Saby
(In reply to comment #5) > On home page, I think you see all pending suggestions for all branches... > It could be fixed in an other patch if you think it is not the good behavior. > Maybe home page could say "XX suggestions for all branches, and YY for your > branch" ? > > M. Saby Do not know if they were from another branch and I deleted them in mysql :) If you could work further on this, great. But open up a new report for that. This patch can go in as-is IMO.
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12