Bug 7875 - Pending suggestion link (the numbers) from staff client home directs to accepted suggestions instead of pending
Summary: Pending suggestion link (the numbers) from staff client home directs to accep...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Mathieu Saby
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 7259 30127
  Show dependency treegraph
 
Reported: 2012-04-02 16:56 UTC by Liz Rea
Modified: 2022-02-18 03:50 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions (1.47 KB, patch)
2013-03-09 16:57 UTC, Mathieu Saby
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions (1.57 KB, patch)
2013-03-11 17:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions (1.62 KB, patch)
2013-03-17 15:27 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2012-04-02 16:56:37 UTC
The pending approvals count on the staff client home page directs to the "accepted" tab of suggestion management instead of the "pending" tab. 

It's really a minor thing, but it did manage to confuse several people here, so thought I'd report it.
Comment 1 Mathieu Saby 2013-03-09 16:57:55 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-03-11 17:45:43 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-03-17 15:27:40 UTC
Created attachment 16201 [details] [review]
Bug 7875: Change the pending suggestion link in home page so that it directs to pending suggestions

Pending suggestion link from staff client home directs to accepted
suggestions instead of pending suggestions. This patch changes the link
so that it directs to pending suggestions.

To test :
1 - create 2 suggestions, accept 1 of them
2 - click on the link on home page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2013-03-17 15:29:55 UTC
QA Comment:
Trivial change. Should normally work. (I had somehow 2 old suggestions that were counted on the home page, but were not displayed under Pending. Could not reproduce. After deleting them and adding new ones, no problems.) 

Passed QA
Comment 5 Mathieu Saby 2013-03-17 15:41:46 UTC
On home page, I think you see all pending suggestions for all branches...
It could be fixed in an other patch if you think it is not the good behavior.
Maybe home page could say "XX suggestions for all branches, and YY for your branch" ?

M. Saby
Comment 6 Marcel de Rooy 2013-03-17 15:51:04 UTC
(In reply to comment #5)
> On home page, I think you see all pending suggestions for all branches...
> It could be fixed in an other patch if you think it is not the good behavior.
> Maybe home page could say "XX suggestions for all branches, and YY for your
> branch" ?
> 
> M. Saby

Do not know if they were from another branch and I deleted them in mysql :)
If you could work further on this, great.
But open up a new report for that.
This patch can go in as-is IMO.
Comment 7 Jared Camins-Esakov 2013-03-20 12:41:12 UTC
This patch has been pushed to master.
Comment 8 Chris Cormack 2013-03-29 06:49:11 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12