Patrons will not bother to change to their library. Can we make this default to the logged in patron's home library?
Created attachment 131340 [details] [review] Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library.
Created attachment 131341 [details] [review] Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
I would consider this a separate issue, and will file a separate bug, but if you add branchcode to the sys pref OPACSuggestionMandatoryFields the dropdown should default to an empty value in order to force the user into making a choice.
I believe this did default to the patron's home library in the past, which would make this a regression.
Created attachment 131414 [details] [review] Bug 30220: Purchase suggestion defaults to first library This patch updates the OPAC suggestions form to update the variable used to pre-select the logged-in user's library. To test, apply the patch and make sure the "suggestion" preference is set to "Allow." - Log in to the OPAC and click "your purchase suggestions" in the sidebar menu on your summary page. - Click "New purchase suggestion." - The selected library should match the logged-in user's home library. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Lucas Gass from comment #3) > I would consider this a separate issue, and will file a separate bug, but if > you add branchcode to the sys pref OPACSuggestionMandatoryFields the > dropdown should default to an empty value in order to force the user into > making a choice. Please do! Also tested this with an Anonymous suggestoin and there it still defaults to the first entry, which seems ok given the use case.
(In reply to Katrin Fischer from comment #6) > (In reply to Lucas Gass from comment #3) > > I would consider this a separate issue, and will file a separate bug, but if > > you add branchcode to the sys pref OPACSuggestionMandatoryFields the > > dropdown should default to an empty value in order to force the user into > > making a choice. > > Please do! > > Also tested this with an Anonymous suggestoin and there it still defaults to > the first entry, which seems ok given the use case. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30243
Pushed to master for 22.05, thanks to everybody involved [U+1F984]
Pushed to 21.11.x for 21.11.05
Pushed to 21.05.x for 21.05.14
(In reply to Andrew Fuerste-Henry from comment #10) > Pushed to 21.05.x for 21.05.14 Cool beans! Thanks Andrew!
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.