I propose to reformat the lists template in the staff interface (shelves.tt) so that it has consistent spacing and indentation.
Created attachment 140348 [details] [review] Bug 30304: Reindent lists template in the staff interface This patch performs general template cleanup to the lists template: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and test all aspects of the lists pages, including: - Viewing the list of public and private lists. - List of lists DataTable controls: Paging, filtering, sorting. - Add, edit and delete lists. - View list contents. - Remove titles from a list. - Place hold from a list. - Add items to a list. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag. The only changes you see should be split lines.
Created attachment 140349 [details] [review] Bug 30304: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality.
Created attachment 140395 [details] [review] Bug 30304: Reindent lists template in the staff interface This patch performs general template cleanup to the lists template: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and test all aspects of the lists pages, including: - Viewing the list of public and private lists. - List of lists DataTable controls: Paging, filtering, sorting. - Add, edit and delete lists. - View list contents. - Remove titles from a list. - Place hold from a list. - Add items to a list. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag. The only changes you see should be split lines. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 140396 [details] [review] Bug 30304: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141181 [details] [review] k
I didn't realize that I had already signed off...
These changes look good. The diff is is good. I also checked this through the W3 HTML validator. There is some warnings that are new to me: "Self-closing tag syntax in text/html documents is widely discouraged; it’s unnecessary and interacts badly with other HTML features" If we need to change the self ending tags I think we should do so in a separate bug report. Or maybe, since it is a warning, it is not necessary to address? Either way, I am passing QA on this one.
Created attachment 141271 [details] [review] Bug 30304: Reindent lists template in the staff interface This patch performs general template cleanup to the lists template: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and test all aspects of the lists pages, including: - Viewing the list of public and private lists. - List of lists DataTable controls: Paging, filtering, sorting. - Add, edit and delete lists. - View list contents. - Remove titles from a list. - Place hold from a list. - Add items to a list. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag. The only changes you see should be split lines. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 141272 [details] [review] Bug 30304: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Pushed to master for 22.11. Nice work everyone, thanks!