Bug 30309 - Convert lists tabs in the staff interface to Bootstrap
Summary: Convert lists tabs in the staff interface to Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 30304
Blocks:
  Show dependency treegraph
 
Reported: 2022-03-17 13:57 UTC by Owen Leonard
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 30309: Convert lists tabs in the staff interface to Bootstrap (8.45 KB, patch)
2022-09-09 13:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 30309: Convert lists tabs in the staff interface to Bootstrap (8.50 KB, patch)
2022-09-11 13:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 30309: Convert lists tabs in the staff interface to Bootstrap (8.56 KB, patch)
2022-10-03 15:15 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2022-03-17 13:57:20 UTC
Continuing the process of phasing out jQueryUI, this patch will replace jQueryUI tabs in the lists template with Bootstrap.
Comment 1 Owen Leonard 2022-09-09 13:09:19 UTC
Created attachment 140375 [details] [review]
Bug 30309: Convert lists tabs in the staff interface to Bootstrap

This patch updates the staff interface lists page to use Bootstrap tabs
instead of jQueryUI.

To test, apply the patch and go to Lists.

- Test that the public and private tabs work correctly.
- Test that other lists functionality still works as expected.
- Confirm that adding the "public" URL parameter works to trigger the
  "Public lists" tab by default:

  /cgi-bin/koha/virtualshelves/shelves.pl?public=1
Comment 2 Katrin Fischer 2022-09-11 13:09:56 UTC
Created attachment 140394 [details] [review]
Bug 30309: Convert lists tabs in the staff interface to Bootstrap

This patch updates the staff interface lists page to use Bootstrap tabs
instead of jQueryUI.

To test, apply the patch and go to Lists.

- Test that the public and private tabs work correctly.
- Test that other lists functionality still works as expected.
- Confirm that adding the "public" URL parameter works to trigger the
  "Public lists" tab by default:

  /cgi-bin/koha/virtualshelves/shelves.pl?public=1

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Lucas Gass 2022-10-03 15:14:11 UTC
Changes all look good. QA script is happy. HTML all appears to be valid.
Comment 4 Lucas Gass 2022-10-03 15:15:12 UTC
Created attachment 141273 [details] [review]
Bug 30309: Convert lists tabs in the staff interface to Bootstrap

This patch updates the staff interface lists page to use Bootstrap tabs
instead of jQueryUI.

To test, apply the patch and go to Lists.

- Test that the public and private tabs work correctly.
- Test that other lists functionality still works as expected.
- Confirm that adding the "public" URL parameter works to trigger the
  "Public lists" tab by default:

  /cgi-bin/koha/virtualshelves/shelves.pl?public=1

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2022-10-03 15:42:00 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!