The table generated at course-details.pl has columns for both Home library and Holding library, but course_reserves_table in the Table settings admin area only has a single toggle for 'library'. Hiding 'library' hides the Home library column. Anything after that is off by one. Hiding 'staff_note' actually hides the Holding library column, 'link' hides Public note, etc.
Created attachment 135736 [details] [review] Bug 30585: Fix library options on table settings for course_reserves_table The table on course-details.pl has columns for both home library and jolding library, but course_reserves_table in the Table configuration admin area only has a single toggle for 'library'. Hiding 'library' hides the home library column. Anything after that is off by one. Hiding 'staff_note' actually hides the holding library column, 'link' hides Public note, etc. To test: - Add a course and some course reserves - Go to table configuration and hide 'staff note' - Look at the list of course reserves for your course - Verify the wrong column was hidden - Apply patch - The configuration area now shows holding_library and home_library as separate options. - Change the settings and verify everything now hides/displays correctly.
While attemping to sign off I noticed another problem, so I filed Bug 30911
Created attachment 135739 [details] [review] Bug 30585: Fix library options on table settings for course_reserves_table The table on course-details.pl has columns for both home library and jolding library, but course_reserves_table in the Table configuration admin area only has a single toggle for 'library'. Hiding 'library' hides the home library column. Anything after that is off by one. Hiding 'staff_note' actually hides the holding library column, 'link' hides Public note, etc. To test: - Add a course and some course reserves - Go to table configuration and hide 'staff note' - Look at the list of course reserves for your course - Verify the wrong column was hidden - Apply patch - The configuration area now shows holding_library and home_library as separate options. - Change the settings and verify everything now hides/displays correctly. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 135878 [details] [review] Bug 30585: Fix library options on table settings for course_reserves_table The table on course-details.pl has columns for both home library and jolding library, but course_reserves_table in the Table configuration admin area only has a single toggle for 'library'. Hiding 'library' hides the home library column. Anything after that is off by one. Hiding 'staff_note' actually hides the holding library column, 'link' hides Public note, etc. To test: - Add a course and some course reserves - Go to table configuration and hide 'staff note' - Look at the list of course reserves for your course - Verify the wrong column was hidden - Apply patch - The configuration area now shows holding_library and home_library as separate options. - Change the settings and verify everything now hides/displays correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.03