It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface!
Created attachment 135589 [details] [review] Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email" It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface! Test Plan: 1) Set SMSSendDriver to anything except "Email" 2) Note the SMS Provider pulldown shows in the patron editor 3) Apply this patch 4) Reload the page, SMS Provider id should now be gone 5) Set SMSSendDriver to "Email" 6) Reload the page, SMS Provider should now be shown
Created attachment 135612 [details] [review] Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email" It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface! Test Plan: 1) Set SMSSendDriver to anything except "Email" 2) Note the SMS Provider pulldown shows in the patron editor 3) Apply this patch 4) Reload the page, SMS Provider id should now be gone 5) Set SMSSendDriver to "Email" 6) Reload the page, SMS Provider should now be shown Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 135721 [details] [review] Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set to "Email" It appears that in my original submission ( Bug 9021 ), I hid the SMS provider selector unless the SMS::Send driver was set to "Email", but only on the OPAC, not on the staff interface! Test Plan: 1) Set SMSSendDriver to anything except "Email" 2) Note the SMS Provider pulldown shows in the patron editor 3) Apply this patch 4) Reload the page, SMS Provider id should now be gone 5) Set SMSSendDriver to "Email" 6) Reload the page, SMS Provider should now be shown Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 135722 [details] [review] Bug 30891: (QA follow-up) Add check to patron details page Adds a similar check to the patron details shown when selecting the details tab in the patron account in the staff interface. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 22.11. Nice work everyone, thanks!
Backported to 22.05.x for 22.05.03
This has the potential for libraries to lose sms_providers data. Can this please be backported?
Noted for 21.05, hopefully it will be in 21.11 before the next and last release of 21.05