Bug 31166 - Digest option is not selectable for phone when PhoneNotification is enabled
Summary: Digest option is not selectable for phone when PhoneNotification is enabled
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 32655
  Show dependency treegraph
 
Reported: 2022-07-15 18:10 UTC by Kyle M Hall
Modified: 2023-12-28 20:44 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.01, 21.11.16


Attachments
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled (5.13 KB, patch)
2022-07-15 18:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled (5.19 KB, patch)
2022-07-15 21:00 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31166: (QA follow-up) Remove debugging lines (1.13 KB, patch)
2022-08-12 15:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31166: (QA follow-up) Implement on OPAC side (3.28 KB, patch)
2022-08-12 15:08 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled (5.25 KB, patch)
2022-08-12 15:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31166: (QA follow-up) Remove debugging lines (1.19 KB, patch)
2022-08-12 15:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31166: (QA follow-up) Implement on OPAC side (3.33 KB, patch)
2022-08-12 15:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled (8.53 KB, patch)
2022-12-13 18:02 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2022-07-15 18:10:13 UTC
Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled.
Comment 1 Kyle M Hall 2022-07-15 18:13:00 UTC
Created attachment 137788 [details] [review]
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled

Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled.

Test Plan:
1) Apply this patch
2) Enable TalkingTechPhoneNotification
3) Verify behavior hasn't changed
4) Disable TalkingTechPhoneNotification, Enable PhoneNotification
5) Note disgest option is now selectable if only phone is selected
Comment 2 ByWater Sandboxes 2022-07-15 21:00:02 UTC
Created attachment 137789 [details] [review]
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled

Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled.

Test Plan:
1) Apply this patch
2) Enable TalkingTechPhoneNotification
3) Verify behavior hasn't changed
4) Disable TalkingTechPhoneNotification, Enable PhoneNotification
5) Note disgest option is now selectable if only phone is selected

Signed-off-by: Evelyn Hartline <evelyn@bywatersolutions.com>
Comment 3 Katrin Fischer 2022-08-12 14:15:01 UTC
This works really nicely in the staff interface, but we'll need a follow-up for the OPAC please to make behavior match.
Comment 4 Katrin Fischer 2022-08-12 14:16:22 UTC
Ah, also some left over debugging code needs to be removed:
console.log("TEST: " + PhoneNotification );
...
Comment 5 Kyle M Hall 2022-08-12 15:08:26 UTC
Created attachment 139061 [details] [review]
Bug 31166: (QA follow-up) Remove debugging lines
Comment 6 Kyle M Hall 2022-08-12 15:08:35 UTC
Created attachment 139062 [details] [review]
Bug 31166: (QA follow-up) Implement on OPAC side
Comment 7 Katrin Fischer 2022-08-12 15:24:21 UTC
Created attachment 139063 [details] [review]
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled

Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled.

Test Plan:
1) Apply this patch
2) Enable TalkingTechPhoneNotification
3) Verify behavior hasn't changed
4) Disable TalkingTechPhoneNotification, Enable PhoneNotification
5) Note disgest option is now selectable if only phone is selected

Signed-off-by: Evelyn Hartline <evelyn@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 8 Katrin Fischer 2022-08-12 15:24:25 UTC
Created attachment 139064 [details] [review]
Bug 31166: (QA follow-up) Remove debugging lines

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 9 Katrin Fischer 2022-08-12 15:24:29 UTC
Created attachment 139065 [details] [review]
Bug 31166: (QA follow-up) Implement on OPAC side

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 10 Tomás Cohen Arazi 2022-12-13 18:00:42 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Tomás Cohen Arazi 2022-12-13 18:02:31 UTC
Created attachment 144556 [details] [review]
Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled

Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled.

Test Plan:
1) Apply this patch
2) Enable TalkingTechPhoneNotification
3) Verify behavior hasn't changed
4) Disable TalkingTechPhoneNotification, Enable PhoneNotification
5) Note disgest option is now selectable if only phone is selected

Signed-off-by: Evelyn Hartline <evelyn@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Bug 31166: (QA follow-up) Remove debugging lines

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Bug 31166: (QA follow-up) Implement on OPAC side

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Squashed by RM
Comment 12 Martin Renvoize 2022-12-15 13:57:48 UTC
Nice work everyone!

Pushed to 22.11.x for the next release
Comment 13 Arthur Suzuki 2023-01-26 10:26:56 UTC
applied to 21.11.x for 21.11.16
Comment 14 wainuiwitikapark 2023-03-15 01:31:00 UTC
Not backported to 21.05.x