Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled.
Created attachment 137788 [details] [review] Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled. Test Plan: 1) Apply this patch 2) Enable TalkingTechPhoneNotification 3) Verify behavior hasn't changed 4) Disable TalkingTechPhoneNotification, Enable PhoneNotification 5) Note disgest option is now selectable if only phone is selected
Created attachment 137789 [details] [review] Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled. Test Plan: 1) Apply this patch 2) Enable TalkingTechPhoneNotification 3) Verify behavior hasn't changed 4) Disable TalkingTechPhoneNotification, Enable PhoneNotification 5) Note disgest option is now selectable if only phone is selected Signed-off-by: Evelyn Hartline <evelyn@bywatersolutions.com>
This works really nicely in the staff interface, but we'll need a follow-up for the OPAC please to make behavior match.
Ah, also some left over debugging code needs to be removed: console.log("TEST: " + PhoneNotification ); ...
Created attachment 139061 [details] [review] Bug 31166: (QA follow-up) Remove debugging lines
Created attachment 139062 [details] [review] Bug 31166: (QA follow-up) Implement on OPAC side
Created attachment 139063 [details] [review] Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled. Test Plan: 1) Apply this patch 2) Enable TalkingTechPhoneNotification 3) Verify behavior hasn't changed 4) Disable TalkingTechPhoneNotification, Enable PhoneNotification 5) Note disgest option is now selectable if only phone is selected Signed-off-by: Evelyn Hartline <evelyn@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 139064 [details] [review] Bug 31166: (QA follow-up) Remove debugging lines Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 139065 [details] [review] Bug 31166: (QA follow-up) Implement on OPAC side Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Created attachment 144556 [details] [review] Bug 31166: Digest option is not selectable for phone when PhoneNotification is enabled Digests are not available via Talking Tech, but the artificial limit should not be in place for the non-TT phone notices. If only phone is selected, digest remains disabled. Test Plan: 1) Apply this patch 2) Enable TalkingTechPhoneNotification 3) Verify behavior hasn't changed 4) Disable TalkingTechPhoneNotification, Enable PhoneNotification 5) Note disgest option is now selectable if only phone is selected Signed-off-by: Evelyn Hartline <evelyn@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Bug 31166: (QA follow-up) Remove debugging lines Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Bug 31166: (QA follow-up) Implement on OPAC side Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Squashed by RM
Nice work everyone! Pushed to 22.11.x for the next release
applied to 21.11.x for 21.11.16
Not backported to 21.05.x