Created attachment 145363 [details] Your variables are showing If you collapse the patron messaging preferences when editing the patron, you see two variables listed above the table in the section. See attachment.
There is a script that is being toggled to 'display:block': <script> var TalkingTechItivaPhoneNotification = [% Koha.Preference('TalkingTechItivaPhoneNotification') || 0 | html %]; var PhoneNotification = [% Koha.Preference('PhoneNotification') || 0 | html %]; </script> We could change the jQuery selector but maybe it is easier to move the script to somewhere more appropriate.
The script is coming from the messaging-preference-from.inc which is included in these templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Created attachment 145367 [details] [review] Bug 32655: Move phone and itiva variables into templates To test: 1. Go to a patron record or create a new one. 2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. 3. Notice the variables. 4. Apply patch 5. Try steps 1 & 2 again, no varibales. 6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. 7. Go to Administration > Patron categories and try step 6 there as well.
Created attachment 145374 [details] [review] Bug 32655: Move phone and itiva variables into templates To test: 1. Go to a patron record or create a new one. 2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. 3. Notice the variables. 4. Apply patch 5. Try steps 1 & 2 again, no varibales. 6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. 7. Go to Administration > Patron categories and try step 6 there as well. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145939 [details] [review] Bug 32655: Move phone and itiva variables into templates To test: 1. Go to a patron record or create a new one. 2. Toggle the 'Patron messaging preferences' fieldset so it is hidden. 3. Notice the variables. 4. Apply patch 5. Try steps 1 & 2 again, no varibales. 6. Attempt to toggle on/off options for email/sms. When email/sms are off the digest option next to it should be disabled. 7. Go to Administration > Patron categories and try step 6 there as well. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
No regressions, cleanup works. Passing QA
LOL
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.10
applied to 21.11.x for 21.11.16
Not backported to 21.05.x