While working on bug 31154 I stumbled on problem described above. As it states I'm unable to save authorised value to frameworks subfields and was wondering is anyone able to repeat this. I suspect that this is caused by changes made in bug 29001, before it variable $authorised_value in marc_subfields_structure.pl is succesfully filled with value indented to be saved. After applying bug again $authorised_value is undef. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty
There seems to be a minor typo on marc_subfields_structure.pl, >$input->param("authorised_values_$id") should be >$input->param("authorised_value_$id")
Created attachment 138119 [details] [review] Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy
Created attachment 138125 [details] [review] Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Created attachment 138231 [details] [review] Bug 31238: Fix typo in marc_subfields_structure.pl After bug 29001 one is unable to save authorised value to frameworks subfields. This is caused by minor typo in marc_subfields_structure.pl. To test: 1. Edit e.g. default frameworks subfield 952$8 2. Add or change fields authorised value 3. Save your changes => note that on subfield listing there is no mention that 952$8 is linked to any authorised value => if you edit 952$8 authorised value input is empty 4. Apply this patch. 5. Repeat steps 1.-3. => authorised value should now be saved Sponsored-by: Koha-Suomi Oy Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, QA script happy, code looks good, passing QA :) Severity upped to major. Feel free to change if that's too much. Surely that's at least normal severity.
Pushed to master for 22.11. Nice work everyone, thanks!
Lucas, can you please check if this is needed in 22.05 (see comment on bug 29001?
Backported to 22.05.x for 22.05.06
I don't reproduce the issue on 21.11.x branch. Also bz29001 was not applied there so maybe that one is not needed for backport. Won't backport unless asked to.