Bug 31869 - Unable to save thesaurus value to frameworks subfields
Summary: Unable to save thesaurus value to frameworks subfields
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 29001 31238
Blocks:
  Show dependency treegraph
 
Reported: 2022-10-19 11:19 UTC by Nick Clemens
Modified: 2023-06-08 22:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.08


Attachments
Bug 31869: Unable to save thesaurus value to frameworks subfields (2.14 KB, patch)
2022-10-19 11:23 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31869: Unable to save thesaurus value to frameworks subfields (1.55 KB, patch)
2022-10-20 13:28 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 31869: Unable to save thesaurus value to frameworks subfields (1.61 KB, patch)
2022-10-24 10:31 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-10-19 11:19:28 UTC
Similar to bug 31238. I checked the rest of the form, seems to just be this field

To test:
1. Edit e.g. default frameworks subfield 952$8
2. Add or change fields thesaurus value
3. Save your changes
=> note that on subfield listing there is no mention that 952$8 is linked to any thesaurus
=> if you edit 952$8 thesaurus input is empty
Comment 1 Nick Clemens 2022-10-19 11:23:39 UTC
Created attachment 142147 [details] [review]
Bug 31869: Unable to save thesaurus value to frameworks subfields

This patch correct a typo authtypecodes for authtypecode

To test:
1. Edit e.g. default frameworks subfield 100$a
2. Add or change fields thesaurus value
3. Save your changes
   => note that on subfield listing there is no mention that 100$a is linked to any thesaurus
   => if you edit 100$a thesaurus input is empty
4. Apply patch
5. Edit subfield 100$a and set a thesaurus value
6. Confirm it saves and displays correctly

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 2 Nick Clemens 2022-10-19 11:24:09 UTC
Self SO, straight to QA - bad bug, easy fix
Comment 3 Nick Clemens 2022-10-20 13:28:05 UTC
Created attachment 142244 [details] [review]
Bug 31869: Unable to save thesaurus value to frameworks subfields

This patch correct a typo authtypecodes for authtypecode

To test:
1. Edit e.g. default frameworks subfield 100$a
2. Add or change fields thesaurus value
3. Save your changes
   => note that on subfield listing there is no mention that 100$a is linked to any thesaurus
   => if you edit 100$a thesaurus input is empty
4. Apply patch
5. Edit subfield 100$a and set a thesaurus value
6. Confirm it saves and displays correctly

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Martin Renvoize 2022-10-24 10:31:24 UTC
Created attachment 142477 [details] [review]
Bug 31869: Unable to save thesaurus value to frameworks subfields

This patch correct a typo authtypecodes for authtypecode

To test:
1. Edit e.g. default frameworks subfield 100$a
2. Add or change fields thesaurus value
3. Save your changes
   => note that on subfield listing there is no mention that 100$a is linked to any thesaurus
   => if you edit 100$a thesaurus input is empty
4. Apply patch
5. Edit subfield 100$a and set a thesaurus value
6. Confirm it saves and displays correctly

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Tomás Cohen Arazi 2022-10-24 14:56:01 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Lucas Gass 2022-12-05 21:48:44 UTC
Backported to 22.05.x for upcoming 22.05.08
Comment 7 Arthur Suzuki 2022-12-16 14:31:33 UTC
this one conflicts when trying to apply to 21.11.
Plus dependencies not met for some bugs.
Won't backport.