Bug 31262 - Curbside pickups - disable dates without slots
Summary: Curbside pickups - disable dates without slots
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement with 2 votes (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 30650
Blocks: 32653
  Show dependency treegraph
 
Reported: 2022-07-29 14:32 UTC by Jonathan Druart
Modified: 2023-06-08 22:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31262: Disable dates in the past for curbside pickups (6.43 KB, patch)
2022-07-31 06:35 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31262: Curbside pickup - Remove day without slots (3.00 KB, patch)
2022-11-04 14:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31262: Curbside pickup - Remove day without slots (3.05 KB, patch)
2022-11-04 14:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31262: Curbside pickup - Remove day without slots (3.10 KB, patch)
2022-11-04 22:49 UTC, David Nind
Details | Diff | Splinter Review
Bug 31262: Curbside pickup - Remove day without slots (3.15 KB, patch)
2022-11-10 00:47 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-07-29 14:32:31 UTC
We could remove from the date picker widget the dates that do not have available slots.
Comment 1 Jonathan Druart 2022-07-31 06:35:46 UTC
Created attachment 138403 [details] [review]
Bug 31262: Disable dates in the past for curbside pickups

When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.

Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.

QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).

Sponsored-by: Association KohaLa - https://koha-fr.org/
Comment 2 Jonathan Druart 2022-11-04 14:10:20 UTC
Created attachment 143211 [details] [review]
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget
Comment 3 Jonathan Druart 2022-11-04 14:10:57 UTC
Created attachment 143212 [details] [review]
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget

Sponsored-by: Association KohaLa - https://koha-fr.org/
Comment 4 David Nind 2022-11-04 22:49:40 UTC
Created attachment 143294 [details] [review]
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2022-11-10 00:47:43 UTC
Created attachment 143610 [details] [review]
Bug 31262: Curbside pickup - Remove day without slots

We disable dates from the date picker that do not have slots defined in
the configuration.

Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.

Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2022-11-10 13:05:42 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!