Bug 32653 - Curbside pickups - wrong dates available at the OPAC
Summary: Curbside pickups - wrong dates available at the OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on: 31262
Blocks:
  Show dependency treegraph
 
Reported: 2023-01-17 16:30 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32653: Fix curbside pickup if configured on more than 1 branch (2.16 KB, patch)
2023-01-17 16:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32653: Fix curbside pickup if configured on more than 1 branch (2.20 KB, patch)
2023-01-17 18:56 UTC, David Nind
Details | Diff | Splinter Review
Bug 32653: Fix curbside pickup if configured on more than 1 branch (2.26 KB, patch)
2023-02-21 12:57 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-01-17 16:30:35 UTC
If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day.

We are always selecting the days for the last branch.
Comment 1 Jonathan Druart 2023-01-17 16:31:33 UTC
Created attachment 145362 [details] [review]
Bug 32653: Fix curbside pickup if configured on more than 1 branch

If curbside pickup is configured on more than 1 branch, the calendar
will not display the correct day.

We are always selecting the days for the last branch.

Test plan:
Configure curbside pickup for
CPL Monday 8:12
FPL Tuesday 12:15

Login at the opac, select CPL, notice Tuesday are available

Apply the patch and confirm all is working correctly now.
Comment 2 David Nind 2023-01-17 18:56:43 UTC
Created attachment 145368 [details] [review]
Bug 32653: Fix curbside pickup if configured on more than 1 branch

If curbside pickup is configured on more than 1 branch, the calendar
will not display the correct day.

We are always selecting the days for the last branch.

Test plan:
Configure curbside pickup for
CPL Monday 8:12
FPL Tuesday 12:15

Login at the opac, select CPL, notice Tuesday are available

Apply the patch and confirm all is working correctly now.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-01-17 19:17:33 UTC
Testing notes for those that aren't familiar with using curbside pickups (using KTD):

1. Enable the CurbsidePickup system preference.

2. To configure curbside pickup for libraries, go to Administration > Patrons and circulation > Curbside pickup.

3. Select the tab and configure the libraries for this test (Centerville and Franklin):
   - Enable: toggle this so it is selected
   - Pickup interval: 5
   - Maximum patrons per interval: 2
   - Patron-scheduled pickup: toggle this so it is selected
   - For Curbside pickup hours: select the day and 'from' times as per the test plan (and enter an ending time, for example 08:12 to 20:00)
   - Click the 'Save configuration' button

4. Place a hold for a patron (I used koha) and then check an item in so that the hold is waiting for pickup (I used 39999000011418).

5. Log in to the OPAC (I used the koha user) and go to Your account > Curbside pickups > Schedule a pickup.

6. Select the library from the dropdown list, then click on the pickup date to see the calendar.
Comment 4 Tomás Cohen Arazi 2023-02-21 12:57:16 UTC
Created attachment 147025 [details] [review]
Bug 32653: Fix curbside pickup if configured on more than 1 branch

If curbside pickup is configured on more than 1 branch, the calendar
will not display the correct day.

We are always selecting the days for the last branch.

Test plan:
Configure curbside pickup for
CPL Monday 8:12
FPL Tuesday 12:15

Login at the opac, select CPL, notice Tuesday are available

Apply the patch and confirm all is working correctly now.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi 2023-02-22 12:08:14 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 6 Jacob O'Mara 2023-02-24 11:33:01 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 7 Jacob O'Mara 2023-02-24 11:36:13 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 8 Lucas Gass 2023-03-01 14:56:48 UTC
Missing dependencies for 22.05.x, no backport.