If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch.
Created attachment 145362 [details] [review] Bug 32653: Fix curbside pickup if configured on more than 1 branch If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. Test plan: Configure curbside pickup for CPL Monday 8:12 FPL Tuesday 12:15 Login at the opac, select CPL, notice Tuesday are available Apply the patch and confirm all is working correctly now.
Created attachment 145368 [details] [review] Bug 32653: Fix curbside pickup if configured on more than 1 branch If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. Test plan: Configure curbside pickup for CPL Monday 8:12 FPL Tuesday 12:15 Login at the opac, select CPL, notice Tuesday are available Apply the patch and confirm all is working correctly now. Signed-off-by: David Nind <david@davidnind.com>
Testing notes for those that aren't familiar with using curbside pickups (using KTD): 1. Enable the CurbsidePickup system preference. 2. To configure curbside pickup for libraries, go to Administration > Patrons and circulation > Curbside pickup. 3. Select the tab and configure the libraries for this test (Centerville and Franklin): - Enable: toggle this so it is selected - Pickup interval: 5 - Maximum patrons per interval: 2 - Patron-scheduled pickup: toggle this so it is selected - For Curbside pickup hours: select the day and 'from' times as per the test plan (and enter an ending time, for example 08:12 to 20:00) - Click the 'Save configuration' button 4. Place a hold for a patron (I used koha) and then check an item in so that the hold is waiting for pickup (I used 39999000011418). 5. Log in to the OPAC (I used the koha user) and go to Your account > Curbside pickups > Schedule a pickup. 6. Select the library from the dropdown list, then click on the pickup date to see the calendar.
Created attachment 147025 [details] [review] Bug 32653: Fix curbside pickup if configured on more than 1 branch If curbside pickup is configured on more than 1 branch, the calendar will not display the correct day. We are always selecting the days for the last branch. Test plan: Configure curbside pickup for CPL Monday 8:12 FPL Tuesday 12:15 Login at the opac, select CPL, notice Tuesday are available Apply the patch and confirm all is working correctly now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 22.11. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Missing dependencies for 22.05.x, no backport.