System preference IncludeSeeFromInSearches has an impact on search results. Some matches may not contain the search terms. Would be useful to show a tip text in advanced search when this is enabled.
Created attachment 139008 [details] [review] Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 47) Check you don't see tip text in "Search for"
Created attachment 139009 [details] Screenshot with patch
If this patch is OK I will create one for OPAC
I've tested and it looks OK to me.
Thanks a lot for testing. This information can be very useful because some search results may not contain the search terms.
What do you think about using the fa-info-circle icon instead?
(In reply to Owen Leonard from comment #6) > What do you think about using the fa-info-circle icon instead? Sure, its even better
Created attachment 140882 [details] [review] Bug 31338: (follow-up) Use fa-info-circle icon
(In reply to Fridolin Somers from comment #7) > (In reply to Owen Leonard from comment #6) > > What do you think about using the fa-info-circle icon instead? > > Sure, its even better This icon is already used in several places.
Created attachment 140910 [details] [review] Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 47) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 140911 [details] [review] Bug 31338: (follow-up) Use fa-info-circle icon Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Maybe a bit nitpicky but my color contrast checker tells me this text on the ( #F4F8F9 ) does not pass WCAG AA standards. Can we have a bit darker text color?
(In reply to Lucas Gass from comment #12) > Maybe a bit nitpicky but my color contrast checker tells me this text on the > ( #F4F8F9 ) does not pass WCAG AA standards. > > Can we have a bit darker text color? Ah sure. I found there is class 'tip' with grey #888 and 'hint' with darker grey #666. Should I use 'hint' ?
(In reply to Fridolin Somers from comment #13) > (In reply to Lucas Gass from comment #12) > > Maybe a bit nitpicky but my color contrast checker tells me this text on the > > ( #F4F8F9 ) does not pass WCAG AA standards. > > > > Can we have a bit darker text color? > > Ah sure. > I found there is class 'tip' with grey #888 and 'hint' with darker grey #666. > Should I use 'hint' ? Yes, if we can use #666 as the text color it will pass accessibility checks.
Created attachment 141008 [details] [review] Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan : 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 7) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I've changed for 'hint' and squashed the patches. Looks like 'hint' is way more used that 'tip' (mainly used for header search boxes). Maybe we should replace 'tip' with 'hint' to have only one class for this usage.
Created attachment 141010 [details] [review] Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan : 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 7) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to Fridolin Somers from comment #16) > I've changed for 'hint' and squashed the patches. > > Looks like 'hint' is way more used that 'tip' (mainly used for header search > boxes). > Maybe we should replace 'tip' with 'hint' to have only one class for this > usage. It would be good to standardize the usage of these components, IMO.
I created Bug 31667
Created attachment 141177 [details] Screenshot of OPAC with patch
I almost fergot to add also to OPAC
Created attachment 141178 [details] [review] Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses <div> instead of <p>. And adds the same feature to OPAC.
Created attachment 141395 [details] [review] Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan : 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 7) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 141396 [details] [review] Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses <div> instead of <p>. And adds the same feature to OPAC. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
This worked in both the staff interface and the OPAC.
This works well and can be hidden easily. I am still a bit worried that patrons will have no idea how authorities work and not understand what we are talking about here :) See from (non-preferred form) headings are included I think a normal user doesn't even now what a heading is? Maybe we could discuss to change it up later to be a little less librarianese? Maybe talking about alternative spellings... synonyms or such?
Created attachment 141530 [details] [review] Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan : 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 7) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 141531 [details] [review] Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses <div> instead of <p>. And adds the same feature to OPAC. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Please rebase.
Created attachment 144547 [details] [review] Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses <div> instead of <p>. And adds the same feature to OPAC. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144548 [details] [review] Bug 31338: Show in advanced search when IncludeSeeFromInSearches is used Test plan : 1) Apply patch 2) Set system preference IncludeSeeFromInSearches to "Include" 3) Go to staff interface advanced search 4) Check you see tip text in "Search for" 5) Set system preference IncludeSeeFromInSearches to "Don't include" 6) Go to staff interface advanced search 7) Check you don't see tip text in "Search for" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 144549 [details] [review] Bug 31338: (follow-up) add special class and add also to OPAC In order to easily hide this new text, this patch adds the class "included-see-from-headings-info". Also uses <div> instead of <p>. And adds the same feature to OPAC. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Tomás Cohen Arazi from comment #29) > Please rebase. Easy rebase, I've set back to PQA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Enhancement will not be backported to 22.05.x.